| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
Use the defaults in the pkg check where the default error message is
sufficient to identify which package is missing.
Change-Id: If14318cbb16f40cac4bd94b5b7d81cf9d3aacfdc
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
|
|
|
|
| |
Add errors to watch for through error YAML file
Add support for checkstop error type
Tested:
Generating dumps for elog, core, checkstop type errors.
Change-Id: Idd00ace2e3d0c472a74ec142e6d150e55e843a6f
Signed-off-by: Marri Devender Rao <devenrao@in.ibm.com>
|
|
|
|
|
|
|
| |
Update configure.ac to choose the c++17 standard
Change-Id: I3636e54a746c9f9312f5d01ac83113204ed78a46
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
During application core, Systemd-coredump creates a temporary core
file first, compresses the file and renames it to systemd-coredump
name format.
dreport relies on inotify notifications to initiate the core dump
collection.
Usually inotify generates IN_MOVED_TO events followed
by IN_CLOSE_WRITE event on creation of system-coredump file.
In UBI filesystem, inotify notification events behave
differently as summarized below:
--------------------------------------------------------------------
Inotifiy Event : UBI FS : COW
--------------------------------------------------------------------
- IN_MOVED_TO : _NA_ : notification event
: : structure provides the
: : name of the core file.
: :
- IN_CREATE : notification event : _NA_
: structure provides :
: the name of the core :
: file. :
: :
- IN_CLOSE_NOWRITE : notification triggers: _NA_
: directory level and :
: size of name field :
: shows zero. :
: :
: :
- IN_CLOSE_WRITE : notification event : notification event
: structure provides : structure provides the
: the INODE number : name of the core file.
: instead of name of :
: the core file. :
----------------------------------------------------------------------
Current implementation relies on inotify IN_CLOSE_WRITE event with the
name of the core file to trigger the dump collection.
However, in UBI FS, the inode number is sent in the inotify instead of
the name of the core file.
Hence the copying of the core file during the dump collection process
fails due to lack of the file name information.
While IN_CLOSE_WRITE is the appropriate event, IN_CREATE is the
closest match for UBI FS.
Hence the *workaround* published by this patch watches for IN_CREATE
event for the UBI FS based systems.
One possible side effect is premature handling of large systemd-core
file resulting in an incomplete file. However, this was _not_ observed
during testing due to the time interval between the inotify and
dreport consuming the file.
A more generic fix may be explored for issue #2287.
Resolves openbmc/openbmc#2240
Change-Id: Id88181c62a34c05646eed4ac7e67d9b37a523733
Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
|
|
|
|
|
| |
Change-Id: Ib6d212e730d25eb14ceed5b5f3f222ee3b47b35c
Signed-off-by: Vishwanatha Subbanna <vishwa@linux.vnet.ibm.com>
|
|
|
|
|
|
|
| |
Resolves openbmc/openbmc#2078
Change-Id: Iea47b9b7c0cd6cae21642057b21c4e99d85be1e8
Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
|
|
|
|
|
| |
Change-Id: I2a362b674022dbe1ea8bfe16876d0416f87d0af1
Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
|
|
|
|
|
|
|
|
| |
Changed the dump storage location from /tmp/dumps to
/var/lib/phosphor-debug-collector/dumps.
Change-Id: Ic77127e8e947cf7f15f62e1048604c9c3acaccd1
Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
|
|
|
|
|
|
|
|
|
| |
Added support for collecting mini dump data incase available
dump size is less than maximum dump size. Introduced minimum
dump size to achieve this.
Change-Id: I266ff6ea71443974a99f6f5fe54fb9f12c90f2ab
Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Calculate number of dumps allowed in a system based on
individual dump Max size configured in the system.
Algorithm: Setting Dump size to maximum size,
if (dump entries + active dumps) is less than total allowed dump entries.
Otherwise return error.
Next patch will provide additional algorithm to cap the
dump based on actual size of the dump files.
Change-Id: Id8916a31d72f5c2f2f23eaf68062b829b7e4100c
Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
|
|
|
|
|
| |
Change-Id: I85974e00c31f5179106674ececeb53072008a83d
Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
|
|
|
|
|
|
|
|
| |
Both the external and internal Dump managers define "Create"
interfaces. This commit implements these.
Change-Id: If857ec6ea7267fd72e9b420e6b44fa68b6abab66
Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
|
|
|
|
|
|
|
| |
Fixes openbmc/openbmc#1774
Change-Id: Iad02c5df4083f5509f706cc64cc68bc7cd5e7391
Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
|
|
|
|
|
|
|
|
|
| |
Add an inotify watch to the known core dump location.
Resolves openbmc/openbmc#1504
Change-Id: I0093c9f601d82917ca2efb53a4d47ed98f0eaa7f
Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
|
|
|
|
|
| |
Change-Id: I098e8b29834fd726574126ec589a883ba952b298
Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
|
|
Added initial version of Dump infrastructre code.
Change-Id: Icd9bc779035d12d2dabd6f49d0d04e9aa060d6c1
Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
|