| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
Use the defaults in the pkg check where the default error message is
sufficient to identify which package is missing.
Change-Id: If14318cbb16f40cac4bd94b5b7d81cf9d3aacfdc
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
|
|
|
| |
Set the config value for the scripts that need to be
invoked during dump collection for checkstop error.
Checkstop dump enum type has value 4.
Change-Id: Ic75fa0f800ed459b8e493b191eec18f144664655
Signed-off-by: Marri Devender Rao <devenrao@in.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
| |
Add errors to watch for through error YAML file
Add support for checkstop error type
Tested:
Generating dumps for elog, core, checkstop type errors.
Change-Id: Idd00ace2e3d0c472a74ec142e6d150e55e843a6f
Signed-off-by: Marri Devender Rao <devenrao@in.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
phosphor-hostlogger project stores host's console output data, such as
boot logs or Linux kernel messages printed to the system console.
https://github.com/openbmc/phosphor-hostlogger
Tested: Run dreport inside the BMC console, the result dump archive must
contains host console logs.
Change-Id: Icc45888a43b42de78c93aa0bc0ba7a295f0a76e3
Signed-off-by: Artem Senichev <artemsen@gmail.com>
Tested-by: Artem Senichev <artemsen@gmail.com>
|
|
|
|
|
| |
Change-Id: Ide3f7c1e4e96ae07a99055a2a14e5d376e51d6b4
Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
|
|
|
|
|
|
| |
Change-Id: Ib640ef7cea99ff505965182ec9900a2d53a8986e
Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
|
|
|
|
|
| |
This allows us to not depend on specific include ordering.
Change-Id: I4d2a552eb4b4d5dcf0aaf9ad9be3b86265ca469a
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
|
|
|
|
|
| |
Update configure.ac to choose the c++17 standard
Change-Id: I3636e54a746c9f9312f5d01ac83113204ed78a46
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Requests come in the form "oa{sa{sv}}". However, the way sdbusplus was
interpreting the type of our message "a{oa{sa{sv}}}" since tuples are
not allowed to consume multiple arguments during the read call as that
would be ambiguous. This fixes the type issues.
Prior to the change to sdbusplus that introduces error handling for the
read calls, the sd_bus_message_{enter,exit}_container were failing
during the read on the pair. Luckily this produces the expected result
for the read and our old code was "working".
This also cleans up an unnecessary string move.
Tested:
Builds and no longer produces errors on zaius when elogs are added.
Change-Id: Ifc5394f3f361e8932c939376bd0bf5b4e3ca589c
Signed-off-by: William A. Kennington III <wak@google.com>
|
|
|
|
|
|
|
|
|
|
| |
Some of the signals we try and parse for error logs are not structured
in the format we expect when parsing. When error logging is enabled in
sdbusplus this causes the phosphor-dump-manager to crash. Fix this
crashing by logging errors and ignoring the bad signals.
Change-Id: Ieadcb7e95f622005382f3c4957bf1535e3bb1ef9
Signed-off-by: William A. Kennington III <wak@google.com>
|
|
|
|
|
| |
Change-Id: I37b3967b1feeedf40677d79ca684070378123952
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
|
|
|
|
|
|
|
|
|
| |
Resolves openbmc/openbmc#2905
Tested: static_assert only
Change-Id: Ib3b74591ca2d26e5f4e0afac508fc248756e0905
Signed-off-by: Joseph Reynolds <jrey@us.ibm.com>
|
|
|
|
|
|
|
|
| |
Took a .gitignore from another repo and added a few repo
specific items.
Change-Id: I46c85976d8c89cb469d476357a412e9c06bb644e
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
|
|
|
|
|
|
|
| |
Spelling errors found using github.com/lucasdemarchi/codespell
A tool to fix common misspellings.
This tool is licensed under GNU General Public License, version 2.
Change-Id: I192b40fcab98b64e39b3100d41ea025ca280d842
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
|
|
|
|
|
|
| |
std::function is not found with a GCC 7.2 runtime.
Change-Id: Id28ea8da225c6bae0742848ba3d379fbafcfc190
Tested: Built repository with GCC 7.2
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
|
|
|
|
|
|
|
|
| |
Plugin used for collecting alt flash U-boot
environment variables.
Resolves openbmc/openbmc#2862
Change-Id: Ife6eec8e85640e1933771cd149c49f1579430473
Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
|
|
|
|
|
|
|
|
|
|
| |
Plugin used for collecting primary flash U-boot
environment variables.
Resolves partially openbmc/openbmc#2862
Change-Id: I9cffd936575311a39d8006b84a612f0223158fbb
Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
dreport uses PID information from the elog or core file to
collect PID based journal logs as part the BMC dump.
Existing dreport skips journal log collection in case PID
information is missing in the elog or core file.
Proposed changes help to collect the last 500 journal entries when
the PID is not present in the elog entry or core file.
Resolves openbmc/openbmc#2716
Change-Id: Ib3d8dfea64ea17f4b020b429267294c36530848b
Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
|
|
|
|
|
|
|
| |
Resolves openbmc/openbmc#2537
Change-Id: Id5ce18da3652e39edf3b970a99c75424ed039c35
Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
|
|
|
|
|
| |
Change-Id: I1ec3489330abf23eaf87e26a12424d1949f3bf4b
Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
|
|
|
|
|
| |
Change-Id: Ifbb6754aa860ac2dab693c76bf14c54e1df6dc9c
Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
|
|
|
|
|
|
|
|
| |
GetManagedObjects based elog data collection will reduce
to one d-bus call, for entire elog properties dump.
Change-Id: I2d2a5922418e0c26b5cf93d94203747121910a50
Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
| |
Enabled dreport based debug data collection by default
in the ffdc tool.
Added -D option to disable the dreport based data collection
and switch back to ffdc way.
Change-Id: I429533d3d04495ea3cda2bcb2b1090f1d971d530
Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit ab741df3415931d146460af88e79716e4bd40fe2.
ffdc -e option is no longer used by dump manager and it
is replaced by dreport.
Change-Id: I8a0c5f8627fa87571541b578711fc91bdd0ff4b8
Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
|
|
|
|
|
|
|
|
|
| |
Spelling errors found using github.com/lucasdemarchi/codespell
A tool to fix common misspellings.
This tool is licensed under GNU General Public License, version 2.
Change-Id: I562cc5b407fb2a3a728c6167aaab75acde3adfca
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
|
|
|
|
|
|
| |
Journal entry variable names should be uppercase.
https://www.freedesktop.org/software/systemd/man/sd_journal_print.html
Change-Id: I074955883c67173c9720f094d494addb85c85e7a
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
|
|
|
|
|
|
|
|
| |
Refactor existing dreport to support new plugin
based reporting infrastructure.
Resolves openbmc/openbmc#2351
Change-Id: Ibf078cf0609e93a873dbcb28a9bfdc25b182500f
Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
|
|
|
|
|
|
|
|
| |
Plugin used for moving dreport requestd core file
into the dreport packaging.
Change-Id: I927841ac82394b8736331169d91968feec11f4d5
Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
|
|
|
|
|
|
|
|
| |
Plugin used for collecting systemd failed units
information.
Change-Id: Icc5f910f613b78fef2e7e557ddfe85692904bce2
Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
|
|
|
|
|
|
|
| |
Plugin used for collecting BMC cpu core information.
Change-Id: I3cddd89ebe1468d131ddef8ba517ae68aa30c8ab
Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
|
|
|
|
|
|
|
| |
Plugin used for collecting uptime command output data.
Change-Id: Ia6e7f815c4c8e0106cbe77c2c433ff1a01775f95
Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
|
|
|
|
|
|
|
| |
Plugin used for collecting BMC disk usage data.
Change-Id: I507a7516453aeff7b7675a41a52ec54b881c6ca1
Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
|
|
|
|
|
|
|
| |
Plugin used for collecting OS release information.
Change-Id: I27fcc47f3a0a1d44aa07001ec61f43d6bf523bf0
Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
|
|
|
|
|
|
|
| |
Plugin used for collecting current hostname settings.
Change-Id: Ie328931a1de648649397d1525f6efaf960a0964e
Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
|
|
|
|
|
|
|
|
| |
Plugin used for collecting top command output, which
provides linux process details.
Change-Id: I54633512b6b459d808379467a2f6e77c1ffb0fb8
Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
|
|
|
|
|
|
|
|
| |
Plugin used for collecting information about the
systems RAM usage.
Change-Id: I5a3de1442355d913e08675fa1713a0feb4d5bef4
Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
|
|
|
|
|
|
|
| |
Plugin used for collecting OBMC console log data.
Change-Id: I959442e7a1c4cc78934b49a10326f8c16920637a
Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
|
|
|
|
|
|
|
| |
Plugin used for collecting journal pretty log data.
Change-Id: I5923708f0f08800d8c3d75faeabc2b9b09999b2d
Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
|
|
|
|
|
|
|
|
| |
Added plugin for collecting user initialized PID
specific journal log data.
Change-Id: Ifc6243c288d94aceba65709b028841b344e02132
Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
|
|
|
|
|
|
|
|
| |
Plugin used for collecting only user initialized
elog ID details.
Change-Id: I62d6e2bc289b739cbb165e85caafe4b584fa626c
Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
|
|
|
|
|
|
|
| |
Plugin used for collecting all elogs from the BMC.
Change-Id: I64cc74aef5beba62da203714734b67af370da9d7
Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
|
|
|
|
|
|
|
| |
Plugin used for collecting HOST state information.
Change-Id: I91143aaf9b0c0c9a33049df5d84216fd29c6e00f
Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
|
|
|
|
|
|
|
| |
Plugin used for collecting Chassis state information.
Change-Id: I9aafd402e6300d7139bdf1ffb4cea60bf0589020
Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
|
|
|
|
|
|
|
| |
Plugin used for collecting BMC state information.
Change-Id: Id22c18757acabf4944a2b136f1f14abf19021a6a
Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
|
|
|
|
|
|
|
|
| |
Moved the common functions used by dreport and plugins into
new file.
Change-Id: Ia88fdae4dddc4ef61e3864437e2972807749502a
Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
This file is dreport configuration file and is where all
dreport configuration settings are placed.
The configuration file consists of sections, led by a
[section] header and followed by name: value entries,
with continuations in the style INI format.
Change-Id: Ia3968216250e2756cd95ea605cd07ff21013af26
Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
During application core, Systemd-coredump creates a temporary core
file first, compresses the file and renames it to systemd-coredump
name format.
dreport relies on inotify notifications to initiate the core dump
collection.
Usually inotify generates IN_MOVED_TO events followed
by IN_CLOSE_WRITE event on creation of system-coredump file.
In UBI filesystem, inotify notification events behave
differently as summarized below:
--------------------------------------------------------------------
Inotifiy Event : UBI FS : COW
--------------------------------------------------------------------
- IN_MOVED_TO : _NA_ : notification event
: : structure provides the
: : name of the core file.
: :
- IN_CREATE : notification event : _NA_
: structure provides :
: the name of the core :
: file. :
: :
- IN_CLOSE_NOWRITE : notification triggers: _NA_
: directory level and :
: size of name field :
: shows zero. :
: :
: :
- IN_CLOSE_WRITE : notification event : notification event
: structure provides : structure provides the
: the INODE number : name of the core file.
: instead of name of :
: the core file. :
----------------------------------------------------------------------
Current implementation relies on inotify IN_CLOSE_WRITE event with the
name of the core file to trigger the dump collection.
However, in UBI FS, the inode number is sent in the inotify instead of
the name of the core file.
Hence the copying of the core file during the dump collection process
fails due to lack of the file name information.
While IN_CLOSE_WRITE is the appropriate event, IN_CREATE is the
closest match for UBI FS.
Hence the *workaround* published by this patch watches for IN_CREATE
event for the UBI FS based systems.
One possible side effect is premature handling of large systemd-core
file resulting in an incomplete file. However, this was _not_ observed
during testing due to the time interval between the inotify and
dreport consuming the file.
A more generic fix may be explored for issue #2287.
Resolves openbmc/openbmc#2240
Change-Id: Id88181c62a34c05646eed4ac7e67d9b37a523733
Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
|
|
|
|
|
| |
Change-Id: Ib6d212e730d25eb14ceed5b5f3f222ee3b47b35c
Signed-off-by: Vishwanatha Subbanna <vishwa@linux.vnet.ibm.com>
|
|
|
|
|
|
|
| |
Resolves openbmc/openbmc#2255
Change-Id: I8383c55f0f55ac02e509d17c47bc66d326994301
Signed-off-by: Nagaraju Goruganti <ngorugan@in.ibm.com>
|
|
|
|
|
|
|
|
|
| |
This commit provides a fix for an issue in which the cereal
deserialize() would crash the phosphor-dump-manager incase
persistence file is empty in restore path.
Change-Id: I25259acf50f67cbc8d7b7ac3030bd7bfffbdfa47
Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
|