summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* PRD: fix Explorer FSI address workaround in FIRDATA codeZane Shelley2019-09-271-5/+5
| | | | | | | | | | | | | | | | | | | There was a previous workaround to stub out filling in the FSI address for Explorer in the FIRDATA code for checkstop analysis. That workaround would fill in the FSI address for processor chips before initializing the structure that contains the FSI address. Therefore, the FSI address for processors would always get initialized to 0xffffffff. The fix is to simply put the code in the correct order. Change-Id: Id76ec015ffec1565236481fcc14be6c1a3145d28 CQ: SW474413 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84369 Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Zane C Shelley <zshelle@us.ibm.com>
* PRD: Initial Axone Channel Fail supportCaleb Palmer2019-09-2710-45/+813
| | | | | | | | | | | | | Change-Id: I1a86cd97e2188409a1fbcc2fd8981ad5e162214f RTC: 212714 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83667 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: Paul Greenwood <paul.greenwood@ibm.com> Reviewed-by: Zane C Shelley <zshelle@us.ibm.com> Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84365 Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
* PRD: add virtual destructor to ScomRegister classZane Shelley2019-09-271-0/+3
| | | | | | | | | | | | | | Change-Id: I6f8c9bc98d87ed48fa23c73dfb168121d36ca3ea Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84042 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: Caleb N Palmer <cnpalmer@us.ibm.com> Reviewed-by: Benjamen G Tyner <ben.tyner@ibm.com> Reviewed-by: Paul Greenwood <paul.greenwood@ibm.com> Reviewed-by: Zane C Shelley <zshelle@us.ibm.com> Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84364 Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
* Make snprintf always terminate the output bufferZach Clark2019-09-271-6/+24
| | | | | | | | | | | | | | | | | | | | | | Previously, the snprintf function would not terminate the output buffer if it had already filled the entire buffer with characters. This would lead to the creation of unterminated strings which could result in buffer overreads and/or information disclosures. This commit fixes that issue, making it conform to the C99 standard (section 7.19.6.5). Also addresses a buffer underflow that could occur when the source string to an sprintf call contains too many \b characters. Change-Id: Ie516b1c7d74d37cc5f48fe03693f096fe4bd6c02 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84349 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: William G Hoffa <wghoffa@us.ibm.com>
* PRD: NVDIMM workaround for ES TEMP glitchesCaleb Palmer2019-09-272-16/+66
| | | | | | | | | | | | | | | | | | | | | | There is currently a glitch with the energy source temperature readings. We are getting intermittent incorrect readings for the temperature that is causing us to analyze to an ES temperature warning or error because of these glitched readings. This is a workaround to make the ES temp logs hidden until we hit threshold. The fix for the root cause of the glitches will need to come from SMART. Change-Id: I8df3f2531fda2e4c0273bfe3714c7efb9662971d CQ: SW476951 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84345 Reviewed-by: Paul Greenwood <paul.greenwood@ibm.com> Reviewed-by: Benjamen G Tyner <ben.tyner@ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Zane C Shelley <zshelle@us.ibm.com> Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84363 Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
* Fix race condition in BufferPage allocation functionZach Clark2019-09-261-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | BufferPage::claimEntry implements a lockfree algorithm to allocate space for trace messages within a single page of memory. In performing the bounds check for the allocation, a local copy of a member variable is created, and a compare-and-swap strategy is used to update the member variable with the new size of the allocated portion of the buffer. However, in the bounds check, the member variable was mistakenly used, rather than the local copy. This leads to a race condition where if the member variable is updated in memory by another thread between the time that its value is loaded from memory for the bounds check and loaded again for the local variable, the bounds check can succeed when it should fail and the allocation can go beyond the bounds of the page owned by the BufferPage object. This issue manifests only when the claimEntry function is compiled by GCC (versions 4.9.2 and 8.2.0 tested) with size optimization (-Os) because at this level, the compiler emits two load instructions for the value of the member variable. Using -O3, only a single load instruction is emitted and so the race condition is averted. Change-Id: I89fbffee9806972bab410c4bc75022a33793b453 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84284 Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com> Reviewed-by: Glenn Miles <milesg@ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Nicholas E Bofferding <bofferdn@us.ibm.com>
* Disable OMI deconfig testsChristian Geddes2019-09-261-1/+1
| | | | | | | | | | | | | | | | | | These tests cannot run as part of the standard test suite as they disrupt targeting expectations from other tests that are running in parallel. Currently we are seeing other tests cases that use the OMI/OCMB targets to fail intermittently because targets are missing. Change-Id: Id152e6f571465fee22bae5789eb9a92643738d4b Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84250 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: Matt Derksen <mderkse1@us.ibm.com> Reviewed-by: Glenn Miles <milesg@ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Roland Veloz <rveloz@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Support EXP_FW_LOG command to get Explorer Firmware logsMatt Derksen2019-09-2513-10/+1047
| | | | | | | | | | | | | | | | | Includes framework to add explorer error logs to an error. Tests the ekb RC path and the hostboot way to add these logs. Tests are disabled until simics supports the new command. Change-Id: I03b735342251b6c9e078a3e5b412e5a9f88e1e6b RTC:205128 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/82362 Reviewed-by: Christian R Geddes <crgeddes@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Glenn Miles <milesg@ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Support EXP_FW_LOG command to get Explorer FW logsMatt Derksen2019-09-259-5/+794
| | | | | | | | | | | | Framework to send inband command and a proof of concept adding explorer error log data via collectFfdc RC. Change-Id: I41be5598eb6fb3239fd933e0a0563d1a99ed2fa0 RTC:205128 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/82372 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Fixed pre-req check during NVDimm ArmMATTHEW I. HICKMAN2019-09-251-1/+61
| | | | | | | | | | | | CQ:SW475280 Change-Id: I15634923e18dfecb18146e9ec33ed128111f517c Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83484 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: TSUNG K YEUNG <tyeung@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Fixed several Arm error handling bugsMATTHEW I. HICKMAN2019-09-256-15/+43
| | | | | | | | | | | | CQ:SW475445 Change-Id: I19cd03850b65a23d2a35c9160352cdc7a4946667 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83534 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: TSUNG K YEUNG <tyeung@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Merging of Serverwiz and hostboot repo Targets.pmGiridhari Krishnan2019-09-251-1/+37
| | | | | | | | | | | | | file, so to have a common version at start. This common version is pulled to hostboot repo for use. Change-Id: I2024fb0a344375ac1d4705a9b9a7b77f2dc774ab Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/82062 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Remove Unused clearPoreBars function in Istep 21.3Bill Hoffa2019-09-251-94/+1
| | | | | | | | | | | | | | | | - This functionality was never used so remove it Change-Id: I2885be14c4bbf68e322a8a52f9364210e6943ca9 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84183 Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com> Reviewed-by: Ilya Smirnov <ismirno@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: Dean Sanner <dsanner@us.ibm.com> Reviewed-by: Christian R Geddes <crgeddes@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: William G Hoffa <wghoffa@us.ibm.com>
* Add a ReadMe to explain high level BPM Update ProcessMatthew Raybuck2019-09-241-0/+147
| | | | | | | | | | | | | | | | | | Adds a readme to explain some of the background info, the update process, and point out the various files that the BPM update process relies on to succeed. Change-Id: I572f8789eab231d4f97e53eb7bfb8e7f94c2cc42 RTC: 212448 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/82675 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Christian R Geddes <crgeddes@us.ibm.com> Reviewed-by: Matt Derksen <mderkse1@us.ibm.com> Reviewed-by: Roland Veloz <rveloz@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Double the NVDIMM_READY timeout to prevent erroneous errorTsung Yeung2019-09-241-2/+2
| | | | | | | | | | | | | | | | NVDIMM controller POR or firmware induced reset time may vary from run-to-run. Doubling the timeout here in case of edge condition. Change-Id: I717dfbef9b2903e8bb1e7aed92c28df1fab90033 CQ:SW476597 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84107 Reviewed-by: Matt Derksen <mderkse1@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Corey V Swenson <cswenson@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Add wrapper to exp_getidec HWP so we can call it in platform codeChristian Geddes2019-09-207-1/+191
| | | | | | | | | | | | | | | | | | | | | There has been a trend to create more HWPs that process raw data. This allows Hostboot and Cronus to share more code. The trick is that we generally want to call these HWPs inside traditionally hostboot-only code. This new fapiwrap directory will help encapsulate all of the calls to ekb code in one place. That way if we ever need to remove HWPs/EKB code it will be easier to stub out the calls. In the past we have contaminated a lot of Hostboot-only code with calls out to EKB code. This new new directory should help avoid this issue. Change-Id: I2b2d0d1e62c97f0976c9c9ede3fe2eac30c7a40f RTC: 214627 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83029 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Ilya Smirnov <ismirno@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* PRD: Lane repair OMI bus callout changesCaleb Palmer2019-09-192-17/+26
| | | | | | | | | | | | | Change-Id: I6c282e0d3db63df2bb9badbf717f75aff16e6c4e Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83666 Reviewed-by: Benjamen G Tyner <ben.tyner@ibm.com> Reviewed-by: Paul Greenwood <paul.greenwood@ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: Zane C Shelley <zshelle@us.ibm.com> Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84008 Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
* PRD: Fix UNIT_CS analysis in OCMB chiplet FIRCaleb Palmer2019-09-191-1/+1
| | | | | | | | | | | | | | Change-Id: I1237a42d416cca9aac9014bcffe38ac138632d9d Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83665 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: Benjamen G Tyner <ben.tyner@ibm.com> Reviewed-by: Paul Greenwood <paul.greenwood@ibm.com> Reviewed-by: Brian J Stegmiller <bjs@us.ibm.com> Reviewed-by: Zane C Shelley <zshelle@us.ibm.com> Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84007 Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
* Enable SMF tests for AxoneDan Crowell2019-09-192-7/+17
| | | | | | | | | | | | | | | | Need to take multiple chips into account when computing the values to compare with. Change-Id: Ie423b2afec126f6e69590584631da9b6d6657a84 RTC: 206800 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83560 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: Ilya Smirnov <ismirno@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Matt Derksen <mderkse1@us.ibm.com> Reviewed-by: Nicholas E Bofferding <bofferdn@us.ibm.com>
* Fixed several small bugs found via code reviewMATTHEW I. HICKMAN2019-09-196-97/+152
| | | | | | | | | | | CQ:SW474830 Change-Id: I1ff22805b9bb3facf68d4d62ea66de169be9b98b Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83213 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Patch For: Implement Static Analysis with cppcheckLuis Fernandez2019-09-182-38/+34
| | | | | | | | | | | | | | | CPPCHECK commands fail in machines that do not use bin/sh. Wrap commands inside an if-statement to only be read when User explicitly run the tool. Change-Id: Ifad56b0978c8190efa033203f661daf9259a4d43 RTC: 201451 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83938 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* PRD: NVDIMM keep log hidden if no error found during analysisCaleb Palmer2019-09-182-18/+39
| | | | | | | | | | | | | Change-Id: I56d3444b2b9a87e34ce03da9a7a805cdc629d573 CQ: SW476229 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83930 Reviewed-by: Paul Greenwood <paul.greenwood@ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: Brian J Stegmiller <bjs@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Benjamen G Tyner <ben.tyner@ibm.com> Reviewed-by: Zane C Shelley <zshelle@us.ibm.com>
* Dummy commit to prime hwsv for new Explorer FFDC collectionMatt Derksen2019-09-181-0/+55
| | | | | | | | | | | | | | | | | | A new procedure is coming to grab Explorer Firmware Logs. This requires a new file to be mirrored to hwsv so ffdc_includes.H can be updated. Change-Id: Ia2c11d3273eb27e37bc7dc92d6b7059fe1ec679a RTC:205128 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83398 Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: Louis Stermole <stermole@us.ibm.com> Reviewed-by: Christian R Geddes <crgeddes@us.ibm.com> Reviewed-by: Jennifer A Stofer <stofer@us.ibm.com> Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83715 Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
* Add blank files for p9a_omi_setup procedureMark Pizzutillo2019-09-183-0/+72
| | | | | | | | | | | | | | | Change-Id: I1fb1c9d35b12cb46107d2b6f90587dfc0f2a058f Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83740 Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: Louis Stermole <stermole@us.ibm.com> Reviewed-by: STEPHEN GLANCY <sglancy@us.ibm.com> Reviewed-by: ANDRE A MARIN <aamarin@us.ibm.com> Reviewed-by: Jennifer A Stofer <stofer@us.ibm.com> Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83839 Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Christian R Geddes <crgeddes@us.ibm.com>
* Update explorer scom header files with newer figtree data.Ben Gass2019-09-178-7159/+7413
| | | | | | | | | | | | | | | | | Change-Id: I2ba7df5fdd7f532f9ad5c2fca202849d443bfea9 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83277 Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: Louis Stermole <stermole@us.ibm.com> Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com> Tested-by: HWSV CI <hwsv-ci+hostboot@us.ibm.com> Reviewed-by: STEPHEN GLANCY <sglancy@us.ibm.com> Dev-Ready: STEPHEN GLANCY <sglancy@us.ibm.com> Reviewed-by: Jennifer A Stofer <stofer@us.ibm.com> Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83427 Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Nicholas E Bofferding <bofferdn@us.ibm.com>
* Add Printk Traces to ThreadPool Unit TestsIlya Smirnov2019-09-161-0/+3
| | | | | | | | | | | | | | | | | | Some ThreadPool unit tests that test crashed tasks were missing printk logs to indicate the crashes were expected. This creates confusion when debugging printk logs. This commit adds the traces to indicate the crashes are expected and are part of the test. Change-Id: I38d2d886cfd73106e32fb4e461bba3d5a39a8032 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83783 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: Christian R Geddes <crgeddes@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Nicholas E Bofferding <bofferdn@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Update axone pnor layout to move eecache to the beginingChristian Geddes2019-09-162-9/+11
| | | | | | | | | | | | | | | | | Because we rely on having a stable offset for the EECACHE section of pnor we will move it to the start of the pnor layout. This will make it less likely to move around as now we are auto-adjusting offsets if sections like HBI happen to exceed to allotted space. Change-Id: I4463c9d1cfb6ba86c777c976f911b14be5a483e3 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83791 Reviewed-by: Zachary Clark <zach@ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: William G Hoffa <wghoffa@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Add pmic_i2c_addr_get function for platform code useMark Pizzutillo2019-09-161-0/+82
| | | | | | | | | | | | | Change-Id: I79b5bcc1ce8de9066aa87e793d38fab64752f17f Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83033 Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: STEPHEN GLANCY <sglancy@us.ibm.com> Reviewed-by: Christian R Geddes <crgeddes@us.ibm.com> Reviewed-by: Jennifer A Stofer <stofer@us.ibm.com> Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83735 Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
* Skip OCMB targets while decidng what targets to process for IpmiFruInvChristian Geddes2019-09-161-2/+7
| | | | | | | | | | | | | | | Some targets types will not have IPMI fru inventory classes associated with them, attempting to process them will result in an assert. Change-Id: I34cb080c981ac5d0008eb937c127e043ff077a27 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83433 Reviewed-by: William G Hoffa <wghoffa@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Christian R Geddes <crgeddes@us.ibm.com>
* Changed the callout in the call NVM Health Status to be an NVDIMMRoland Veloz2019-09-161-17/+48
| | | | | | | | | | | | | | | | | | | | | | | In the call nvDimmNvmCheckHealthStatus, the call is incorrectly using HB when it should be associated with NVDIMM. Switched out the addPartCallout with HWAS::BPM_PART_TYPE to a addHwCallout with the given NVDIMM. Also added more trace info to print out the registers that are being retrieved. Corrected the logic such that a good state passes. Apparently, the way the code was written, a good or bad state, both would fail. Now the good state passes and the bad state fails. Change-Id: I46b62ce3fe5c5ac86efb501e2a91fdea8160b9b5 CQ: SW475265 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83673 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Fix bad arguments to additional FFDC capture in BPM Update codeMatthew Raybuck2019-09-143-70/+102
| | | | | | | | | | | | | | | | In bpm_update.C there were two places where the wrong errl was being given as a parameter to FFDC functions. The errl supplied was nullptr causing hostboot to crash as a result. This commit fixes that by suppling the correct errl. Change-Id: I50e8459d2b3602177ca740059a706613402c3e95 RTC:212448 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83781 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Add ekb dual drop support for p9aMark Pizzutillo2019-09-145-76/+138
| | | | | | | | | | | | | | | | | | | | SPD and VPD will need to be revisited once we architect how this will work from the Cronus and HB side. In the meantime, we pass EKB unit tests so we are on the right track. Change-Id: Ie4516339dcc6e43ee1e6dd7aaaa9589fbfcace89 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83218 Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com> Reviewed-by: Louis Stermole <stermole@us.ibm.com> Reviewed-by: STEPHEN GLANCY <sglancy@us.ibm.com> Dev-Ready: STEPHEN GLANCY <sglancy@us.ibm.com> Reviewed-by: Jennifer A Stofer <stofer@us.ibm.com> Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83436 Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Nicholas E Bofferding <bofferdn@us.ibm.com>
* NVDIMM: FW_UPDATE: New FFDC for SECURITY_ERRORCorey Swenson2019-09-135-2/+94
| | | | | | | | | | | | | | | For any command error or timeout during FW_UPDATE add regs to error log. Registers specified in NVDIMM IPL Error Handling Document. CQ:SW473060 Change-Id: I3ca8933b9c62f0b12bebefbae06357400e8e436e Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83590 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Add vendor log data to FFDC for all NVDIMM HW errorsCorey Swenson2019-09-138-3/+827
| | | | | | | | | | | | | Read vendor log data from NVDIMM Do checksum compare Add to error log as string Change-Id: I41a295bf54d031c978b59fe1f59c98507fbeec81 CQ:SW473585 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83383 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Apply MC_HANG timeout workaround to all processorsChristian Geddes2019-09-131-59/+45
| | | | | | | | | | | | | | | | When we initially added this workaround for whatever reason we specified the master proc only. It needs to be applied to all procesors in the system. Change-Id: I5840f2b0670f1790393a385f045ee656ad76bef8 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83594 Reviewed-by: Michael Baiocchi <mbaiocch@us.ibm.com> Reviewed-by: Zachary Clark <zach@ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Update startup.simics To Disable SBE UpdatesIlya Smirnov2019-09-131-3/+3
| | | | | | | | | | | | | | | Update the startup.simics command to disable SBE update using new simics UI. Change-Id: I80ab844fe5dcb976b9d41907ac3803e12edb801a Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83736 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Michael Baiocchi <mbaiocch@us.ibm.com> Reviewed-by: Matthew Raybuck <matthew.raybuck@ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Do not allow PNOR partition adjustments when not in test modeDan Crowell2019-09-121-1/+1
| | | | | | | | | | | | | | | | | | In some cases we were seeing confusing error messages while building pnor images in op-build that pointed at the wrong partition being the problem. This was caused by some logic that automatically adjusts the size of the HBI partition to handle our testcase environment. Change-Id: Ib6089ca9a0c68d4c8814fe7a36404096b42837b7 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/82952 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Zachary Clark <zach@ibm.com> Reviewed-by: Michael Baiocchi <mbaiocch@us.ibm.com> Reviewed-by: William G Hoffa <wghoffa@us.ibm.com>
* NVDIMM: Additional FFDC for NVDIMM/BPM calloutsCorey Swenson2019-09-128-1/+189
| | | | | | | | | | | | Add page 4 SMART regs to error log FFDC for all NVDIMM HW errors. Add attribute to prevent recursively executing the function. Change-Id: I2cdd89436a2647c440f900a729596b522829aca6 CQ:SW470690 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/82599 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Re-enable mss_scrub in istep16 for axone systemsChristian Geddes2019-09-121-8/+0
| | | | | | | | | | | | | | | | This step was disabled during bringup. Workarounds in place now so we can call it again. Change-Id: I6aaaf77173cdcf45771f1072fcab67b09546da86 RTC: 213933 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83200 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Matt Derksen <mderkse1@us.ibm.com> Reviewed-by: Ilya Smirnov <ismirno@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Add exp_mss_eff_config_thermal call to istep7 for AxoneMatt Derksen2019-09-122-292/+435
| | | | | | | | | | | | | | | | This adds the procedure call along with removing unneccesary calls based on system type. Change-Id: I869b25246f32472246bd4cd5bf31080db68a7e39 RTC:208847 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/82666 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Glenn Miles <milesg@ibm.com> Reviewed-by: Christian R Geddes <crgeddes@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Remove Forced Update of UCD DevicesMike Baiocchi2019-09-121-1/+1
| | | | | | | | | | | | | | | | | This commit changes the UCD_MFR_REVISION_OVERRIDE attribute back to zero such that it will not force an update on all UCD devices for each IPL. CQ:SW475690 Change-Id: Idc3c334114abedb0367e8ce8c5c03f5b05713e64 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83616 Reviewed-by: Ilya Smirnov <ismirno@us.ibm.com> Reviewed-by: Nicholas E Bofferding <bofferdn@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* PRD: Update NVDIMM warning threshold adjustmentCaleb Palmer2019-09-112-38/+145
| | | | | | | | | | | | | | | Change-Id: I6ea62e85eddba8eec04a47478462d3493db13cfb CQ: SW474559 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83434 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: Benjamen G Tyner <ben.tyner@ibm.com> Reviewed-by: Brian J Stegmiller <bjs@us.ibm.com> Reviewed-by: Paul Greenwood <paul.greenwood@ibm.com> Reviewed-by: Zane C Shelley <zshelle@us.ibm.com> Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83457 Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
* PRD: NVDIMM Additional FFDC for error analysisCaleb Palmer2019-09-113-1/+28
| | | | | | | | | | | | | | | Change-Id: I5e2a11132ee0b1a0092557061f0b4ed70e3c4928 CQ: SW473592 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/82762 Reviewed-by: Benjamen G Tyner <ben.tyner@ibm.com> Reviewed-by: Zane C Shelley <zshelle@us.ibm.com> Reviewed-by: Brian J Stegmiller <bjs@us.ibm.com> Reviewed-by: Paul Greenwood <paul.greenwood@ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* BPM Updates: Move NVDIMM controller reset and final fw check to end of updateMatthew Raybuck2019-09-111-75/+83
| | | | | | | | | | Change-Id: I54832f6197e620885b1506b47af248132173eba4 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83480 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Fix GCOV build errors for AXONE configurationZach Clark2019-09-113-25/+4
| | | | | | | | | | | | | | | | | | | | | | | | This commit fixes two problems that were preventing GCOV instrumentation from building: 1. There was an uninitialized variable in fapi2GetChildrenTest.H 2. The PNOR layout for AXONE had physical offsets for each partition specified manually, which was thwarting the automatic offset calculation required to be able to successfully adjust the partition layout when the size of HBI exceeds its initial allotment due to GCOV instrumentation There is another uninitialized-variable warning in the import tree which will be fixed by another commit. Change-Id: Ibcd5e9d62a93589836cb10697e9a963428571131 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83524 Reviewed-by: Nicholas E Bofferding <bofferdn@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Implement Static Analysis with cppcheckMegan2019-09-1115-9/+265
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Cppcheck static analysis tool can now be run when compiling by running: make cppcheck And it will always run when committing without stopping the commit if an error is found. This commit suppresses some false positives found in the code. A false positive can be suppressed inline by placing “// cppcheck-suppress syntaxError” in a line before the false positive., e.g.: char arr[5]; // cppcheck-suppress arrayIndexOutOfBounds arr[10] = 0; Change-Id: I9e833a153d6b04df2f8a72cd994e43922c61c2fe RTC: 201451 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/79629 Reviewed-by: Zachary Clark <zach@ibm.com> Reviewed-by: Nicholas E Bofferding <bofferdn@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Account for Explorer's DMB_REVISION format in its SPDChristian Geddes2019-09-114-204/+149
| | | | | | | | | | | | | | | | | | | | | | We have been told that the field we are reading to figure out the EC level of the OCMB via its SPD (offset 0x200) is going to say 0xA0 for the first version of the card, at IBM we would call this EC 0x10. The Explorer manufacture has stated that they will increment the 1st nibble when they do match card revisions, and the 2nd nibble on minor revisions. This commit adds the logic to convert the manufacture's revision format into IBM's EC level format. It also updates the prebuilt cache we use in simics for axone to have the expected 0xA0 value for the explorer SPD stored in the prebuilt cache Change-Id: I10e9523a8fbea847e3124c256fab7bee850cb29d RTC: 214627 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/82873 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Matt Derksen <mderkse1@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* PRD: Fix reading of NVDIMM ES_TEMP valueCaleb Palmer2019-09-111-2/+2
| | | | | | | | | | | | | | | Change-Id: I6734afee576b4f46c569d26ecf96fe287a85cf80 CQ: SW475263 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83418 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: Brian J Stegmiller <bjs@us.ibm.com> Reviewed-by: Benjamen G Tyner <ben.tyner@ibm.com> Reviewed-by: Paul Greenwood <paul.greenwood@ibm.com> Reviewed-by: Zane C Shelley <zshelle@us.ibm.com> Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83419 Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
* Zero out command argument field to fix exp_draminit issuesMark Pizzutillo2019-09-103-6/+14
| | | | | | | | | | | | | | Change-Id: If861521ad997d890c82429d8ab71b6b94ce78258 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83223 Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Dev-Ready: STEPHEN GLANCY <sglancy@us.ibm.com> Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com> Reviewed-by: Jennifer A Stofer <stofer@us.ibm.com> Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83227 Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Nicholas E Bofferding <bofferdn@us.ibm.com>
* Fix bug causing get_mmio index overflow for swiftMark Pizzutillo2019-09-102-6/+6
| | | | | | | | | | | | | | | | | Change-Id: Idbbc0186adda0575fccf0cc778d228ede0ea3394 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83359 Reviewed-by: Louis Stermole <stermole@us.ibm.com> Reviewed-by: Benjamin Gass <bgass@us.ibm.com> Reviewed-by: RYAN P KING <rpking@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com> Dev-Ready: Benjamin Gass <bgass@us.ibm.com> Reviewed-by: Jennifer A Stofer <stofer@us.ibm.com> Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83373 Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Nicholas E Bofferding <bofferdn@us.ibm.com>
OpenPOWER on IntegriCloud