summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorIlya Smirnov <ismirno@us.ibm.com>2019-09-13 13:31:15 -0500
committerDaniel M Crowell <dcrowell@us.ibm.com>2019-09-16 15:10:39 -0500
commitd2bcdefb26aecf8cd6d01577729ac45a66685a12 (patch)
treedfbfdf86e1121de206c26cc62865ae18cb1a7e02
parent69f3bd2539118f8a4659c12f8c5ae4336c9dced6 (diff)
downloadtalos-hostboot-d2bcdefb26aecf8cd6d01577729ac45a66685a12.tar.gz
talos-hostboot-d2bcdefb26aecf8cd6d01577729ac45a66685a12.zip
Add Printk Traces to ThreadPool Unit Tests
Some ThreadPool unit tests that test crashed tasks were missing printk logs to indicate the crashes were expected. This creates confusion when debugging printk logs. This commit adds the traces to indicate the crashes are expected and are part of the test. Change-Id: I38d2d886cfd73106e32fb4e461bba3d5a39a8032 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83783 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: Christian R Geddes <crgeddes@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Nicholas E Bofferding <bofferdn@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
-rw-r--r--src/usr/util/test/threadpool.H3
1 files changed, 3 insertions, 0 deletions
diff --git a/src/usr/util/test/threadpool.H b/src/usr/util/test/threadpool.H
index e8f41e9a3..7e474b2c3 100644
--- a/src/usr/util/test/threadpool.H
+++ b/src/usr/util/test/threadpool.H
@@ -31,6 +31,7 @@
#include <errl/errlmanager.H>
#include <util/util_reasoncodes.H>
#include <hbotcompid.H>
+#include <kernel/console.H>
// Thread pool constructor flags
#define DISABLE_CHILD_RC_CHECKING false
@@ -256,6 +257,7 @@ class ThreadPoolTest: public CxxTest::TestSuite
errlHndl_t l_errl = nullptr;
do {
+ printk("testChildRCCrashedTask: Expect to see uncaught exception\n");
l_threadPool.insert(new __ThreadPoolTest::CrashedTask());
l_threadPool.start();
l_errl = l_threadPool.shutdown();
@@ -300,6 +302,7 @@ class ThreadPoolTest: public CxxTest::TestSuite
l_threadPool(DISABLE_CHILD_RC_CHECKING);
errlHndl_t l_errl = nullptr;
+ printk("testChildNoRCCrashedTask: Expect to see uncaught exception\n");
l_threadPool.insert(new __ThreadPoolTest::CrashedTask());
l_threadPool.start();
l_errl = l_threadPool.shutdown();
OpenPOWER on IntegriCloud