| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On the Blackbird desk-side systems we expect users will be running
large fans very slowly. The current tachometer reading drops to
zero under those conditions, resulting in failed fan detection
systems kicking in.
Increase the tachometer read time to allow for slower fans to
return a valid speed. This does make read slower, but more
advance fan control software should be able to compensate via
e.g. PID loops.
Signed-off-by: Timothy Pearson <tpearson@raptorengineering.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Having a tachometer read return an -ETIMEDOUT error condition
instead of 0 RPM due to a disconnected or failed fan is highly
unexpected, and depending on higher level software can cause
application failures.
Return 0 RPM if tachometer cannot be read. This should trigger
the same error paths in any sane fan control implementation without
requiring special handling for the AST2x00 devices.
Signed-off-by: Timothy Pearson <tpearson@raptorengineering.com>
|
|
|
|
|
|
| |
This delays binding until GFX configuration and release from reset
Signed-off-by: Timothy Pearson <tpearson@raptorengineering.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On Blackbird hardware, ball T19 is set to FWSPICS2# even when
COND2 (SCU94[1:0] == 0x0) is not met. Since COND2 is listed
as a requirement for FWSPICS2#, the pinmux controller can choose
to set SCU88[25]=1 even when GPIOR1 is hogged. Due to the
documentation error, this results in ball T19 assigned to
FWSPICS2# instead of GPIOR1, leading to a failure of the Blackbird
platform.
Tested on Blackbird harwdare; GPIOR1 functions normally with
this patch and does not reliably function without it.
Signed-off-by: Timothy Pearson <tpearson@raptorengineering.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There appears to be a significant error in the pinmux table starting on
page 127 of the AST2500 datasheet v1.6. Specifically, the COND2 (DVO)
requirement is incorrectly applied to multiple digital video input (DVI)
muxed pins, and no DVI-specific condition is provided. This results in
the serial devices incorrectly overriding the DVO pinmuxes and disabling
the DVO pins.
Create a new condition code (COND6) for DVI enable, and update the most
seriously affected pins to use the new condition code.
Signed-off-by: Timothy Pearson <tpearson@raptorengineering.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There appears to be a small error in the pinmux table on pages 130 and
131 of the AST2500 datasheet v1.6. Specifically, the COND2 requirement
used to mux the surrounding pins to DVI was inadvertently replicated to
pins V1, W1, V2, and W2 in the table, which do not incorporate DVI
functionality.
As a result of this error, both serial TX lines and the PWM 0/1 outputs
were overriding the VPO pinmux settings when VPO was enabled in the
pinmux hogs.
This patch has been verified to function on Blackbird hardware. Both
serial TXD pins and PWM0/PWM1 were functionally tested with SCU94[1:0]
set to 0x1.
Signed-off-by: Timothy Pearson <tpearson@raptorengineering.com>
|
|
|
|
| |
Signed-off-by: Timothy Pearson <tpearson@raptorengineering.com>
|
|
|
|
|
|
|
|
| |
Systems using DVO output instead of VGA output will need to
control the DVO mux instead of the DAC mux. Expose the DVO
mux node to userspace.
Signed-off-by: Timothy Pearson <tpearson@raptorengineering.com>
|
|
|
|
|
|
|
|
| |
The AST2500 offers an alternate GFX output mode over DVO.
Enable DVO or VGA output mode conditionally based on two new
device tree properties, output-vga and output-dvo.
Signed-off-by: Timothy Pearson <tpearson@raptorengineering.com>
|
|
|
|
|
|
|
| |
GFX064 contains DVO enable and mode bits. These are hardware specific, configured
via the pinmux from the DT, and should not be cleared during startup.
Signed-off-by: Timothy Pearson <tpearson@raptorengineering.com>
|
| |
|
| |
|
|
|
|
|
|
|
| |
We have been receiving sporadic reports of BMC corruption and
failure to boot requiring external recovery. The main suspect
is the Flash write speed; reduce it by 1/2 to stabilize writes
from the BMC to its main Flash storage device.
|
| |
|
|
|
|
| |
Talos device tree
|
|
|
|
|
|
| |
access errors and taint when built as a module
Signed-off-by: Timothy Pearson <tpearson@raptorengineering.com>
|
| |
|
|
|
|
|
| |
Enable faster fan ramp up/down to avoid overshoot / fan speed oscillations
Disable unnecessary temperature sensor watchdog
|
|
|
|
| |
This allows the reset button service to bind to the GPIO
|
| |
|
|
|
|
| |
development The ASpeed device doesn't really support variable PWM frequencies, at least not enough for proper beep support
|
|
|
|
| |
ARM: dts: aspeed: talos: Add w83773g temp sensor
|
|
|
|
| |
ARM: dts: aspeed: talos: hog GPIOS7
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
Apply differences from hwmon review to bring the driver code to the same
point. There were some key differences regarding attribute placement
from the review, beyond the normal cleanup.
OpenBMC-Staging-Count: 1
Signed-off-by: Patrick Venture <venture@google.com>
[AJ: Rework subject]
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch makes it possible to pass custom struct attribute_group array
via the pmbus_driver_info struct so that those can be added to the
attribute groups passed to hwmon_device_register_with_groups().
This makes it possible to register custom sysfs attributes by PMBUS
drivers similar to how you can do this with most other busses/classes.
Signed-off-by: Krzysztof Adamski <krzysztof.adamski@nokia.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
optimization buffer"
This reverts commit cb8980080ccb7879c5a8ef0e3efa783c9288d907.
From Milton:
> NACK
>
> [The] justifcation is false. The routine reads the whole buffer
> because it calls the _rep routine and takes the size.
>
> In addition, the comment just before aspeed_smc_read_from_ahb
> tells why memcpy_fromio and memcpy_toio are broken on 32 bit
> arm, and this is still the case judging from the recent bug
> reportfrom a Nuvoton user [1].
>
> [1] https://github.com/openbmc/openbmc/issues/3521
OpenBMC-Staging-Count: 1
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
|
|
|
|
|
|
|
|
|
| |
s/intersil/isil/g per prefix in vendor prefixes file.
OpenBMC-Staging-Count: 1
Signed-off-by: Patrick Venture <venture@google.com>
[AJ: Rework subject]
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The occ driver supports two formats for the temp sensor value.
The OCC firmware for P8 supports only the first format, for which
no range checking or error processing is performed in the driver.
Inspecting the OCC sources for P8 reveals that OCC may send
a special value 0xFFFF to indicate that a sensor read timeout
has occurred, see
https://github.com/open-power/occ/blob/master_p8/src/occ/cmdh/cmdh_fsp_cmds.c#L395
That situation wasn't handled in the driver. This patch adds invalid
temp value check for the sensor data format 1 and handles it the same
way as it is done for the format 2, where EREMOTEIO is reported for
this case.
Signed-off-by: Alexander Soldatov <a.soldatov@yadro.com>
Signed-off-by: Alexander Amelkin <a.amelkin@yadro.com>
Reviewed-by: Alexander Amelkin <a.amelkin@yadro.com>
Cc: Edward A. James <eajames@us.ibm.com>
Cc: Joel Stanley <joel@jms.id.au>
Reviewed-by: Eddie James <eajames@linux.ibm.com>
|
|
|
|
|
|
|
|
|
|
| |
Add the nodes for the ir38064 and isl68137 devices on the Zaius board.
OpenBMC-Staging-Count: 1
Signed-off-by: Maxim Sloyko <maxims@google.com>
Signed-off-by: Robert Lippert <rlippert@google.com>
Signed-off-by: Patrick Venture <venture@google.com>
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
|
|
|
|
|
|
|
|
|
|
| |
Switch the default controller value to use the read mode in order to
customize the command and use SPINOR_OP_READ_4B (0x13) when the chip
supports 4B opcodes.
OpenBMC-Staging-Count: 1
Signed-off-by: Cédric Le Goater <clg@kaod.org>
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
|
|
|
|
|
|
|
|
|
|
| |
aspeed_smc_read_from_ahb() only reads the first word which is not what
we want. We want to capture a CALIBRATE_BUF_SIZE size window of the
flash contents to optimize the read.
OpenBMC-Staging-Count: 1
Signed-off-by: Cédric Le Goater <clg@kaod.org>
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
|
|
|
|
|
|
| |
OpenBMC-Staging-Count: 1
Signed-off-by: Cédric Le Goater <clg@kaod.org>
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
|
|
|
|
|
|
| |
OpenBMC-Staging-Count: 1
Signed-off-by: Cédric Le Goater <clg@kaod.org>
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
|
|
|
|
|
|
|
|
|
|
|
| |
The error sysfs attribute returns the stored error state of the OCC and
doesn't depend on the OCC poll response. Therefore, split the error
attribute into it's own function to avoid failing out of the function if
the poll response fails.
OpenBMC-Staging-Count: 1
Signed-off-by: Eddie James <eajames@linux.ibm.com>
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
|
|
|
|
|
|
|
|
|
|
|
| |
The OCC driver limits the rate of sending poll commands to the OCC. If a
user reads a hwmon entry after a poll response resulted in an error and
is rate-limited, the error is invisible to the user. Fix this by storing
the last error and returning that in the rate-limited case.
OpenBMC-Staging-Count: 1
Signed-off-by: Eddie James <eajames@linux.ibm.com>
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
|
|
|
|
|
|
|
|
|
|
| |
The occ's extended status is checked and shown as sysfs attributes. But
the code was incorrectly checking the "status" bits.
Fix it by checking the "ext_status" bits.
Signed-off-by: Lei YU <mine260309@gmail.com>
Reviewed-by: Eddie James <eajames@linux.ibm.com>
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In multi-master environment, this driver's master cannot know
exactly when a peer master sends data to this driver's slave so
cases can be happened that this master tries sending data through
the master_xfer function but slave data from a peer master is still
being processed or slave xfer is started by a peer immediately
after it queues a master command. To support multi-master use cases
properly, this H/W provides arbitration in physical level and it
provides priority based command handling too to avoid conflicts in
multi-master environment, means that if a master and a slave events
happen at the same time, H/W will handle a higher priority event
first and a pending event will be handled when bus comes back to
the idle state.
To support this H/W feature properly, this patch adds the 'pending'
state of master and its handling code so that the pending master
xfer can be continued after slave operation properly.
Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
Reviewed-by: Brendan Higgins <brendanhiggins@google.com>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
(cherry picked from commit 2e57b7cebb988a27cee44626ae91424e73823bfb)
Signed-off-by: Joel Stanley <joel@jms.id.au>
|
|
|
|
|
|
|
|
|
|
|
|
| |
This commit removes hard-coded bus timeout value setting so that
it can be set by i2c-core-base.
Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
Reviewed-by: Joel Stanley <joel@jms.id.au>
Reviewed-by: Brendan Higgins <brendanhiggins@google.com>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
(cherry picked from commit 44783efdfed190088066d4c3470766c28da38a21)
Signed-off-by: Joel Stanley <joel@jms.id.au>
|
|
|
|
|
|
|
|
|
| |
Add the pmbus driver for the Infineon ir38064 voltage regulator.
OpenBMC-Staging-Count: 1
Signed-off-by: Maxim Sloyko <maxims@google.com>
Signed-off-by: Patrick Vtenture <venture@google.com>
Signed-off-by: Joel Stanley <joel@jms.id.au>
|
|
|
|
|
|
| |
OpenBMC-Staging-Count: 1
Signed-off-by: Tomer Maimon <tmaimon77@gmail.com>
Signed-off-by: Joel Stanley <joel@jms.id.au>
|
|
|
|
|
|
| |
OpenBMC-Staging-Count: 1
Signed-off-by: Tomer Maimon <tmaimon77@gmail.com>
Signed-off-by: Joel Stanley <joel@jms.id.au>
|
|
|
|
|
|
|
|
|
| |
Add support for the Nuvoton NPCM BMC hardware to the Platform
Environment Control Interface (PECI) subsystem.
OpenBMC-Staging-Count: 1
Signed-off-by: Tomer Maimon <tmaimon77@gmail.com>
Signed-off-by: Joel Stanley <joel@jms.id.au>
|