diff options
author | Thomas Lively <tlively@google.com> | 2018-10-03 23:02:23 +0000 |
---|---|---|
committer | Thomas Lively <tlively@google.com> | 2018-10-03 23:02:23 +0000 |
commit | 5d461c96bdbcc82f4fd6eeef88633f6f6c06c650 (patch) | |
tree | c9e2fba348fdbb96afb75afcc71414cf35d64e8e /llvm/lib/Target | |
parent | f7868ec25bc54a7b07f7498f44320f71242d1fb3 (diff) | |
download | bcm5719-llvm-5d461c96bdbcc82f4fd6eeef88633f6f6c06c650.tar.gz bcm5719-llvm-5d461c96bdbcc82f4fd6eeef88633f6f6c06c650.zip |
[WebAssembly] Bitselect intrinsic and instruction
Summary: Depends on D52755.
Reviewers: aheejin, dschuff
Subscribers: sbc100, jgravelle-google, sunfish, llvm-commits
Differential Revision: https://reviews.llvm.org/D52805
llvm-svn: 343739
Diffstat (limited to 'llvm/lib/Target')
-rw-r--r-- | llvm/lib/Target/WebAssembly/WebAssemblyISD.def | 1 | ||||
-rw-r--r-- | llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp | 6 | ||||
-rw-r--r-- | llvm/lib/Target/WebAssembly/WebAssemblyInstrSIMD.td | 24 |
3 files changed, 31 insertions, 0 deletions
diff --git a/llvm/lib/Target/WebAssembly/WebAssemblyISD.def b/llvm/lib/Target/WebAssembly/WebAssemblyISD.def index 590f8dab759..9e1d198b079 100644 --- a/llvm/lib/Target/WebAssembly/WebAssemblyISD.def +++ b/llvm/lib/Target/WebAssembly/WebAssemblyISD.def @@ -24,5 +24,6 @@ HANDLE_NODETYPE(BR_TABLE) HANDLE_NODETYPE(SHUFFLE) HANDLE_NODETYPE(ANYTRUE) HANDLE_NODETYPE(ALLTRUE) +HANDLE_NODETYPE(BITSELECT) // add memory opcodes starting at ISD::FIRST_TARGET_MEMORY_OPCODE here... diff --git a/llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp b/llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp index a8992d89ca3..d5dcbf1d699 100644 --- a/llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp +++ b/llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp @@ -965,6 +965,11 @@ WebAssemblyTargetLowering::LowerINTRINSIC_WO_CHAIN(SDValue Op, switch (IntNo) { default: return {}; // Don't custom lower most intrinsics. + + case Intrinsic::wasm_bitselect: + return DAG.getNode(WebAssemblyISD::BITSELECT, DL, Op.getValueType(), + Op.getOperand(1), Op.getOperand(2), Op.getOperand(3)); + case Intrinsic::wasm_anytrue: case Intrinsic::wasm_alltrue: { unsigned OpCode = IntNo == Intrinsic::wasm_anytrue @@ -972,6 +977,7 @@ WebAssemblyTargetLowering::LowerINTRINSIC_WO_CHAIN(SDValue Op, : WebAssemblyISD::ALLTRUE; return DAG.getNode(OpCode, DL, Op.getValueType(), Op.getOperand(1)); } + case Intrinsic::wasm_lsda: // TODO For now, just return 0 not to crash return DAG.getConstant(0, DL, Op.getValueType()); diff --git a/llvm/lib/Target/WebAssembly/WebAssemblyInstrSIMD.td b/llvm/lib/Target/WebAssembly/WebAssemblyInstrSIMD.td index 991a5a5773a..bf5582a11f0 100644 --- a/llvm/lib/Target/WebAssembly/WebAssemblyInstrSIMD.td +++ b/llvm/lib/Target/WebAssembly/WebAssemblyInstrSIMD.td @@ -20,8 +20,12 @@ def LaneIdx#SIZE : ImmLeaf<i32, "return 0 <= Imm && Imm < "#SIZE#";">; // Custom nodes for custom operations def wasm_shuffle_t : SDTypeProfile<1, 18, []>; +def wasm_bitselect_t : SDTypeProfile<1, 3, + [SDTCisVec<0>, SDTCisSameAs<0, 1>, SDTCisSameAs<0, 2>, SDTCisSameAs<0, 3>] +>; def wasm_reduce_t : SDTypeProfile<1, 1, [SDTCisVT<0, i32>, SDTCisVec<1>]>; def wasm_shuffle : SDNode<"WebAssemblyISD::SHUFFLE", wasm_shuffle_t>; +def wasm_bitselect : SDNode<"WebAssemblyISD::BITSELECT", wasm_bitselect_t>; def wasm_anytrue : SDNode<"WebAssemblyISD::ANYTRUE", wasm_reduce_t>; def wasm_alltrue : SDNode<"WebAssemblyISD::ALLTRUE", wasm_reduce_t>; @@ -193,6 +197,16 @@ multiclass SIMDNot<ValueType vec_t, PatFrag splat_pat, ValueType lane_t> { )], "v128.not\t$dst, $vec", "v128.not", 63>; } +multiclass Bitselect<ValueType vec_t> { + defm BITSELECT_#vec_t : + SIMD_I<(outs V128:$dst), (ins V128:$v1, V128:$v2, V128:$c), (outs), (ins), + [(set (vec_t V128:$dst), + (vec_t (wasm_bitselect + (vec_t V128:$c), (vec_t V128:$v1), (vec_t V128:$v2) + )) + )], + "v128.bitselect\t$dst, $v1, $v2, $c", "v128.bitselect", 64>; +} multiclass SIMDReduceVec<ValueType vec_t, string vec, string name, SDNode op, bits<32> simdop> { defm _#vec_t : SIMD_I<(outs I32:$dst), (ins V128:$vec), (outs), (ins), @@ -380,6 +394,9 @@ defm "" : SIMDNot<v8i16, splat8, i32>; defm "" : SIMDNot<v4i32, splat4, i32>; defm "" : SIMDNot<v2i64, splat2, i64>; +foreach vec_t = [v16i8, v8i16, v4i32, v2i64, v4f32, v2f64] in +defm "" : Bitselect<vec_t>; + defm ANYTRUE : SIMDReduce<"any_true", wasm_anytrue, 65>; defm ALLTRUE : SIMDReduce<"all_true", wasm_alltrue, 69>; @@ -443,6 +460,13 @@ def : StorePatExternSymOffOnly<vec_t, store, !cast<NI>("STORE_"#vec_t)>; } +// Bitselect is equivalent to (c & v1) | (~c & v2) +foreach vec_t = [v16i8, v8i16, v4i32, v2i64] in + def : Pat<(vec_t (or (and (vec_t V128:$c), (vec_t V128:$v1)), + (and (vnot V128:$c), (vec_t V128:$v2)))), + (!cast<Instruction>("BITSELECT_"#vec_t) + V128:$v1, V128:$v2, V128:$c)>; + // Lower float comparisons that don't care about NaN to standard // WebAssembly float comparisons. These instructions are generated in // the target-independent expansion of unordered comparisons and |