diff options
| author | Kamalesh Babulal <kamalesh@linux.vnet.ibm.com> | 2015-07-10 20:55:48 +0530 |
|---|---|---|
| committer | Stewart Smith <stewart@linux.vnet.ibm.com> | 2016-06-09 17:28:07 +1000 |
| commit | bc033c05c29654ea34db84fc945525e786e68089 (patch) | |
| tree | cf5756690c52e595fa1a6fe5110ed32a27cd8265 /hw/p7ioc-phb.c | |
| parent | 348dacfaca9f139db2603f5c2e78d87e21938ca6 (diff) | |
| download | talos-skiboot-bc033c05c29654ea34db84fc945525e786e68089.tar.gz talos-skiboot-bc033c05c29654ea34db84fc945525e786e68089.zip | |
p7ioc-phb: Remove logically deadcode
We exit p7ioc_phb_mmio_enable(), with OPAL_PARAMETER. When enable is
>= OPAL_ENABLE_M64_NON_SPLIT. So remove the logically dead code, which
handles this condition.
Fixes Coverity defect#97826.
Signed-off-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
[stewart@linux.vnet.ibm.com: fix build error]
Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
Diffstat (limited to 'hw/p7ioc-phb.c')
| -rw-r--r-- | hw/p7ioc-phb.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/hw/p7ioc-phb.c b/hw/p7ioc-phb.c index bad7d0a6..a2984d09 100644 --- a/hw/p7ioc-phb.c +++ b/hw/p7ioc-phb.c @@ -1692,8 +1692,7 @@ static int64_t p7ioc_phb_mmio_enable(struct phb *phb, data64 |= IODA_M64BT_ENABLE; } else if (enable == OPAL_DISABLE_M64) { data64 &= ~IODA_M64BT_ENABLE; - } else - return OPAL_PARAMETER; + } p7ioc_phb_ioda_sel(p, IODA_TBL_M64BT, window_num, false); out_be64(p->regs + PHB_IODA_DATA0, data64); |
