diff options
| author | Ananth N Mavinakayanahalli <ananth@in.ibm.com> | 2015-06-17 14:03:20 +0530 |
|---|---|---|
| committer | Stewart Smith <stewart@linux.vnet.ibm.com> | 2015-06-19 07:37:36 +1000 |
| commit | 31ab1933d7fbb37e9bee7ea69b76419fa3b2ac8d (patch) | |
| tree | d0e4e7de6fda0db5457ce10c8a2b483c5f4dd6bd /hw/fsp/fsp-leds.c | |
| parent | c6d008d94be3831071621d29f9b5c4570897a272 (diff) | |
| download | talos-skiboot-31ab1933d7fbb37e9bee7ea69b76419fa3b2ac8d.tar.gz talos-skiboot-31ab1933d7fbb37e9bee7ea69b76419fa3b2ac8d.zip | |
Use destination buffer size as bound for strncpy
... instead of potentially unbounded src buffer size
Signed-off-by: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
Reviewed-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com>
Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
Diffstat (limited to 'hw/fsp/fsp-leds.c')
| -rw-r--r-- | hw/fsp/fsp-leds.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/hw/fsp/fsp-leds.c b/hw/fsp/fsp-leds.c index eef932c5..82be37a6 100644 --- a/hw/fsp/fsp-leds.c +++ b/hw/fsp/fsp-leds.c @@ -683,7 +683,7 @@ static int queue_led_state_change(char *loc_code, u8 command, } /* Save the request */ - strncpy(cmd->loc_code, loc_code, strlen(loc_code)); + strncpy(cmd->loc_code, loc_code, LOC_CODE_SIZE); cmd->command = command; cmd->state = state; cmd->cmd_src = cmd_src; |
