diff options
| author | Cyril Bur <cyril.bur@au1.ibm.com> | 2015-07-29 15:25:53 +1000 |
|---|---|---|
| committer | Stewart Smith <stewart@linux.vnet.ibm.com> | 2015-07-31 15:32:44 +1000 |
| commit | 3591fd399c7d76b54ac25075b7617fe9b7de3507 (patch) | |
| tree | cc003a59e32c18308afa1736f6ebb6e343640c82 /external/pflash | |
| parent | 869228384267a2a4f23e563879e2a1f4b16f376e (diff) | |
| download | talos-skiboot-3591fd399c7d76b54ac25075b7617fe9b7de3507.tar.gz talos-skiboot-3591fd399c7d76b54ac25075b7617fe9b7de3507.zip | |
versioning: Unify all versioning to match skiboot versions
Previously there has been some uncertainty as to how separate binaries were
to be versioned compared to the firmware version as they could change (or
not change) out of sync with skiboot versioning. Historically pflash was
born with its own version which didn't help the issue.
It has been decided that make_version.sh should always return one version
which is shall be the skiboot firmware version, external binaries can
supply their own prefix which will be s/skiboot/$prefix/ but the default
behaviour is the git tag versioning.
The main reason for versioning here is so developers can identify which
version of the code someone is running, versions which closly match the
source tree are easiest to deal with. The idea with one version and
every binary getting a bump regardless of changes is that there is a lot of
shared code (libflash/libffs are a prime example) and even if an external
binary isn't explicitly updated it is possible that changes to shared code
may be missed.
This patch simplifies make_version.sh which had been updated to deal with
pflash- git tags.
Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
Diffstat (limited to 'external/pflash')
| -rw-r--r-- | external/pflash/rules.mk | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/external/pflash/rules.mk b/external/pflash/rules.mk index 06b9e33e..d89748b5 100644 --- a/external/pflash/rules.mk +++ b/external/pflash/rules.mk @@ -25,7 +25,7 @@ PFLASH_VERSION ?= $(shell ./make_version.sh $(EXE)) version.c: make_version.sh .version @(if [ "a$(PFLASH_VERSION)" = "a" ]; then \ - echo "#error You need to set SKIBOOT_VERSION environment variable" > $@ ;\ + echo "#error You need to set PFLASH_VERSION environment variable" > $@ ;\ else \ echo "const char version[] = \"$(PFLASH_VERSION)\";" ;\ fi) > $@ |
