summaryrefslogtreecommitdiffstats
path: root/external/common
diff options
context:
space:
mode:
authorStewart Smith <stewart@linux.vnet.ibm.com>2017-07-17 17:23:39 +1000
committerStewart Smith <stewart@linux.vnet.ibm.com>2017-07-19 15:49:39 +1000
commit9880e148c2ea2d7a6f24a025799e59ac1a18cf92 (patch)
tree778607574858ae293edd002264caa1c139dc5eb8 /external/common
parentf2c87a3d2f6df0886124636239d9950ef0abcab0 (diff)
downloadtalos-skiboot-9880e148c2ea2d7a6f24a025799e59ac1a18cf92.tar.gz
talos-skiboot-9880e148c2ea2d7a6f24a025799e59ac1a18cf92.zip
pflash: build with skiboot HOSTCFLAGS warnings
mostly missing prototypes and unused parameters. Reviewed-by: Cyril Bur <cyril.bur@au1.ibm.com> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
Diffstat (limited to 'external/common')
-rw-r--r--external/common/arch_flash_common.c12
-rw-r--r--external/common/arch_flash_x86.c1
2 files changed, 10 insertions, 3 deletions
diff --git a/external/common/arch_flash_common.c b/external/common/arch_flash_common.c
index 5b7f9ea0..6bce7e1b 100644
--- a/external/common/arch_flash_common.c
+++ b/external/common/arch_flash_common.c
@@ -40,17 +40,23 @@ int __attribute__((weak)) arch_flash_erase_chip(struct blocklevel_device *bl)
return blocklevel_erase(bl, 0, total_size);
}
-int __attribute__((weak)) arch_flash_4b_mode(struct blocklevel_device *bl, int set_4b)
+int __attribute__((weak,const)) arch_flash_4b_mode(struct blocklevel_device *bl, int set_4b)
{
+ (void)bl;
+ (void)set_4b;
return -1;
}
-enum flash_access __attribute__((weak)) arch_flash_access(struct blocklevel_device *bl, enum flash_access access)
+enum flash_access __attribute__((weak,const)) arch_flash_access(struct blocklevel_device *bl, enum flash_access access)
{
+ (void)bl;
+ (void)access;
return ACCESS_INVAL;
}
-int __attribute__((weak)) arch_flash_set_wrprotect(struct blocklevel_device *bl, int set)
+int __attribute__((weak,const)) arch_flash_set_wrprotect(struct blocklevel_device *bl, int set)
{
+ (void)bl;
+ (void)set;
return -1;
}
diff --git a/external/common/arch_flash_x86.c b/external/common/arch_flash_x86.c
index 0146243d..3638d736 100644
--- a/external/common/arch_flash_x86.c
+++ b/external/common/arch_flash_x86.c
@@ -49,5 +49,6 @@ int arch_flash_init(struct blocklevel_device **r_bl, const char *file, bool keep
void arch_flash_close(struct blocklevel_device *bl, const char *file)
{
+ (void)file;
file_exit_close(bl);
}
OpenPOWER on IntegriCloud