summaryrefslogtreecommitdiffstats
path: root/core
diff options
context:
space:
mode:
authorStewart Smith <stewart@linux.ibm.com>2018-11-29 15:28:27 +1100
committerStewart Smith <stewart@linux.ibm.com>2018-12-10 22:21:12 -0600
commit88bf48a2a5def0bb40c999dd098500f8cfc6a2b3 (patch)
treea88f9fc68e91c4cdd1524acf27298698e1bda5d3 /core
parent5ebb15d265bdd95ce2f151d05ee7ed84caefa647 (diff)
downloadtalos-skiboot-88bf48a2a5def0bb40c999dd098500f8cfc6a2b3.tar.gz
talos-skiboot-88bf48a2a5def0bb40c999dd098500f8cfc6a2b3.zip
Change ifdef around dump_fdt() to shut up static analysis
This is a dumb warning from a certain static analysis tool that a function has no effect when the ifdef that would make it have an effect isn't defined and we replace it with a no-op impl. Putting the #ifdef around the call just so I don't have to discount this damn static analysis false positive every time I go and look at the results. Signed-off-by: Stewart Smith <stewart@linux.ibm.com>
Diffstat (limited to 'core')
-rw-r--r--core/fdt.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/core/fdt.c b/core/fdt.c
index 8fb9ad72..ce4f6638 100644
--- a/core/fdt.c
+++ b/core/fdt.c
@@ -108,8 +108,6 @@ static void dump_fdt(void *fdt)
prlog(PR_INFO, "name: %s [%u]\n", name, off);
}
}
-#else
-static inline void dump_fdt(void *fdt __unused) { }
#endif
static void flatten_dt_properties(void *fdt, const struct dt_node *dn)
@@ -183,7 +181,9 @@ static int __create_dtb(void *fdt, size_t len,
return fdt_error;
}
+#ifdef DEBUG_FDT
dump_fdt(fdt);
+#endif
return 0;
}
OpenPOWER on IntegriCloud