diff options
| author | ppaidipe@linux.vnet.ibm.com <ppaidipe@linux.vnet.ibm.com> | 2016-11-22 10:08:48 +0530 |
|---|---|---|
| committer | Stewart Smith <stewart@linux.vnet.ibm.com> | 2016-12-21 16:54:26 +1100 |
| commit | 77be3339fba1ea188b19bde5c4199b63c9024a30 (patch) | |
| tree | f916f72d11eadf3829bb9de4584bc64fae9c7e2b | |
| parent | 7d6e73810dec029678a0d14a3f47485d4025520e (diff) | |
| download | talos-skiboot-77be3339fba1ea188b19bde5c4199b63c9024a30.tar.gz talos-skiboot-77be3339fba1ea188b19bde5c4199b63c9024a30.zip | |
Add fwts annotation for duplicate DT node entries.
Reference bug: https://github.com/open-power/op-build/issues/751
Signed-off-by: Pridhiviraj Paidipeddi <ppaidipe@linux.vnet.ibm.com>
[stewart@linux.vnet.ibm.com: tweak message slightly]
Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
| -rw-r--r-- | core/device.c | 20 |
1 files changed, 19 insertions, 1 deletions
diff --git a/core/device.c b/core/device.c index 63b5df80..d0731b14 100644 --- a/core/device.c +++ b/core/device.c @@ -799,7 +799,25 @@ int dt_expand_node(struct dt_node *node, const void *fdt, int fdt_node) * going for now, we may ultimately want to * assert */ - (void)dt_attach_root(node, child); + if (!dt_attach_root(node, child)) + /** + * @fwts-label DTHasDuplicateNodeID + * @fwts-advice OPAL will parse the Flattened + * Device Tree(FDT), which can be generated + * from different firmware sources. During + * expansion of FDT, OPAL observed a node + * assigned multiple times (a duplicate). This + * indicates either a Hostboot bug *OR*, more + * likely, a bug in the platform XML. Check + * the platform XML for duplicate IDs for + * this type of device. Because of this + * duplicate node, OPAL won't add the hardware + * device found with a duplicate node ID into + * DT, rendering the corresponding device not + * functional. + */ + prlog(PR_ERR, "DT: Found duplicate node: %s\n", + child->name); break; case FDT_END: return -1; |
