diff options
| author | Claus Michael Olsen <cmolsen@us.ibm.com> | 2017-04-05 05:16:51 -0500 |
|---|---|---|
| committer | Sachin Gupta <sgupta2m@in.ibm.com> | 2017-12-04 22:37:05 -0500 |
| commit | 871d02a4e2c66e7c0501812abd86a27009cc73e0 (patch) | |
| tree | 65c6e1a17eb77bcf2ae63fc6bd0655327d9e1865 /src/import/tools | |
| parent | d77e05e938c7a6fdf71cdd00a8a88fe794d0cf37 (diff) | |
| download | talos-sbe-871d02a4e2c66e7c0501812abd86a27009cc73e0.tar.gz talos-sbe-871d02a4e2c66e7c0501812abd86a27009cc73e0.zip | |
Code restruct: TOR API
Key_Cronus_Test=XIP_REGRESS
Code restructuring aiming at:
- utilizing TOR magic header info
- enforce a common approach for
- extracting metadata for all image,chipType combinations
- traversing images for all image,chipType combinations
- shrinking code size by reusing common code segments
- improve readability by
- separating more clearly metadata extraction and image traversal
- slight rearrange of certain code segments
- remove leftover hardcoded assumptions about ring/TOR data and structs
- variables appropriately renamed and now all using camel style
Change-Id: I50ace8b2fdb340a97ce6d74ce545c5e1acd21c40
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/38863
Tested-by: HWSV CI <hwsv-ci+hostboot@us.ibm.com>
Tested-by: PPE CI <ppe-ci+hostboot@us.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Cronus HW CI <cronushw-ci+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com>
Reviewed-by: GIRISANKAR PAULRAJ <gpaulraj@in.ibm.com>
Reviewed-by: Thi N. Tran <thi@us.ibm.com>
Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com>
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/43250
Reviewed-by: Hostboot Team <hostboot@us.ibm.com>
Reviewed-by: Sachin Gupta <sgupta2m@in.ibm.com>
Diffstat (limited to 'src/import/tools')
| -rw-r--r-- | src/import/tools/imageProcs/p9_ipl_build.C | 10 |
1 files changed, 2 insertions, 8 deletions
diff --git a/src/import/tools/imageProcs/p9_ipl_build.C b/src/import/tools/imageProcs/p9_ipl_build.C index 142a4303..48d277a1 100644 --- a/src/import/tools/imageProcs/p9_ipl_build.C +++ b/src/import/tools/imageProcs/p9_ipl_build.C @@ -74,8 +74,6 @@ int get_dd_level_rings_from_hw_image( char* i_hwImage, P9XipSection l_ringsSection; *o_ringBlock = NULL; o_blockSize = 0; - RingType_t l_ringType = ALLRING; - uint8_t unused_parm = 0; // Get the block of rings from the HW image rc = p9_xip_get_section(i_hwImage, P9_XIP_SECTION_HW_RINGS, &l_ringsSection); @@ -105,9 +103,7 @@ int get_dd_level_rings_from_hw_image( char* i_hwImage, rc = tor_get_block_of_rings( ringsSection, i_ddLevel, PT_SBE, - l_ringType, - BASE, - unused_parm, + NOT_VALID, o_ringBlock, o_blockSize ); @@ -133,9 +129,7 @@ int get_dd_level_rings_from_hw_image( char* i_hwImage, rc = tor_get_block_of_rings( ringsSection, i_ddLevel, PT_SBE, - l_ringType, - BASE, - unused_parm, + NOT_VALID, o_ringBlock, o_blockSize ); |
