From 871d02a4e2c66e7c0501812abd86a27009cc73e0 Mon Sep 17 00:00:00 2001 From: Claus Michael Olsen Date: Wed, 5 Apr 2017 05:16:51 -0500 Subject: Code restruct: TOR API Key_Cronus_Test=XIP_REGRESS Code restructuring aiming at: - utilizing TOR magic header info - enforce a common approach for - extracting metadata for all image,chipType combinations - traversing images for all image,chipType combinations - shrinking code size by reusing common code segments - improve readability by - separating more clearly metadata extraction and image traversal - slight rearrange of certain code segments - remove leftover hardcoded assumptions about ring/TOR data and structs - variables appropriately renamed and now all using camel style Change-Id: I50ace8b2fdb340a97ce6d74ce545c5e1acd21c40 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/38863 Tested-by: HWSV CI Tested-by: PPE CI Tested-by: Jenkins Server Tested-by: Cronus HW CI Tested-by: FSP CI Jenkins Tested-by: Hostboot CI Reviewed-by: GIRISANKAR PAULRAJ Reviewed-by: Thi N. Tran Reviewed-by: Jennifer A. Stofer Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/43250 Reviewed-by: Hostboot Team Reviewed-by: Sachin Gupta --- src/import/tools/imageProcs/p9_ipl_build.C | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) (limited to 'src/import/tools') diff --git a/src/import/tools/imageProcs/p9_ipl_build.C b/src/import/tools/imageProcs/p9_ipl_build.C index 142a4303..48d277a1 100644 --- a/src/import/tools/imageProcs/p9_ipl_build.C +++ b/src/import/tools/imageProcs/p9_ipl_build.C @@ -74,8 +74,6 @@ int get_dd_level_rings_from_hw_image( char* i_hwImage, P9XipSection l_ringsSection; *o_ringBlock = NULL; o_blockSize = 0; - RingType_t l_ringType = ALLRING; - uint8_t unused_parm = 0; // Get the block of rings from the HW image rc = p9_xip_get_section(i_hwImage, P9_XIP_SECTION_HW_RINGS, &l_ringsSection); @@ -105,9 +103,7 @@ int get_dd_level_rings_from_hw_image( char* i_hwImage, rc = tor_get_block_of_rings( ringsSection, i_ddLevel, PT_SBE, - l_ringType, - BASE, - unused_parm, + NOT_VALID, o_ringBlock, o_blockSize ); @@ -133,9 +129,7 @@ int get_dd_level_rings_from_hw_image( char* i_hwImage, rc = tor_get_block_of_rings( ringsSection, i_ddLevel, PT_SBE, - l_ringType, - BASE, - unused_parm, + NOT_VALID, o_ringBlock, o_blockSize ); -- cgit v1.2.1