diff options
| author | Saeed Bishara <saeed@marvell.com> | 2008-02-18 07:42:28 -1100 |
|---|---|---|
| committer | Jeff Garzik <jeff@garzik.org> | 2008-02-20 12:20:46 -0500 |
| commit | f1cb0ea12fee23018ad1865bf789cbd463f13747 (patch) | |
| tree | 0809e8fd543ecf8bbc3eaa285139d3a8180cb786 | |
| parent | 5d44b414daa8c1d8551aed6130d86d54175db43f (diff) | |
| download | talos-obmc-linux-f1cb0ea12fee23018ad1865bf789cbd463f13747.tar.gz talos-obmc-linux-f1cb0ea12fee23018ad1865bf789cbd463f13747.zip | |
sata_mv: remove iounmap in mv_platform_remove and use devm_iomap
this will fix crash bug when doing rmmod to the driver, this is because the
port_stop function get called later and it could access the device's registers.
Signed-off-by: Saeed Bishara <saeed@marvell.com>
Acked-by: Mark Lord <mlord@pobox.com>
Acked-by: Tejun Heo <htejun@gmail.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
| -rw-r--r-- | drivers/ata/sata_mv.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/drivers/ata/sata_mv.c b/drivers/ata/sata_mv.c index eb97dde28d47..6ebebde8454a 100644 --- a/drivers/ata/sata_mv.c +++ b/drivers/ata/sata_mv.c @@ -2947,7 +2947,8 @@ static int mv_platform_probe(struct platform_device *pdev) hpriv->n_ports = n_ports; host->iomap = NULL; - hpriv->base = ioremap(res->start, res->end - res->start + 1); + hpriv->base = devm_ioremap(&pdev->dev, res->start, + res->end - res->start + 1); hpriv->base -= MV_SATAHC0_REG_BASE; rc = mv_create_dma_pools(hpriv, &pdev->dev); @@ -2979,11 +2980,8 @@ static int __devexit mv_platform_remove(struct platform_device *pdev) { struct device *dev = &pdev->dev; struct ata_host *host = dev_get_drvdata(dev); - struct mv_host_priv *hpriv = host->private_data; - void __iomem *base = hpriv->base; ata_host_detach(host); - iounmap(base); return 0; } |
