diff options
| author | Kirtika Ruchandani <kirtika@chromium.org> | 2016-11-24 17:12:00 -0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2016-11-29 20:58:31 +0100 |
| commit | e22defeb9810d98dfffe9d84e036559af1742d96 (patch) | |
| tree | 259d8a80c373e8cf2ba18189e8c337a013e59e91 | |
| parent | 2027cbcf497579cb3bd71ed4173ae9b950aa09a3 (diff) | |
| download | talos-obmc-linux-e22defeb9810d98dfffe9d84e036559af1742d96.tar.gz talos-obmc-linux-e22defeb9810d98dfffe9d84e036559af1742d96.zip | |
drivers/base/memory.c: Remove unused 'first_page' variable
Commit 71fbd556adde ("memory-hotplug: remove redundant call of page_to_pfn")
introduced an optimization that rendered 'struct page* first_page'
useless in memory_block_action(). Compiling with W=1 gives the
following warning, fix it.
drivers/base/memory.c: In function ‘memory_block_action’:
drivers/base/memory.c:229:15: warning: variable ‘first_page’ set but not used [-Wunused-but-set-variable]
struct page *first_page;
^
This is a harmeless warning and is only being fixed to reduce the
noise with W=1 in the kernel. The call to pfn_to_page() has no side
effects and is safe to remove.
Fixes: 71fbd556adde ("memory-hotplug: remove redundant call of page_to_pfn")
Cc: Zhang Zhen <zhenzhang.zhang@huawei.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Kirtika Ruchandani <kirtika@chromium.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/base/memory.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/base/memory.c b/drivers/base/memory.c index 62c63c0c5c22..bb69e58c29f3 100644 --- a/drivers/base/memory.c +++ b/drivers/base/memory.c @@ -226,11 +226,9 @@ memory_block_action(unsigned long phys_index, unsigned long action, int online_t { unsigned long start_pfn; unsigned long nr_pages = PAGES_PER_SECTION * sections_per_block; - struct page *first_page; int ret; start_pfn = section_nr_to_pfn(phys_index); - first_page = pfn_to_page(start_pfn); switch (action) { case MEM_ONLINE: |
