diff options
| author | Chen Gang <gang.chen@asianux.com> | 2013-05-30 16:21:36 +0800 |
|---|---|---|
| committer | Geert Uytterhoeven <geert@linux-m68k.org> | 2013-06-24 19:44:19 +0200 |
| commit | ddc2fc2c5bf459d49c241123112741b99198f473 (patch) | |
| tree | 375dcfcbb6fe72762ca0849969cb580fdb20f049 | |
| parent | 220921a0d1d2ab91ad719c06a09d86f0e8852bfa (diff) | |
| download | talos-obmc-linux-ddc2fc2c5bf459d49c241123112741b99198f473.tar.gz talos-obmc-linux-ddc2fc2c5bf459d49c241123112741b99198f473.zip | |
m68k/math-emu: unsigned issue, 'unsigned long' will never be less than zero
'oldmant.m32[1]' is 'unsigned long' which can never be '< 0', and the
original author wanted to check whether the highest bit is set.
So make the bit test explicit (which is better than casting from 'unsigned
long' to 'long').
The related warning: (with EXTRA_CFLAGS=-W ARCH=m68k for allmodconfig)
arch/m68k/math-emu/fp_arith.c:522:4: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
Signed-off-by: Chen Gang <gang.chen@asianux.com>
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
| -rw-r--r-- | arch/m68k/math-emu/fp_arith.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/m68k/math-emu/fp_arith.c b/arch/m68k/math-emu/fp_arith.c index 08f286db3c5a..239eb1990184 100644 --- a/arch/m68k/math-emu/fp_arith.c +++ b/arch/m68k/math-emu/fp_arith.c @@ -519,7 +519,7 @@ static void fp_roundint(struct fp_ext *dest, int mode) return; break; case 0x401e: - if (!(oldmant.m32[1] >= 0)) + if (oldmant.m32[1] & 0x80000000) return; if (oldmant.m32[0] & 1) break; |
