diff options
| author | Gustavo A. R. Silva <gustavo@embeddedor.com> | 2019-02-11 12:43:23 -0600 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2019-03-13 14:01:30 -0700 |
| commit | d4f05a4aaf98d14c15ffa867459cdc78e899d590 (patch) | |
| tree | 57e97477a827fd284d2f092c65778a4719cb7fb9 | |
| parent | 61f7963e347db8699dc8aee94bd165d30e5f780c (diff) | |
| download | talos-obmc-linux-d4f05a4aaf98d14c15ffa867459cdc78e899d590.tar.gz talos-obmc-linux-d4f05a4aaf98d14c15ffa867459cdc78e899d590.zip | |
iscsi_ibft: Fix missing break in switch statement
commit df997abeebadaa4824271009e2d2b526a70a11cb upstream.
Add missing break statement in order to prevent the code from falling
through to case ISCSI_BOOT_TGT_NAME, which is unnecessary.
This bug was found thanks to the ongoing efforts to enable
-Wimplicit-fallthrough.
Fixes: b33a84a38477 ("ibft: convert iscsi_ibft module to iscsi boot lib")
Cc: stable@vger.kernel.org
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/firmware/iscsi_ibft.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/firmware/iscsi_ibft.c b/drivers/firmware/iscsi_ibft.c index 6bc8e6640d71..c51462f5aa1e 100644 --- a/drivers/firmware/iscsi_ibft.c +++ b/drivers/firmware/iscsi_ibft.c @@ -542,6 +542,7 @@ static umode_t __init ibft_check_tgt_for(void *data, int type) case ISCSI_BOOT_TGT_NIC_ASSOC: case ISCSI_BOOT_TGT_CHAP_TYPE: rc = S_IRUGO; + break; case ISCSI_BOOT_TGT_NAME: if (tgt->tgt_name_len) rc = S_IRUGO; |
