summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRoel Kluin <roel.kluin@gmail.com>2009-08-02 13:30:45 +0200
committerTakashi Iwai <tiwai@suse.de>2009-08-03 08:34:06 +0200
commit4b35d2ca2307d40ccb6b3b6f9cc25ac9178b2a6c (patch)
treedc9b48bb125dcc52a645af62b4e875ffd8fe88f3
parent84d3dc200fc8b878acf7c1840b238e6a0450e4d0 (diff)
downloadtalos-obmc-linux-4b35d2ca2307d40ccb6b3b6f9cc25ac9178b2a6c.tar.gz
talos-obmc-linux-4b35d2ca2307d40ccb6b3b6f9cc25ac9178b2a6c.zip
ALSA: hda - Read buffer overflow
Check whether index is within bounds before testing the element. Signed-off-by: Roel Kluin <roel.kluin@gmail.com> Signed-off-by: Takashi Iwai <tiwai@suse.de>
-rw-r--r--sound/pci/hda/patch_realtek.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index f6b4cbf1ead0..51c44fdbc0f0 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -559,7 +559,7 @@ static int alc_pin_mode_get(struct snd_kcontrol *kcontrol,
/* Find enumerated value for current pinctl setting */
i = alc_pin_mode_min(dir);
- while (alc_pin_mode_values[i] != pinctl && i <= alc_pin_mode_max(dir))
+ while (i <= alc_pin_mode_max(dir) && alc_pin_mode_values[i] != pinctl)
i++;
*valp = i <= alc_pin_mode_max(dir) ? i: alc_pin_mode_min(dir);
return 0;
OpenPOWER on IntegriCloud