diff options
| author | Andy Shevchenko <andriy.shevchenko@linux.intel.com> | 2014-11-07 16:53:12 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2014-11-07 12:20:43 -0500 |
| commit | 424c4f7875ee21e803f6ebeb8799b6185eda7864 (patch) | |
| tree | 57053dedac0c9108b2c16a34ae873b74da75017a | |
| parent | 7f6d46704fe0895f33b81552244344422c1c647c (diff) | |
| download | talos-obmc-linux-424c4f7875ee21e803f6ebeb8799b6185eda7864.tar.gz talos-obmc-linux-424c4f7875ee21e803f6ebeb8799b6185eda7864.zip | |
stmmac: remove custom implementation of print_hex_dump()
There is a kernel helper to dump buffers in a hexdecimal format. This patch
substitutes the open coded function by calling that helper.
The output is slightly changed:
- no lead space
- ASCII part will be printed along with the dump
- offset is longer than 3 characters (now 8)
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 10 |
1 files changed, 2 insertions, 8 deletions
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c index fa598b97d710..53db11b29e61 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c @@ -191,14 +191,8 @@ static void stmmac_clk_csr_set(struct stmmac_priv *priv) static void print_pkt(unsigned char *buf, int len) { - int j; - pr_debug("len = %d byte, buf addr: 0x%p", len, buf); - for (j = 0; j < len; j++) { - if ((j % 16) == 0) - pr_debug("\n %03x:", j); - pr_debug(" %02x", buf[j]); - } - pr_debug("\n"); + pr_debug("len = %d byte, buf addr: 0x%p\n", len, buf); + print_hex_dump_bytes("", DUMP_PREFIX_OFFSET, buf, len); } /* minimum number of free TX descriptors required to wake up TX process */ |
