summaryrefslogtreecommitdiffstats
path: root/src
Commit message (Collapse)AuthorAgeFilesLines
...
* Fix bug in crash handler register dumpZach Clark2019-11-201-10/+11
| | | | | | | | | | | | | | | | This commit fixes a NULL-dereference in the register dump code for the kernel crash handler. The task pointer can be NULL, in which case we should not attempt to dump registers. Change-Id: I3433ca466f34827f102d64ef2aac4fffc5b49b70 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/87422 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: William G Hoffa <wghoffa@us.ibm.com> Reviewed-by: Nicholas E Bofferding <bofferdn@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Fix auto-arming NVDIMMs for ESS systemsCorey Swenson2019-11-195-836/+852
| | | | | | | | | | | | | | | | | | | ESS requires HB to arm the NVDIMMs during IPL after PM complex is started. Requires moving the nvdimmArm() and associated functions from nvdimm_rt.C to nvdimm.C. Change-Id: Ie7fd08b27ad7959b21086f0f291764c2156e5bd9 CQ:SW479909 CMVC-Prereq:1096403 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/86489 Reviewed-by: Matt Derksen <mderkse1@us.ibm.com> Reviewed-by: Roland Veloz <rveloz@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Add DIMM_BAD_DQ_DATA field for DDR4 DDIMM SPD and bad dq testsCaleb Palmer2019-11-193-0/+229
| | | | | | | | | | | | | | | Change-Id: I1242a9f8733679afb0fee632e985ccf28096fbd9 RTC: 245516 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/87098 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Zane C Shelley <zshelle@us.ibm.com> Reviewed-by: Paul Greenwood <paul.greenwood@ibm.com> Reviewed-by: Brian J Stegmiller <bjs@us.ibm.com> Reviewed-by: Benjamen G Tyner <ben.tyner@ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* pmic_status_tool updatesMichael Pardeik2019-11-191-0/+14
| | | | | | | | | | | | | | | | | | | Add support for current warning/limiter limits Add telemetry option for current/power/voltage/temperature values Change FAPI_INF to use mss::logf and mss::TRACE Change-Id: I6812b29f34727a5ecf0b13c34e7d449e280ad569 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/86896 Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com> Reviewed-by: Louis Stermole <stermole@us.ibm.com> Reviewed-by: Mark Pizzutillo <mark.pizzutillo@ibm.com> Reviewed-by: Jennifer A Stofer <stofer@us.ibm.com> Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/86911 Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Christian R Geddes <crgeddes@us.ibm.com>
* Add NVDIMM opertions to rt_cmdsCorey Swenson2019-11-181-1/+44
| | | | | | | | | | | | Change-Id: I7b7fbe5c0248d749e80bfc3b8eaa7daa7dbf7a65 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/86759 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: Matt Derksen <mderkse1@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Roland Veloz <rveloz@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Add support for NULL char in vendor logCorey Swenson2019-11-181-2/+51
| | | | | | | | | | | | | | | | | | | SMART is adding a NULL char to indicate the last entry added to the log. This is useful when the log wraps. A single NULL char indicates the log has wrapped. More than one NULL char in a row indicates the log has not wrapped. Display the log in chronological order. Change-Id: Ic0404b60ad617b7c0c6a09b710e54cb1736bd9d4 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/86630 Reviewed-by: Matt Derksen <mderkse1@us.ibm.com> Reviewed-by: TSUNG K YEUNG <tyeung@us.ibm.com> Reviewed-by: Christian R Geddes <crgeddes@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Fix UVBWLIST SBE Chip OpIlya Smirnov2019-11-181-1/+1
| | | | | | | | | | | | | | | | | | | The address where SBE is to populate the ultravisor white/blacklist is to be put in Mbox reg1, which means that the register needs to be masked in the command we're sending. Before this change, only Mbox reg0 was masked, and SBE was not getting the correct address at which to populate the UVBWLIST. This change masks Mbox Reg 1 so that SBE can receive the correct address for the UVBWLIST. Change-Id: I841db74dc407f51c14f005b9ccd457d5641ffa7e Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/87102 Reviewed-by: Nicholas E Bofferding <bofferdn@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Reviewed-by: RAJA DAS <rajadas2@in.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Allow HWPs that send BOOT_CONFIG command to ocbm to run in simicsChristian Geddes2019-11-172-6/+0
| | | | | | | | | | | | | Previously simics was not responding correctly to this command but the latest simics versions have updates so they will give us what we expect. Change-Id: I1c009b834eb0081e3b806414d48409e23b6280ef Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/86871 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Add missing trace point to BlTrace.pm toolDan Crowell2019-11-161-0/+1
| | | | | | | | | | | | | | | We were missing the FD error path. Change-Id: Ib52b2ee7dd3ebe7583224b8ef57e85fce561641e Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/86960 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: William G Hoffa <wghoffa@us.ibm.com> Reviewed-by: Chen Du <duchen@us.ibm.com> Reviewed-by: Matt Derksen <mderkse1@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Move KEY_CLEAR_REQUEST attribute from node level to system levelMike Baiocchi2019-11-161-3/+3
| | | | | | | | | | | | | Change-Id: I2de1bcbfb7a8d8adfa47a6e62bdbad3ab2514a55 RTC:210301 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/87081 Reviewed-by: Christopher J Engel <cjengel@us.ibm.com> Reviewed-by: Ilya Smirnov <ismirno@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Nicholas E Bofferding <bofferdn@us.ibm.com>
* Add MCBIST infinite testsMark Pizzutillo2019-11-151-0/+11
| | | | | | | | | | | | | | | | | Change-Id: I54a042d0612a3debd616fa191f524d583fcc34e8 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/86588 Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: HWSV CI <hwsv-ci+hostboot@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: PPE CI <ppe-ci+hostboot@us.ibm.com> Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com> Reviewed-by: Louis Stermole <stermole@us.ibm.com> Reviewed-by: STEPHEN GLANCY <sglancy@us.ibm.com> Reviewed-by: Jennifer A Stofer <stofer@us.ibm.com> Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/86677 Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Christian R Geddes <crgeddes@us.ibm.com>
* exp_mss_eff_config_thermal fixesMichael Pardeik2019-11-159-150/+221
| | | | | | | | | | | | | | | | | | | | | | Fix pwr_throttles call for thermal throttle type Fix equalize throttles call for power throttling type Updates to handle DDIMM and non-DDIMM differences Clarify related power and thermal MRW attribute descriptions Change-Id: I34ecfd4bbb97f1e74c258a474e0b5daf3a4dcbbb Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84620 Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Dev-Ready: STEPHEN GLANCY <sglancy@us.ibm.com> Tested-by: HWSV CI <hwsv-ci+hostboot@us.ibm.com> Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com> Reviewed-by: STEPHEN GLANCY <sglancy@us.ibm.com> Reviewed-by: Mark Pizzutillo <mark.pizzutillo@ibm.com> Reviewed-by: Jennifer A Stofer <stofer@us.ibm.com> Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84699 Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Christian R Geddes <crgeddes@us.ibm.com>
* Update simics level to f0c3530f4fefad5236391e61ae29b1a2582636caDan Crowell2019-11-141-1/+1
| | | | | | | | | | | | | | | Fixes for - 2 proc axone model - BOOT_CONFIG responses for Explorer Change-Id: I30273f3b64ec5cfc28331916883c1dfdce744d0e Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/86870 Reviewed-by: Christian R Geddes <crgeddes@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Disables broadcast mode in memdiags::continue_cmdStephen Glancy2019-11-141-2/+6
| | | | | | | | | | | | | | | | | | | | | | | Broadcast mode at runtime can cause issues. memdiags::continue_cmd is called at runtime, so disabling the broadcast mode check will fix an NVDIMM runtime bug. Change-Id: Ib13ad0bf46c44aa26a6df39ffabc507348a1a14e CQ:SW480744 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/86898 Reviewed-by: Mark Pizzutillo <mark.pizzutillo@ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com> Reviewed-by: Louis Stermole <stermole@us.ibm.com> Reviewed-by: Zane C Shelley <zshelle@us.ibm.com> Reviewed-by: Caleb N Palmer <cnpalmer@us.ibm.com> Reviewed-by: Jennifer A Stofer <stofer@us.ibm.com> Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/86912 Reviewed-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com> Tested-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Mark bootloader RCs for FSP exportDan Crowell2019-11-141-0/+8
| | | | | | | | | | | | | | We missed adding the magic flag to the HBBL RCs that FSP needs to process. Change-Id: I5ca8c9aecf6075fe1eca379c0b26a62596c63ec3 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/86930 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: Nicholas E Bofferding <bofferdn@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Add Physical Presence Check and Window Open FeaturesMike Baiocchi2019-11-1413-13/+700
| | | | | | | | | | | | | | | | | | | | | | | | This commit does the following: - Adds an interface to detect if physical presence has been asserted -- This happens in istep 6 -- If the window is open to detect this, it is then closed here - Adds an interface to possibly open the window to look for physical presence -- This happens in istep 10 -- It first checks to see if the window should be opened -- If the window is opened then the system shuts down to wait for physical presence to be asserted on the next power on - Adds the necessary attributes to support and test this functionality RTC:211220 Change-Id: I05a26ebad581875a4b9f2a51eb1ca3062f36c5fb Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84656 Reviewed-by: Ilya Smirnov <ismirno@us.ibm.com> Reviewed-by: Christopher J Engel <cjengel@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Nicholas E Bofferding <bofferdn@us.ibm.com>
* Support GPIO Physical Presence Detect DevicesMike Baiocchi2019-11-148-20/+592
| | | | | | | | | | | | | | | | | | | | This commit makes the necessary changes to support the GPIO devices used for physical presence detection: - New attribute GPIO_INFO_PHYS_PRES - Enable GPIO Device Driver by default - GPIO Device Driver updated to support new device type - Added new GPIO PCA9551 layer to sit on top of GPIO Device Driver Change-Id: I952007503eb5d9fe873adea2eaaeccff21ae18a6 RTC:211220 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84655 Reviewed-by: Ilya Smirnov <ismirno@us.ibm.com> Reviewed-by: Christopher J Engel <cjengel@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Nicholas E Bofferding <bofferdn@us.ibm.com>
* Update ATTR_MEM_VPD_DQ_MAPs default to a 1-to-1 mappingCaleb Palmer2019-11-131-2/+8
| | | | | | | | | | | | | | | | | | CMVC-Coreq: 1096221 Change-Id: I4c771180f3bcc8e64959976be07ce8cf222ae688 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/86144 Reviewed-by: Louis Stermole <stermole@us.ibm.com> Reviewed-by: STEPHEN GLANCY <sglancy@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com> Tested-by: HWSV CI <hwsv-ci+hostboot@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com> Reviewed-by: Jennifer A Stofer <stofer@us.ibm.com> Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/86264 Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Christian R Geddes <crgeddes@us.ibm.com>
* Fix odt RD/WR fieldsMark Pizzutillo2019-11-136-34/+170
| | | | | | | | | | | | | | | | | Change-Id: I4aaa23af53a72e4f90218daedbed80d8721ff337 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/86280 Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com> Reviewed-by: Louis Stermole <stermole@us.ibm.com> Reviewed-by: STEPHEN GLANCY <sglancy@us.ibm.com> Dev-Ready: STEPHEN GLANCY <sglancy@us.ibm.com> Tested-by: HWSV CI <hwsv-ci+hostboot@us.ibm.com> Reviewed-by: Jennifer A Stofer <stofer@us.ibm.com> Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/86542 Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Uncomment the remainder of hwp_wrappers.HCaleb Palmer2019-11-121-8/+6
| | | | | | | | | | | | | | | | | Change-Id: Idf567c5cddbf4b5f4e4683ef411fd9d060b88c2f Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/86473 Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com> Reviewed-by: Zane C Shelley <zshelle@us.ibm.com> Reviewed-by: Brian J Stegmiller <bjs@us.ibm.com> Reviewed-by: Paul Greenwood <paul.greenwood@ibm.com> Reviewed-by: Louis Stermole <stermole@us.ibm.com> Reviewed-by: Jennifer A Stofer <stofer@us.ibm.com> Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/86485 Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Christian R Geddes <crgeddes@us.ibm.com>
* Adds NVDIMM RCW drive strength workaroundStephen Glancy2019-11-123-0/+135
| | | | | | | | | | | | | | | | | | | | | | | | An NVDIMM supplier updated the drive strength values for for the RCW's command/address/control signals. The new drive strength causes the parts to fail writes/reads. This commit restores the old drive strength values. Change-Id: If4d44f08cff2522de463b9a2ac57853950aa3356 CQ:SW478491 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/85229 Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Louis Stermole <stermole@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com> Dev-Ready: STEPHEN GLANCY <sglancy@us.ibm.com> Reviewed-by: JEREMY R NEATON <jrneaton@us.ibm.com> Reviewed-by: TSUNG K YEUNG <tyeung@us.ibm.com> Reviewed-by: Jennifer A Stofer <stofer@us.ibm.com> Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/85426 Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Christian R Geddes <crgeddes@us.ibm.com>
* Reverse mcbist address buffer fieldsMark Pizzutillo2019-11-122-1/+45
| | | | | | | | | | | | | | | Change-Id: Ib1b68cd1a21c9190db170d95e6d528bebfbc2539 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/86044 Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: STEPHEN GLANCY <sglancy@us.ibm.com> Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com> Reviewed-by: Louis Stermole <stermole@us.ibm.com> Reviewed-by: Jennifer A Stofer <stofer@us.ibm.com> Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/86054 Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Christian R Geddes <crgeddes@us.ibm.com>
* MDIA: Uncomment HWP callsCaleb Palmer2019-11-123-27/+46
| | | | | | | | | | | | | | Change-Id: I23f0abb7b6d26c2fa6d197ceaa0cc276ec461594 RTC: 201293 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/86476 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Brian J Stegmiller <bjs@us.ibm.com> Reviewed-by: Benjamen G Tyner <ben.tyner@ibm.com> Reviewed-by: Paul Greenwood <paul.greenwood@ibm.com> Reviewed-by: Zane C Shelley <zshelle@us.ibm.com>
* Improper element erase during loop causing post-restore being skipped on nvdimmTsung Yeung2019-11-111-18/+21
| | | | | | | | | | | | | Change-Id: Iec89586a9ac019960a11b2c4924046c17cec3b06 CQ:SW474826 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/86265 Reviewed-by: Matt Derksen <mderkse1@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Reviewed-by: Corey V Swenson <cswenson@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Add 100ms wait to disable write protection for BPMMatthew Raybuck2019-11-111-0/+2
| | | | | | | | | | | | | | | | | | There was an issue where without waiting after unlocking the BPM registers we'd fail out of the BPM update. This commit adds a 100ms delay after writing the unlock sequence before reading to verify that the registers were unlocked. Change-Id: Ic8cfeb8dba181d4071bb2d4dccaf367d88840cc2 CQ:SW480382 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/86707 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: TSUNG K YEUNG <tyeung@us.ibm.com> Reviewed-by: Matt Derksen <mderkse1@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Create submodule in hostboot repo for mctpJet Li2019-11-111-0/+0
| | | | | | | | | | | | | | | | | This commit does the following... -Adds libmctp repo as submodule of hostboot repo -Modify .gitmodule to make submodule updates RTC: 215965 Change-Id: I4bd498b15b86f0bc0e9fdd9c495c390d56308f76 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/85889 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Nicholas E Bofferding <bofferdn@us.ibm.com> Reviewed-by: Michael Baiocchi <mbaiocch@us.ibm.com> Reviewed-by: William G Hoffa <wghoffa@us.ibm.com>
* Increase size of default printk buffer in error logsDan Crowell2019-11-111-2/+4
| | | | | | | | | | | | | | | | | | | Recent changes to add more data to our exception path have made the printk output we get in our error logs less useful than it should be. It currently takes at minimum 1076 bytes for a single exception. That number would increase if the backtrace got very large. This change resizes the buffer to allow for 17 stack frames within a single exception (1280 bytes). Change-Id: I029283ee39877c3ace812fd85c0fbc26cdecf230 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/86596 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Matt Derksen <mderkse1@us.ibm.com> Reviewed-by: Zachary Clark <zach@ibm.com> Reviewed-by: Nicholas E Bofferding <bofferdn@us.ibm.com>
* Move HBRT reserved memory off of NVDIMMsDan Crowell2019-11-083-1/+194
| | | | | | | | | | | | | | | | | | On a NVDIMM system we need to make sure that we don't use the NV memory for the HOMER (or other reserved memory). Depending on the specific memory layout the NV memory could be placed at the top of memory where we would normally land. Change-Id: Ie4407c63a4944cc5be13d2573d06fbed09d6a11f CQ: SW470564 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/86480 Reviewed-by: Ilya Smirnov <ismirno@us.ibm.com> Reviewed-by: Corey V Swenson <cswenson@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Matt Derksen <mderkse1@us.ibm.com> Reviewed-by: William G Hoffa <wghoffa@us.ibm.com>
* Always position HOMER in HV space for istep 16Dean Sanner2019-11-082-74/+93
| | | | | | | | | | | | | | | | | | | | | | | | P9N/P9C always inits to DD2.x mode for hostboot which doesn't support SMF. This means that the HCODE non secure transition to HCODE secure won't work. Because of that, we now force istep 16 to always place HOMER in non SMF memory (in UV mode if SMF active) and transition into UV there. Then in istep 21 the HOMER is rebuilt correctly for SMF. Note that all the changes are in istep 15 as istep 21 uses the ATTR setup there. Change-Id: I566903dc373667a410ddcc0a1d2cc91bcd94b08d Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/81202 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Dean Sanner <dsanner@us.ibm.com> Reviewed-by: Christian R Geddes <crgeddes@us.ibm.com> Reviewed-by: William G Hoffa <wghoffa@us.ibm.com>
* Fix timestamp parser for OpenBMC ESELsDan Crowell2019-11-081-10/+34
| | | | | | | | | | | | | | | | | | | | Evidently the OpenBMC code changed their timestamp format at some point so our parser isn't grabbing it anymore. It will now handle data in a format like this: "raweSEL": "00 00 df 00 00 00 00 20 00 04 ... "timestamp": "2019-10-31 10:20:50" Change-Id: Ieeae63505ce0497a3b3fcf1fd0a92455c8319e29 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/86538 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Ilya Smirnov <ismirno@us.ibm.com> Reviewed-by: Corey V Swenson <cswenson@us.ibm.com> Reviewed-by: William G Hoffa <wghoffa@us.ibm.com>
* Modify INTRP Initialization Order to route LSI interrupts over PSHIHBBill Hoffa2019-11-081-7/+7
| | | | | | | | | | | | | | | | | - Currently the code sets up routing over PSIHIB and then a second function call overwrites that setting which forces things back on the local wire Change-Id: I7d3b44d48c66f994e8a8758eb75568038492fdaf CQ: SW464174 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/86669 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Ilya Smirnov <ismirno@us.ibm.com> Reviewed-by: Michael Baiocchi <mbaiocch@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Fixes to PMIC presence detectionChristian Geddes2019-11-074-24/+81
| | | | | | | | | | | | | | | | | | | | | While performing presence detection on the PMIC targets we need to first read the parent OCMB's SPD to see what device address the PMIC is on. There was a bug where we were attempting to read the parent OCMB's spd without first checking if the OCMB is present itself. This commit adds a check to ensure we dont attempt i2c reads on devices that are not present. Also this commit adds a check to make sure we do not attempt presence detection on GEMINI ocmbs Change-Id: I999189b3b97210bb37b7ba1fdb2d86658d770e36 CQ: SW480414 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/86564 Reviewed-by: Ilya Smirnov <ismirno@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Avoid commiting errors inside fapi2_i2c device driverChristian Geddes2019-11-071-13/+34
| | | | | | | | | | | | | | | | | | | | | | | | There are instances where we expect NACK errors returned from i2c requests, for example when waiting for the ocmbs to declare themselves "ready". In these cases we do not want to flood the error log with expected I2C nack errors. To avoid this, instead of committing retriable errors inside of the fapi2_i2c device driver when the MAX RETRY ATTEMPTS is reached we will instead just add traces to the err that gets returned to the caller that explain previous retryable errs occured. In the case where we hit retryable errors and eventually hit and non-retryable error the retryable error is committed in the driver and the non-retryable error is returned to the caller. Also this commit adds some timings to the error log so we can tell how long our attempts took. Change-Id: I9a5ee0bfe088444aa7fecd974f61514c40b320a6 CQ: SW480155 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/86419 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: Matt Derksen <mderkse1@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Fix fapi spd testcasesDan Crowell2019-11-062-170/+123
| | | | | | | | | | | | | | | Fixed a few places where the Axone path was getting skipped incorrectly, then fixed the resulting latent errors. Change-Id: I917b9a0b6f4ff1491ff384dc924e29f688548873 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/85688 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Zachary Clark <zach@ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Christian R Geddes <crgeddes@us.ibm.com> Reviewed-by: William G Hoffa <wghoffa@us.ibm.com>
* Remove excessive NVDIMM tracing from normal pathMatt Derksen2019-11-061-20/+52
| | | | | | | | | | | | | | | | | | Tracing is causing a bottleneck when running NVDIMM updates. Should only trace the real failure and add what is needed for debug into the error log. Change-Id: Ifa75f85e1129efd9642a3fef0b842fc1f60cd182 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/75667 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Glenn Miles <milesg@ibm.com> Reviewed-by: Christian R. Geddes <crgeddes@us.ibm.com> Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com> Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/85499 Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Fix ipmifruinv calls for dimms in swift systemsChristian Geddes2019-11-061-0/+2
| | | | | | | | | | | | | | | | | | We had a bug in the VPD map for the the DDR4_DDIMMs where we were missing fields that were expected in the data collection for the fruinventory. This commit adds the field we were missing and also adds the PART_NUMBER field which the BMC is currently just leaving blank. Change-Id: I65dbfb0b79bef9d3a9a3bf2d6aa135c5df5ece56 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/86420 Reviewed-by: William G Hoffa <wghoffa@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Matt Derksen <mderkse1@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Adjust deadman timeout request time to be 10.5 secondsChristian Geddes2019-11-061-2/+3
| | | | | | | | | | | | | | | | | | | | | We see intermittent deadman timeouts occuring in our testing. Upon further inspection it was determined that value we were passing to the SBE was being cast to a uint32_t and multiplied by up to a factor of 400000 , which was resulting in an overflow of the uint32_t. This was giving us a timeout lower than desired. This commit lowers the requested timeout to be 10.5 seconds which will not overflow the uint32_t. Change-Id: I747db46a5d4a99d273b5604971d3db51f077be50 CQ: SW477557 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/86513 Reviewed-by: Glenn Miles <milesg@ibm.com> Reviewed-by: Michael Baiocchi <mbaiocch@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: William G Hoffa <wghoffa@us.ibm.com>
* Slot check after firmware updateMatt Derksen2019-11-055-11/+147
| | | | | | | | | | | | | | | | | | Verify every NVDIMM is running from slot 1 and is at the latest firmware version. Create a predictive error for those that are not running latest code level. Change-Id: I46766d267f4a1293739a49c989ef5ab7dde585b5 CQ:SW478561 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/85656 Reviewed-by: Corey V Swenson <cswenson@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Reviewed-by: TSUNG K YEUNG <tyeung@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Add new Key Clear Request AttributeMike Baiocchi2019-11-052-0/+78
| | | | | | | | | | | | | | | | | | This commit adds a new Key Clear Request Attribute and Enumeration to be shared by the FSP and Hostboot code for future Key Clear support. Change-Id: I74bb9c12ed1d3fdcf8f55c77c76d4001b15e3b0f RTC:210301 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/86409 Reviewed-by: Christopher J Engel <cjengel@us.ibm.com> Reviewed-by: Ilya Smirnov <ismirno@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Reviewed-by: Nicholas E Bofferding <bofferdn@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* NVDIMM FW update region write retryMatt Derksen2019-11-052-16/+61
| | | | | | | | | | | | | | | | | | Retry writing a region of code if the checksums do not match. Retry up to 3 times per region. Second of two commits for this defect. CQ:SW469894 Change-Id: Id3cbd71a2930a2dc19532b3b5c87f692dde447cd Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/80360 Reviewed-by: TSUNG K YEUNG <tyeung@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Corey V Swenson <cswenson@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* NVDIMM update - Clear FW Ops Status verificationMatt Derksen2019-11-053-7/+117
| | | | | | | | | | | | | | | | | | | SMART is recommending after 0x41=0x02 (Clear FW Ops Status) that the IBM utility read 0x71 to verify that the OPS_SUCCESS and OPS_ERROR bits have been cleared and that only Bit 2 (FIRMWARE_UPDATE_MODE) is set. First of two fixes for SW469894 Change-Id: Id9e9d7fa5abd5bcd3bae806b27332513f48956b2 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83946 Reviewed-by: TSUNG K YEUNG <tyeung@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Corey V Swenson <cswenson@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Adding obj_handle values for attentions to explorer.scom.initfileBen Gass2019-11-042-0/+90
| | | | | | | | | | | | | | | | Change-Id: Ifb4928893d78ab399614c0ef5aa30a1074118903 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/66683 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Dev-Ready: Benjamin Gass <bgass@us.ibm.com> Reviewed-by: Louis Stermole <stermole@us.ibm.com> Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com> Reviewed-by: Benjamin Gass <bgass@us.ibm.com> Reviewed-by: Jennifer A Stofer <stofer@us.ibm.com> Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/85236 Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Christian R Geddes <crgeddes@us.ibm.com>
* Allow dynmic i2c device addresses and set up PMIC targets to do thisChristian Geddes2019-11-0110-17/+242
| | | | | | | | | | | | | | | | | | | | | | Depending on which vendor made a given OCMB the i2c device address of the PMIC targets on the OCMB will be different. To account for this we have added a new DYNAMIC_DEVICE_ADDRESS attribute. This attribute is filled out on the PMIC target by looking at the SPD on parent OCMB chip. This means that we must do presence detection on the OCMB prior to the the PMIC targets. While doing i2c operations if a given target has the DYNAMIC_DEVICE_ADDRESS we will use that over the devAddr in the any complex i2c attribute for that target. Change-Id: I22a185a65c064a1514751dd5828547c57af98df1 RTC: 209714 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/85394 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com> Reviewed-by: Roland Veloz <rveloz@us.ibm.com> Reviewed-by: William G Hoffa <wghoffa@us.ibm.com>
* Replaces NVDIMM flush sequence with CCSTsung Yeung2019-11-013-188/+181
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The current design relies on the power control logic to put the nvdimm into STR. There have been several defects opened on the nvdimm failing to save due to STR not entered but no indication of the function failing to execute. Therefore, the decision has been made to leverage CCS to issue STR and assert RESETn. This gives us full control of what goes onto the bus and not have to worry about STR getting exit due to unwanted mainline traffic. The same CCS sequence has already been exercised numerous times on AC powerloss path. Change-Id: Idd422beea72ee5902674562f5834c1ac9e79fe00 CQ:SW477735 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/85831 Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Dev-Ready: STEPHEN GLANCY <sglancy@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: PPE CI <ppe-ci+hostboot@us.ibm.com> Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com> Tested-by: HWSV CI <hwsv-ci+hostboot@us.ibm.com> Reviewed-by: Louis Stermole <stermole@us.ibm.com> Reviewed-by: STEPHEN GLANCY <sglancy@us.ibm.com> Reviewed-by: Jennifer A Stofer <stofer@us.ibm.com> Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/85879 Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Christian R Geddes <crgeddes@us.ibm.com>
* Only call memdiags on Explorer ocmb chipsChristian Geddes2019-10-311-9/+15
| | | | | | | | | | | | | | | | | | We should only call memdiags on the Explorer ocmb chips because it will fail if we attempt to call it on the Gemini chips. Gemini chips will boot fine without this step being called. Change-Id: I50645db29b17d4dc93de9c1e5f7b419e5dea6f0d Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/86159 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Glenn Miles <milesg@ibm.com> Reviewed-by: Ilya Smirnov <ismirno@us.ibm.com> Reviewed-by: Nicholas E Bofferding <bofferdn@us.ibm.com> Reviewed-by: Roland Veloz <rveloz@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* update include path to resolve compiler warning in cronusSteven Janssen2019-10-301-1/+1
| | | | | | | | | | | | | | | Change-Id: Ic79d5ee09622ed6310b579a088d7dfff8996854b Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/85618 Dev-Ready: Steven B Janssen <janssens@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com> Reviewed-by: Louis Stermole <stermole@us.ibm.com> Reviewed-by: STEPHEN GLANCY <sglancy@us.ibm.com> Reviewed-by: Jennifer A Stofer <stofer@us.ibm.com> Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/85646 Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Add assert for RSP extended data buffer size in exp_draminitMark Pizzutillo2019-10-303-7/+119
| | | | | | | | | | | | | | | | | Change-Id: If924286f31c31bb66b5191d51afce43c8a1e50d2 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/85774 Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: PPE CI <ppe-ci+hostboot@us.ibm.com> Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com> Reviewed-by: Louis Stermole <stermole@us.ibm.com> Reviewed-by: STEPHEN GLANCY <sglancy@us.ibm.com> Dev-Ready: STEPHEN GLANCY <sglancy@us.ibm.com> Reviewed-by: Jennifer A Stofer <stofer@us.ibm.com> Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/85790 Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Add deconfigure of memory port if mss_freq can't find consensus freqLouis Stermole2019-10-303-7/+28
| | | | | | | | | | | | | | | | | | | | | | | Fixes condition where MSS_PORT_DOES_NOT_SUPPORT_MAJORITY_FREQ caused the IPL to halt. Fixed procedure code to deconfigure correct port's DIMMs, and updated error XML to call out all DIMMs in freq domain. Also updated error description to be more helpful. Change-Id: Ia08357c1de28f5f03d41b95d81a910d6c2e32451 CQ:SW473836 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84733 Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: STEPHEN GLANCY <sglancy@us.ibm.com> Reviewed-by: Mark Pizzutillo <mark.pizzutillo@ibm.com> Tested-by: PPE CI <ppe-ci+hostboot@us.ibm.com> Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com> Tested-by: HWSV CI <hwsv-ci+hostboot@us.ibm.com> Reviewed-by: Jennifer A Stofer <stofer@us.ibm.com> Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84776 Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Add FAPI_ASSERT for unsupported SPD rank in RTT fetchNico Fajardo2019-10-302-6/+39
| | | | | | | | | | | | | | | | | | | Change-Id: I10523ec048e04eebe35e55894949e54a796a2aa5 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/85430 Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Dev-Ready: STEPHEN GLANCY <sglancy@us.ibm.com> Reviewed-by: Mark Pizzutillo <mark.pizzutillo@ibm.com> Tested-by: PPE CI <ppe-ci+hostboot@us.ibm.com> Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com> Tested-by: HWSV CI <hwsv-ci+hostboot@us.ibm.com> Reviewed-by: Louis Stermole <stermole@us.ibm.com> Reviewed-by: STEPHEN GLANCY <sglancy@us.ibm.com> Reviewed-by: Jennifer A Stofer <stofer@us.ibm.com> Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/85448 Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
* Create FW interfaces to execute memory diagnosticsDan Crowell2019-10-304-85/+374
| | | | | | | | | | | | | | | | | | | Created 2 files, each encapsulating the functionality to drive memdiags for either Nimbus or Explorer. Change-Id: Ice58b4eb43c51b30ed5ba22c7b5d042eea5e4bfe Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/85588 Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Dev-Ready: STEPHEN GLANCY <sglancy@us.ibm.com> Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com> Reviewed-by: ANDRE A MARIN <aamarin@us.ibm.com> Reviewed-by: STEPHEN GLANCY <sglancy@us.ibm.com> Reviewed-by: Jennifer A Stofer <stofer@us.ibm.com> Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/85592 Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
OpenPOWER on IntegriCloud