summaryrefslogtreecommitdiffstats
path: root/src
diff options
context:
space:
mode:
authorNico Fajardo <Nicolas.Fajardo@ibm.com>2019-10-16 15:20:16 -0500
committerDaniel M Crowell <dcrowell@us.ibm.com>2019-10-30 14:35:08 -0500
commit1c830e13d2447ff6c41402dbfa8dec4d7ee3e801 (patch)
tree2544c949187799477aaeaf416d4c8d44677196c9 /src
parent4924154e6010b820fad881164c4c0c691569fcd1 (diff)
downloadtalos-hostboot-1c830e13d2447ff6c41402dbfa8dec4d7ee3e801.tar.gz
talos-hostboot-1c830e13d2447ff6c41402dbfa8dec4d7ee3e801.zip
Add FAPI_ASSERT for unsupported SPD rank in RTT fetch
Change-Id: I10523ec048e04eebe35e55894949e54a796a2aa5 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/85430 Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Dev-Ready: STEPHEN GLANCY <sglancy@us.ibm.com> Reviewed-by: Mark Pizzutillo <mark.pizzutillo@ibm.com> Tested-by: PPE CI <ppe-ci+hostboot@us.ibm.com> Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com> Tested-by: HWSV CI <hwsv-ci+hostboot@us.ibm.com> Reviewed-by: Louis Stermole <stermole@us.ibm.com> Reviewed-by: STEPHEN GLANCY <sglancy@us.ibm.com> Reviewed-by: Jennifer A Stofer <stofer@us.ibm.com> Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/85448 Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
Diffstat (limited to 'src')
-rw-r--r--src/import/generic/memory/lib/data_engine/attr_engine_traits.H30
-rw-r--r--src/import/generic/procedures/xml/error_info/generic_error.xml15
2 files changed, 39 insertions, 6 deletions
diff --git a/src/import/generic/memory/lib/data_engine/attr_engine_traits.H b/src/import/generic/memory/lib/data_engine/attr_engine_traits.H
index 077466a3c..c31a5ae30 100644
--- a/src/import/generic/memory/lib/data_engine/attr_engine_traits.H
+++ b/src/import/generic/memory/lib/data_engine/attr_engine_traits.H
@@ -1393,8 +1393,14 @@ struct attrEngineTraits<P, attr_si_engine_fields, attr_si_engine_fields::SI_DRAM
break;
default:
- // TODO Add FFDC
- fapi2::Assert(false);
+ FAPI_ASSERT(false,
+ fapi2::MSS_INVALID_SPD_RANK().
+ set_FUNCTION(SET_SI_DRAM_RTT_NOM).
+ set_RANK( i_efd_data->get_rank() ).
+ set_TARGET(l_ocmb),
+ "%s SPD decoder returned invalid rank: %d",
+ spd::c_str(l_ocmb),
+ i_efd_data->get_rank());
break;
};
@@ -1484,8 +1490,14 @@ struct attrEngineTraits<P, attr_si_engine_fields, attr_si_engine_fields::SI_DRAM
break;
default:
- // TODO Add FFDC
- fapi2::Assert(false);
+ FAPI_ASSERT(false,
+ fapi2::MSS_INVALID_SPD_RANK().
+ set_FUNCTION(SET_SI_DRAM_RTT_WR).
+ set_RANK( i_efd_data->get_rank() ).
+ set_TARGET(l_ocmb),
+ "%s SPD decoder returned invalid rank: %d",
+ spd::c_str(l_ocmb),
+ i_efd_data->get_rank());
break;
};
@@ -1580,8 +1592,14 @@ struct attrEngineTraits<P, attr_si_engine_fields, attr_si_engine_fields::SI_DRAM
break;
default:
- // TODO Add FFDC
- fapi2::Assert(false);
+ FAPI_ASSERT(false,
+ fapi2::MSS_INVALID_SPD_RANK().
+ set_FUNCTION(SET_SI_DRAM_RTT_PARK).
+ set_RANK( i_efd_data->get_rank() ).
+ set_TARGET(l_ocmb),
+ "%s SPD decoder returned invalid rank: %d",
+ spd::c_str(l_ocmb),
+ i_efd_data->get_rank());
break;
};
diff --git a/src/import/generic/procedures/xml/error_info/generic_error.xml b/src/import/generic/procedures/xml/error_info/generic_error.xml
index 0b7e037d9..ea67f4551 100644
--- a/src/import/generic/procedures/xml/error_info/generic_error.xml
+++ b/src/import/generic/procedures/xml/error_info/generic_error.xml
@@ -505,6 +505,21 @@
</hwpError>
<hwpError>
+ <rc>RC_MSS_INVALID_SPD_RANK</rc>
+ <description>
+ Invalid rank passed into attribute engine.
+ May be due to problem in SPD.
+ </description>
+ <ffdc>FUNCTION</ffdc>
+ <ffdc>RANK</ffdc>
+ <ffdc>TARGET</ffdc>
+ <callout>
+ <procedure>CODE</procedure>
+ <priority>HIGH</priority>
+ </callout>
+ </hwpError>
+
+ <hwpError>
<rc>RC_MSS_INVALID_SPD_RESERVED_BITS</rc>
<description>
Invalid SPD reserved bits received.
OpenPOWER on IntegriCloud