diff options
| author | prashanthacharya <prashanthacharya@in.ibm.com> | 2012-11-28 08:24:32 -0600 |
|---|---|---|
| committer | A. Patrick Williams III <iawillia@us.ibm.com> | 2013-05-17 10:28:56 -0500 |
| commit | e1223f37f07b4fdbe0df792e0ff52a246b9c741e (patch) | |
| tree | 96e51052ec419ebda226080cb6a64d642ff9bb35 /src | |
| parent | 6d2adfc203a480fac5e736512e5108225048ba5e (diff) | |
| download | talos-hostboot-e1223f37f07b4fdbe0df792e0ff52a246b9c741e.tar.gz talos-hostboot-e1223f37f07b4fdbe0df792e0ff52a246b9c741e.zip | |
Remove some of the fixme tags from PRDF code base
RTC: 52110
Change-Id: I15e88a0b9afb19ce98493df72678a7d4b36663fa
Reviewed-on: http://gfw160.austin.ibm.com:8080/gerrit/2453
Reviewed-by: Zane Shelley <zshelle@us.ibm.com>
Tested-by: Jenkins Server
Reviewed-by: A. Patrick Williams III <iawillia@us.ibm.com>
Reviewed-on: http://gfw160.austin.ibm.com:8080/gerrit/4519
Diffstat (limited to 'src')
| -rwxr-xr-x | src/usr/diag/prdf/common/framework/service/prdf_ras_services.C | 2 | ||||
| -rwxr-xr-x | src/usr/diag/prdf/common/iipconst.h | 1 | ||||
| -rwxr-xr-x | src/usr/diag/prdf/common/util/prdfErrlSmartPtr.H | 8 |
3 files changed, 5 insertions, 6 deletions
diff --git a/src/usr/diag/prdf/common/framework/service/prdf_ras_services.C b/src/usr/diag/prdf/common/framework/service/prdf_ras_services.C index 5085c5011..f67bc886f 100755 --- a/src/usr/diag/prdf/common/framework/service/prdf_ras_services.C +++ b/src/usr/diag/prdf/common/framework/service/prdf_ras_services.C @@ -306,9 +306,7 @@ errlHndl_t ErrDataService::GenerateSrcPfa(ATTENTION_TYPE attn_type, { #ifdef __HOSTBOOT_MODULE - // FIXME: do we want to commit any log here? PRDF_ERR( PRDF_FUNC"Hostboot should NOT have any system checkstop!" ); - #else writeVPD = true; // Change the default so as to Write Capture Data pldCheck = true; // Do the PLD check diff --git a/src/usr/diag/prdf/common/iipconst.h b/src/usr/diag/prdf/common/iipconst.h index cd3096a2c..6f0fddbd4 100755 --- a/src/usr/diag/prdf/common/iipconst.h +++ b/src/usr/diag/prdf/common/iipconst.h @@ -52,7 +52,6 @@ namespace PRDF { - // FIXME: RTC: 51689 will address this issue #ifndef CONTEXT_x86_nfp typedef TARGETING::ATTR_HUID_type HUID; #else diff --git a/src/usr/diag/prdf/common/util/prdfErrlSmartPtr.H b/src/usr/diag/prdf/common/util/prdfErrlSmartPtr.H index c97ad3a96..3fad96728 100755 --- a/src/usr/diag/prdf/common/util/prdfErrlSmartPtr.H +++ b/src/usr/diag/prdf/common/util/prdfErrlSmartPtr.H @@ -72,12 +72,14 @@ class ErrlSmartPtr * at the rc value: * (uint32_t) *errl; */ - /* FIXME : Hostboot ErrorLog disallow this operation but it also doesn't seem to get used - ErrlEntry operator*() const + #ifdef __HOSTBOOT_MODULE + ERRORLOG::ErrlEntry& operator*() const + #else + ErrlEntry& operator*() const + #endif { return *iv_errl; }; - */ /* operator == * Compare with NULL or other ptr values: |
