From e1223f37f07b4fdbe0df792e0ff52a246b9c741e Mon Sep 17 00:00:00 2001 From: prashanthacharya Date: Wed, 28 Nov 2012 08:24:32 -0600 Subject: Remove some of the fixme tags from PRDF code base RTC: 52110 Change-Id: I15e88a0b9afb19ce98493df72678a7d4b36663fa Reviewed-on: http://gfw160.austin.ibm.com:8080/gerrit/2453 Reviewed-by: Zane Shelley Tested-by: Jenkins Server Reviewed-by: A. Patrick Williams III Reviewed-on: http://gfw160.austin.ibm.com:8080/gerrit/4519 --- src/usr/diag/prdf/common/framework/service/prdf_ras_services.C | 2 -- src/usr/diag/prdf/common/iipconst.h | 1 - src/usr/diag/prdf/common/util/prdfErrlSmartPtr.H | 8 +++++--- 3 files changed, 5 insertions(+), 6 deletions(-) (limited to 'src') diff --git a/src/usr/diag/prdf/common/framework/service/prdf_ras_services.C b/src/usr/diag/prdf/common/framework/service/prdf_ras_services.C index 5085c5011..f67bc886f 100755 --- a/src/usr/diag/prdf/common/framework/service/prdf_ras_services.C +++ b/src/usr/diag/prdf/common/framework/service/prdf_ras_services.C @@ -306,9 +306,7 @@ errlHndl_t ErrDataService::GenerateSrcPfa(ATTENTION_TYPE attn_type, { #ifdef __HOSTBOOT_MODULE - // FIXME: do we want to commit any log here? PRDF_ERR( PRDF_FUNC"Hostboot should NOT have any system checkstop!" ); - #else writeVPD = true; // Change the default so as to Write Capture Data pldCheck = true; // Do the PLD check diff --git a/src/usr/diag/prdf/common/iipconst.h b/src/usr/diag/prdf/common/iipconst.h index cd3096a2c..6f0fddbd4 100755 --- a/src/usr/diag/prdf/common/iipconst.h +++ b/src/usr/diag/prdf/common/iipconst.h @@ -52,7 +52,6 @@ namespace PRDF { - // FIXME: RTC: 51689 will address this issue #ifndef CONTEXT_x86_nfp typedef TARGETING::ATTR_HUID_type HUID; #else diff --git a/src/usr/diag/prdf/common/util/prdfErrlSmartPtr.H b/src/usr/diag/prdf/common/util/prdfErrlSmartPtr.H index c97ad3a96..3fad96728 100755 --- a/src/usr/diag/prdf/common/util/prdfErrlSmartPtr.H +++ b/src/usr/diag/prdf/common/util/prdfErrlSmartPtr.H @@ -72,12 +72,14 @@ class ErrlSmartPtr * at the rc value: * (uint32_t) *errl; */ - /* FIXME : Hostboot ErrorLog disallow this operation but it also doesn't seem to get used - ErrlEntry operator*() const + #ifdef __HOSTBOOT_MODULE + ERRORLOG::ErrlEntry& operator*() const + #else + ErrlEntry& operator*() const + #endif { return *iv_errl; }; - */ /* operator == * Compare with NULL or other ptr values: -- cgit v1.2.1