diff options
| author | Nick Bofferding <bofferdn@us.ibm.com> | 2018-09-10 12:10:02 -0500 |
|---|---|---|
| committer | Daniel M. Crowell <dcrowell@us.ibm.com> | 2018-10-01 15:37:58 -0500 |
| commit | 01fcdb647ea0a6c899b9de21ed144f16dc2f2afb (patch) | |
| tree | 79f83d480cb50c10f7a3bb6ea662850b5460c1ea /src/usr/initservice | |
| parent | 7209f9061a3cbc8563e583d4abdcb8ffa4653ceb (diff) | |
| download | talos-hostboot-01fcdb647ea0a6c899b9de21ed144f16dc2f2afb.tar.gz talos-hostboot-01fcdb647ea0a6c899b9de21ed144f16dc2f2afb.zip | |
Shutdown: Move attribute sync to shutdown handler
Moved synching attributes into an attribute resource provider shutdown path
to avoid race conditions along the shutdown path where a normal error path
coupled with parallel shutdown leads to FSP attribute sync errors.
Change-Id: Ibdb828f8132da1e251f880ef0e7d4fea2e4619a3
CQ: SW443737
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/66431
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
Diffstat (limited to 'src/usr/initservice')
| -rw-r--r-- | src/usr/initservice/istepdispatcher/istepdispatcher.C | 15 |
1 files changed, 0 insertions, 15 deletions
diff --git a/src/usr/initservice/istepdispatcher/istepdispatcher.C b/src/usr/initservice/istepdispatcher/istepdispatcher.C index 7b5045ed2..7fe1f0038 100644 --- a/src/usr/initservice/istepdispatcher/istepdispatcher.C +++ b/src/usr/initservice/istepdispatcher/istepdispatcher.C @@ -1028,21 +1028,6 @@ errlHndl_t IStepDispatcher::doIstep(uint32_t i_istep, { TRACFCOMP(g_trac_initsvc, ERR_MRK"doIstep: Istep failed, plid 0x%x", err->plid()); - - // istep fails, sync attributes to FSP - if( INITSERVICE::spBaseServicesEnabled() ) - { - TRACFCOMP(g_trac_initsvc, ERR_MRK"doIstep, Sync attributes to FSP"); - errlHndl_t l_errl = TARGETING::syncAllAttributesToFsp(); - - if(l_errl) - { - TRACFCOMP(g_trac_initsvc, ERR_MRK"doIstep: Attribute syncing" - " failed see 0x%08X for details", l_errl->eid()); - l_errl->setSev(ERRORLOG::ERRL_SEV_INFORMATIONAL); - errlCommit(l_errl, INITSVC_COMP_ID); - } - } } // Check for any attentions and invoke PRD for analysis |
