From 01fcdb647ea0a6c899b9de21ed144f16dc2f2afb Mon Sep 17 00:00:00 2001 From: Nick Bofferding Date: Mon, 10 Sep 2018 12:10:02 -0500 Subject: Shutdown: Move attribute sync to shutdown handler Moved synching attributes into an attribute resource provider shutdown path to avoid race conditions along the shutdown path where a normal error path coupled with parallel shutdown leads to FSP attribute sync errors. Change-Id: Ibdb828f8132da1e251f880ef0e7d4fea2e4619a3 CQ: SW443737 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/66431 Tested-by: Jenkins Server Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Tested-by: FSP CI Jenkins Reviewed-by: Daniel M. Crowell --- src/usr/initservice/istepdispatcher/istepdispatcher.C | 15 --------------- 1 file changed, 15 deletions(-) (limited to 'src/usr/initservice') diff --git a/src/usr/initservice/istepdispatcher/istepdispatcher.C b/src/usr/initservice/istepdispatcher/istepdispatcher.C index 7b5045ed2..7fe1f0038 100644 --- a/src/usr/initservice/istepdispatcher/istepdispatcher.C +++ b/src/usr/initservice/istepdispatcher/istepdispatcher.C @@ -1028,21 +1028,6 @@ errlHndl_t IStepDispatcher::doIstep(uint32_t i_istep, { TRACFCOMP(g_trac_initsvc, ERR_MRK"doIstep: Istep failed, plid 0x%x", err->plid()); - - // istep fails, sync attributes to FSP - if( INITSERVICE::spBaseServicesEnabled() ) - { - TRACFCOMP(g_trac_initsvc, ERR_MRK"doIstep, Sync attributes to FSP"); - errlHndl_t l_errl = TARGETING::syncAllAttributesToFsp(); - - if(l_errl) - { - TRACFCOMP(g_trac_initsvc, ERR_MRK"doIstep: Attribute syncing" - " failed see 0x%08X for details", l_errl->eid()); - l_errl->setSev(ERRORLOG::ERRL_SEV_INFORMATIONAL); - errlCommit(l_errl, INITSVC_COMP_ID); - } - } } // Check for any attentions and invoke PRD for analysis -- cgit v1.2.1