diff options
| author | Andre Marin <aamarin@us.ibm.com> | 2018-12-12 14:51:15 -0600 |
|---|---|---|
| committer | Daniel M. Crowell <dcrowell@us.ibm.com> | 2019-02-05 17:01:27 -0600 |
| commit | bd7d0b7b5d90275064bdb3ca6a5cd1e36f37bcf7 (patch) | |
| tree | 71f22570545632fc1be38a817e443f6926bc033a /src/import/generic/memory/lib/utils | |
| parent | 605baad67443c4c282d322115e4d5edbaf118d3a (diff) | |
| download | talos-hostboot-bd7d0b7b5d90275064bdb3ca6a5cd1e36f37bcf7.tar.gz talos-hostboot-bd7d0b7b5d90275064bdb3ca6a5cd1e36f37bcf7.zip | |
Add SPD DDIMM DDR4 module except for PMIC fields
Change-Id: Ib5268d2bc425733d30fbca98eaeb8d4a62a918a2
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/69838
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Dev-Ready: STEPHEN GLANCY <sglancy@us.ibm.com>
Reviewed-by: Louis Stermole <stermole@us.ibm.com>
Reviewed-by: ANDRE A. MARIN <aamarin@us.ibm.com>
Tested-by: HWSV CI <hwsv-ci+hostboot@us.ibm.com>
Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com>
Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com>
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/70746
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
Tested-by: Daniel M. Crowell <dcrowell@us.ibm.com>
Diffstat (limited to 'src/import/generic/memory/lib/utils')
| -rw-r--r-- | src/import/generic/memory/lib/utils/mss_field.H | 3 | ||||
| -rw-r--r-- | src/import/generic/memory/lib/utils/shared/mss_generic_consts.H | 7 |
2 files changed, 10 insertions, 0 deletions
diff --git a/src/import/generic/memory/lib/utils/mss_field.H b/src/import/generic/memory/lib/utils/mss_field.H index 44afb1e59..e22b2fa47 100644 --- a/src/import/generic/memory/lib/utils/mss_field.H +++ b/src/import/generic/memory/lib/utils/mss_field.H @@ -179,6 +179,9 @@ inline fapi2::ReturnCode get_field(const fapi2::Target<T>& i_target, const FFDC i_ffdc_codes, OT& o_value) { + // Initializes the output value to 0, that way, we won't have any stale data in o_value + o_value = 0; + const size_t BYTE = F.get_byte(i_data); FAPI_ASSERT( BYTE < i_data.size(), diff --git a/src/import/generic/memory/lib/utils/shared/mss_generic_consts.H b/src/import/generic/memory/lib/utils/shared/mss_generic_consts.H index c9049b7f6..d017933bb 100644 --- a/src/import/generic/memory/lib/utils/shared/mss_generic_consts.H +++ b/src/import/generic/memory/lib/utils/shared/mss_generic_consts.H @@ -136,6 +136,9 @@ enum generic_ffdc_codes SET_HYBRID_MEDIA = 0x1028, SET_MRANKS = 0x1029, SET_DIMM_RANKS_CNFG = 0x1039, + + // SPD fields function codes + DDIMM_RAWCARD_DECODE = 0x103a, }; /// @@ -193,6 +196,7 @@ namespace spd /// enum rev : uint8_t { + V0_0 = 0x00, ///< represents Rev 0.0 V1_0 = 0x10, ///< represents Rev 1.0 V1_1 = 0x11, ///< represents Rev 1.1 V1_2 = 0x12, ///< represents Rev 1.2 @@ -202,6 +206,7 @@ enum rev : uint8_t GEN_SEC_MAX = V1_1, RDIMM_MAX = V1_1, LRDIMM_MAX = V1_2, + DDIMM_MAX = V1_0, }; /// @@ -215,6 +220,7 @@ enum parameters RDIMM_MODULE, LRDIMM_MODULE, NVDIMM_MODULE, + DDIMM_MODULE, }; /// @@ -234,6 +240,7 @@ enum dimm_type { RDIMM = 0b0001, LRDIMM = 0b0100, + DDIMM = 0b1010, }; enum guard_band : uint16_t |
