diff options
| author | Jacob Harvey <jlharvey@us.ibm.com> | 2017-01-06 17:21:07 -0600 |
|---|---|---|
| committer | Daniel M. Crowell <dcrowell@us.ibm.com> | 2017-01-12 13:00:46 -0500 |
| commit | 10faa36e818d33bb645c57d16cdc8f01e63b18fe (patch) | |
| tree | 34e4fa2210d93e13d20c15e1487d35e5be1186a7 /src/import/chips/p9/procedures/hwp/memory/lib/utils | |
| parent | c0fcb6dca1133c19fd733a2c418102488319e2c4 (diff) | |
| download | talos-hostboot-10faa36e818d33bb645c57d16cdc8f01e63b18fe.tar.gz talos-hostboot-10faa36e818d33bb645c57d16cdc8f01e63b18fe.zip | |
Fix fapi2::current_err bug in checker.H
FAPI_ASSERT does not set current error
Also fixed some of the LRDIMM decoder
The decoder didn't match up with the Revs
Change-Id: If7125e9fb0b21d09ccefaf9aa9ec0e2fb4cd7cd5
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/34528
Reviewed-by: Brian R. Silver <bsilver@us.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Reviewed-by: ANDRE A. MARIN <aamarin@us.ibm.com>
Reviewed-by: Louis Stermole <stermole@us.ibm.com>
Reviewed-by: STEPHEN GLANCY <sglancy@us.ibm.com>
Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com>
Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com>
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/34591
Reviewed-by: Hostboot Team <hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
Diffstat (limited to 'src/import/chips/p9/procedures/hwp/memory/lib/utils')
| -rw-r--r-- | src/import/chips/p9/procedures/hwp/memory/lib/utils/checker.H | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/src/import/chips/p9/procedures/hwp/memory/lib/utils/checker.H b/src/import/chips/p9/procedures/hwp/memory/lib/utils/checker.H index b679aace0..6d111e4d0 100644 --- a/src/import/chips/p9/procedures/hwp/memory/lib/utils/checker.H +++ b/src/import/chips/p9/procedures/hwp/memory/lib/utils/checker.H @@ -95,7 +95,7 @@ fapi_try_exit: /// /// @brief Checks homogenous DDR4 dimm configuration (e.g. DDR4) /// @param[in] i_target the controller target -/// @return FAPI2_RC_SUCCESS iff ok +/// @return fapi2::FAPI2_RC_SUCCESS iff ok /// inline fapi2::ReturnCode dram_type(const fapi2::Target<fapi2::TARGET_TYPE_MCS>& i_target) { @@ -159,6 +159,7 @@ inline fapi2::ReturnCode fail_for_invalid_map(const fapi2::Target<fapi2::TARGET_ i_key, i_data); + return fapi2::FAPI2_RC_SUCCESS; fapi_try_exit: return fapi2::current_err; } @@ -194,6 +195,7 @@ inline fapi2::ReturnCode fail_for_invalid_value(const fapi2::Target<fapi2::TARGE i_spd_byte_index, i_spd_data); + return fapi2::FAPI2_RC_SUCCESS; fapi_try_exit: return fapi2::current_err; @@ -254,6 +256,7 @@ inline fapi2::ReturnCode invalid_factory_sel(const fapi2::Target<fapi2::TARGET_T i_dimm_type, i_encoding_rev, i_additions_rev); + return fapi2::FAPI2_RC_SUCCESS; fapi_try_exit: return fapi2::current_err; }// invalid_factory_sel @@ -279,6 +282,7 @@ inline fapi2::ReturnCode invalid_cache(const fapi2::Target<fapi2::TARGET_TYPE_DI c_str(i_target), i_dimm_pos); + return fapi2::FAPI2_RC_SUCCESS; fapi_try_exit: return fapi2::current_err; }// invalid_factory_sel |
