diff options
author | Yue Du <daviddu@us.ibm.com> | 2017-01-11 23:37:55 -0600 |
---|---|---|
committer | Joshua Hunsberger <jahunsbe@us.ibm.com> | 2017-10-23 17:07:15 -0500 |
commit | db3fc618046c94c8df3dfc66ac883a3be8151eb4 (patch) | |
tree | 7d623a4b440cc5f41b64d242eaa41d0643d366d1 /import/chips/p9/procedures/ppe_closed/cme/stop_cme/p9_cme_stop_irq_handlers.c | |
parent | 3df424c99c4a9a7c7b9e1e02a5a799256f23a3b6 (diff) | |
download | talos-hcode-db3fc618046c94c8df3dfc66ac883a3be8151eb4.tar.gz talos-hcode-db3fc618046c94c8df3dfc66ac883a3be8151eb4.zip |
STOP: optimize size of stop images
1) optimize scom with no rc and directly inline asm(saved for 2K :D)
2) initialize all variables(doesnt really save size, just good guideline)
3) loop both cores when block is big and redundant(saved only 50B -_-)
(50b for 3 blocks, each block saves 17b, or 4 instructions)
4) improvement on history update(saved 500B more :))
5) functionalize the exit catchup routine which is identical twice
(this back fired and cost us 100B :()
6) functionalize the eval eimr override macro which is identical twice
(saved 130B :|)
7) finally the saving is about 2728B on CME
8) apply history update tech to sgpe, found bug in the tech, fixed
(but our saving is back to ~2500B)
9) clean up sgpe redundent ex branching code
(same as cme saved only about ~60B)
10) rebase
Change-Id: I3664d6a2dcab85f896a583852afde948e635bd02
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/34777
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: PPE CI <ppe-ci+hostboot@us.ibm.com>
Reviewed-by: AMIT KUMAR <akumar3@us.ibm.com>
Reviewed-by: Gregory S. Still <stillgs@us.ibm.com>
Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com>
Diffstat (limited to 'import/chips/p9/procedures/ppe_closed/cme/stop_cme/p9_cme_stop_irq_handlers.c')
-rw-r--r-- | import/chips/p9/procedures/ppe_closed/cme/stop_cme/p9_cme_stop_irq_handlers.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/import/chips/p9/procedures/ppe_closed/cme/stop_cme/p9_cme_stop_irq_handlers.c b/import/chips/p9/procedures/ppe_closed/cme/stop_cme/p9_cme_stop_irq_handlers.c index 9c9c7294..e8345e92 100644 --- a/import/chips/p9/procedures/ppe_closed/cme/stop_cme/p9_cme_stop_irq_handlers.c +++ b/import/chips/p9/procedures/ppe_closed/cme/stop_cme/p9_cme_stop_irq_handlers.c @@ -47,7 +47,7 @@ p9_cme_stop_spwu_handler(void* arg, PkIrqId irq) PkMachineContext ctx; int sem_post = 0; uint32_t raw_spwu = (in32(CME_LCL_EISR) & BITS32(14, 2)) >> SHIFT32(15); - uint64_t scom_data; + uint64_t scom_data = 0; if (raw_spwu & CME_MASK_C0) { @@ -190,7 +190,8 @@ void p9_cme_stop_db2_handler(void* arg, PkIrqId irq) { PkMachineContext ctx; - cppm_cmedb2_t db2c0, db2c1; + cppm_cmedb2_t db2c0 = {0}; + cppm_cmedb2_t db2c1 = {0}; MARK_TRAP(STOP_DB2_HANDLER) PK_TRACE_INF("DB2 Handler"); |