summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorsayle <sayle@138bc75d-0d04-0410-961f-82ee72b054a4>2006-04-06 16:47:40 +0000
committersayle <sayle@138bc75d-0d04-0410-961f-82ee72b054a4>2006-04-06 16:47:40 +0000
commitea9557c6c9cdc849864f0abc25e20b2a0e49e8dc (patch)
treefd7a3c08d7f0205a9ddb7c18a52a076dcc41e6f4
parent3f4feb44c143eefd987a2c0dffb10c7be75c691a (diff)
downloadppe42-gcc-ea9557c6c9cdc849864f0abc25e20b2a0e49e8dc.tar.gz
ppe42-gcc-ea9557c6c9cdc849864f0abc25e20b2a0e49e8dc.zip
* call.c (null_ptr_cst_p): Add explicit TREE_CONSTANT_OVERFLOW check.
* g++.dg/conversion/nullptr1.C: New test case. * g++.dg/conversion/nullptr2.C: Likewise. git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@112734 138bc75d-0d04-0410-961f-82ee72b054a4
-rw-r--r--gcc/cp/ChangeLog4
-rw-r--r--gcc/cp/call.c4
-rw-r--r--gcc/testsuite/ChangeLog5
-rw-r--r--gcc/testsuite/g++.dg/conversion/nullptr1.C10
-rw-r--r--gcc/testsuite/g++.dg/conversion/nullptr2.C10
5 files changed, 32 insertions, 1 deletions
diff --git a/gcc/cp/ChangeLog b/gcc/cp/ChangeLog
index 96191a2bb7f..266e3476260 100644
--- a/gcc/cp/ChangeLog
+++ b/gcc/cp/ChangeLog
@@ -1,3 +1,7 @@
+2006-04-06 Roger Sayle <roger@eyesopen.com>
+
+ * call.c (null_ptr_cst_p): Add explicit TREE_CONSTANT_OVERFLOW check.
+
2006-04-05 Jason Merrill <jason@redhat.com>
* name-lookup.c (push_namespace_with_attribs): Temporarily disable
diff --git a/gcc/cp/call.c b/gcc/cp/call.c
index 268573d5bc0..0413a9885dd 100644
--- a/gcc/cp/call.c
+++ b/gcc/cp/call.c
@@ -427,7 +427,9 @@ null_ptr_cst_p (tree t)
(_expr.const_) rvalue of integer type that evaluates to zero. */
t = integral_constant_value (t);
if (t == null_node
- || (CP_INTEGRAL_TYPE_P (TREE_TYPE (t)) && integer_zerop (t)))
+ || (CP_INTEGRAL_TYPE_P (TREE_TYPE (t))
+ && integer_zerop (t)
+ && !TREE_CONSTANT_OVERFLOW (t)))
return true;
return false;
}
diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index a9fa5b057d3..814f9576627 100644
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2006-04-06 Roger Sayle <roger@eyesopen.com>
+
+ * g++.dg/conversion/nullptr1.C: New test case.
+ * g++.dg/conversion/nullptr2.C: Likewise.
+
2006-04-05 Roger Sayle <roger@eyesopen.com>
* gfortran.dg/dependency_18.f90: New test case.
diff --git a/gcc/testsuite/g++.dg/conversion/nullptr1.C b/gcc/testsuite/g++.dg/conversion/nullptr1.C
new file mode 100644
index 00000000000..6230a2999ef
--- /dev/null
+++ b/gcc/testsuite/g++.dg/conversion/nullptr1.C
@@ -0,0 +1,10 @@
+/* Test for overflow in NULL pointer constant. */
+/* { dg-do compile } */
+
+#include <limits.h>
+
+void *p = 0;
+
+void *q = 0 * (INT_MAX + 1); // { dg-error "invalid conversion" }
+
+
diff --git a/gcc/testsuite/g++.dg/conversion/nullptr2.C b/gcc/testsuite/g++.dg/conversion/nullptr2.C
new file mode 100644
index 00000000000..74ceff49dba
--- /dev/null
+++ b/gcc/testsuite/g++.dg/conversion/nullptr2.C
@@ -0,0 +1,10 @@
+/* Test for enumeration as NULL pointer constant. */
+/* PR c++/14644 */
+/* { dg-do compile } */
+
+enum { NULL = 0 };
+
+void *p = 0;
+
+void *q = NULL; // { dg-error "cannot convert" }
+
OpenPOWER on IntegriCloud