| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently we don't protect against forwarding to remote
url, so things like:
https://<bmc-address>/#/login?next=http:%2F%2Fyahoo.com
can be used to forward an unsuspecting user to a different
url. This fixes that issue.
Tested: Local redirects still work, above link does not
Closes #109
Change-Id: I4d6c52880156802860f405af43037fb84235912f
Signed-off-by: James Feist <james.feist@linux.intel.com>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Respose for invalid credentials changed and login page
was no longer displaying the correct error message to
the user when invalid credentials were entered.
Resolves openbmc/phosphor-webui#72
Tested: Logged in with incorrect credentials and saw the
correct message. Also logged in with an unreachable
host and saw that that message was displaying
correctly.
Change-Id: I65cc6d6a061986568aded09555c5f75bcd59fe56
Signed-off-by: beccabroek <beccabroek@gmail.com>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Using ngMessages, adds form validation to login page. Also creates a
directive, hasError, to be used to validate form field by passing
in a boolean. This is a proposed pattern to be used moving forward,
as form validation is added to additional pages.
Validation error messages are shown on $touched and on submit.
Unreachable Server and Invalid username and password error messages
remain until input is no longer $pristine after form submission.
In addition, this removes unneeded and unused css styling
Resolves openbmc/phosphor-webui#47
Change-Id: I7a067af67ac74d4cf2977d10f66445720ecae9eb
Signed-off-by: beccabroek <beccabroek@gmail.com>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
When redirecting a user to a login url, it is helpful to be able to
point them to a url that after login, will forward to the requested
page.
This is accomplished by the use of a url param named "next" which
specifies the URL that the user wants to be redirected to after login.
If no next url is specified, the user is redirected to the overview
page, like the vehavior before.
Change-Id: Iff0da65632119a8f7ae3f35eb74147ca67563f30
Signed-off-by: Ed Tanous <ed.tanous@intel.com>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If the error is 'Invalid username or password', the 'Username'
and 'Password' fields now becomes red.
On any other error (e.g. Server unreachable) the
'BMC Host or BMC IP Address' field is red.
Before the 'BMC Host or BMC IP Address' and 'Username'
were red on all errors.
Resolves openbmc/phosphor-webui#17
Tested: See correct fields highlighted.
Change-Id: I55514cfb428170cd125ec01eb4c7184fbadd3894
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
| |
|
|
|
|
|
| |
keyCode 13 is the 'Enter' button.
Change-Id: I49d6fc00b8e009835b93ed1f62f7f22be083216e
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
| |
|
|
|
|
|
| |
Tested: Able to login
Change-Id: I50e459b5b3f35e731649377665449123d4934709
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
| |
|
|
|
|
| |
Tested: Able to login
Change-Id: Id87900c160781edf4cb473d32f7d7fa3112c6dd7
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
| |
|
|
|
|
|
| |
The docker image moved from clang-format-5.0 to clang-format-6.0.
Change-Id: I3c615d7df1f21569531b4dc2cb0bc4f425cb43f8
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
| |
|
|
|
|
|
|
| |
Once merged, this repository will have CI enforce
the coding guidelines in the .clang-format file.
Change-Id: I96a05972665f9c67625c6850c3da25edc540be06
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
|
| |
|
|
|
|
|
|
|
|
|
| |
Found this pointer on stackoverflow:
https://stackoverflow.com/a/31660434/5508494
End goal is to get the code formatted well enough that
clang format will run correctly against it.
Change-Id: I80053e78d253d8eee49233e42d55e5807ae8fdc8
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
|
| |
|
|
|
|
|
|
| |
Already have a Web UI version, no need to track the version
of each file. These have not been getting updated.
Change-Id: I1cd3a2c2d67b24ded5edcca9dbfd3f6806d93ed4
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
| |
|
|
|
|
|
|
|
|
|
|
| |
When an error occurs during authorization, display the error message
received from server side instead hardcoded message.
Partially resolves openbmc/openbmc#2974
Resolves openbmc/openbmc#3024
Tested: Enter invalid username or password and verify error message
Change-Id: I91ca29d5a69e12e12ce490ce3206173de7d41f09
Signed-off-by: Alexander Filippov <a.filippov@yadro.com>
|
| |
|
|
|
|
|
|
|
| |
We had a script that allowed users to bypass login to see the app
interface. We did this for testing purpose. This commit removes that
functionality and improves security.
Change-Id: I17255f16082d5460015788130f2482f2849ce975
Signed-off-by: Iftekharul Islam <iffy.ryan@ibm.com>
|
| |
|
|
|
|
| |
Tested: Manually tested GUI for any regressions
Change-Id: I8c0922b7bd67b03b07e8880bc4dba3b862220b33
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
| |
|
|
|
|
|
| |
Updated login structure with a field where user can manually add server hostname if it is not populated automatically
Change-Id: I147c2c15869131540e327bda26c05b59d78e01d5
Signed-off-by: Iftekharul Islam <iffy.ryan@ibm.com>
|
| |
|
|
|
| |
Change-Id: Iae10d39428b6ce6a228e775aa68fb7805dd61ecb
Signed-off-by: Iftekharul Islam <iffy.ryan@ibm.com>
|
| |
|
|
|
| |
Change-Id: Icf3e447a21d0f9232ba80ed1969101218552d439
Signed-off-by: Michael Davis <michael.s.davis@ibm.com>
|
| |
|
|
|
| |
Change-Id: I99435613bb77fc0ff72f046c2dc047b13962a7a3
Signed-off-by: Iftekharul Islam <iislam@us.ibm.com>
|
| |
|
|
|
| |
Change-Id: I12c819293ce1eda188dc9f257ae9370f1b73cb18
Signed-off-by: Iftekharul Islam <iislam@us.ibm.com>
|
| |
|
|
|
| |
Change-Id: Ife37444dcede67b54d1f257ee99322b22ac6b78c
Signed-off-by: Iftekharul Islam <iislam@us.ibm.com>
|
|
|
* Split files into independent files based on functionality.
* Switch to bower/gulp for build.
Change-Id: Ibc775dd9b7f6a0a49f63c22162b7582e781e2d9c
Signed-off-by: Iftekharul Islam <iislam@us.ibm.com>
|
