summaryrefslogtreecommitdiffstats
path: root/app/login
Commit message (Collapse)AuthorAgeFilesLines
* Block forwarding to non-local urlJames Feist2020-02-111-1/+3
| | | | | | | | | | | | | | | | | Currently we don't protect against forwarding to remote url, so things like: https://<bmc-address>/#/login?next=http:%2F%2Fyahoo.com can be used to forward an unsuspecting user to a different url. This fixes that issue. Tested: Local redirects still work, above link does not Closes #109 Change-Id: I4d6c52880156802860f405af43037fb84235912f Signed-off-by: James Feist <james.feist@linux.intel.com>
* Clean up color valuesYoshie Muranaka2019-07-091-6/+6
| | | | | | | | | | | | | This update will clean up slight color variations in the code base by creating and using Sass color variables instead of hex values. Available colors are defined in colors.scss. Any usage of CSS color properties should refer to the mapped color variables in colors.scss. - Removed tags.scss file since tag components no longer used Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com> Change-Id: I045030a158469e59d07a9fa8cd8aa9f125f0d383
* Consolidate button stylesYoshie Muranaka2019-06-211-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | This patchset will create consistent button styling according to the styleguide and remove redundant button styles by creating reusable button classes. This patchset also implements a consistent strategy for including icon assets. Currently, svg icons are imported as CSS background images or inlined into the markup. Inlining an svg is preferred, especially when used with buttons or links so the colors can be easily changed for different states (hover, focus, disabled) without having to request variants. The icon provider allows us to inline svgs without cluttering the markup. Webpack config was adjusted to use svg-inline-loader when resolving svgs that are used by the icon provider directive. - All svgs were optimized to remove unncessary information. - Removed unused svg color variants - Moved icons used by icon provider to separate directory to avoid Webpack parsing the files twice - Small changes to navigation icons Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com> Change-Id: I1ca214b74fc502e6b6e760cfee88b48110237c43
* Add .ng-leave and .ng-enter rulesets for page transitionDerick Montague2019-05-291-3/+9
| | | | | | | | | | | | | | | Adding ngAnimation dependency created added animation to pages during route or location changes. Added transitions to create an elegant transition. Tested: I navigated to every page including logging in and out in Chrome, Firefox and Safari to assure all browsers handle the transition consistently. Resolves openbmc/phosphor-webui#86 Signed-off-by: Derick Montague <derick.montague@ibm.com> Change-Id: I14fa1bd790e80f977b7a0ccceccc3eb20ce33ae6
* Fix login error messagebeccabroek2019-03-271-1/+1
| | | | | | | | | | | | | | | | Respose for invalid credentials changed and login page was no longer displaying the correct error message to the user when invalid credentials were entered. Resolves openbmc/phosphor-webui#72 Tested: Logged in with incorrect credentials and saw the correct message. Also logged in with an unreachable host and saw that that message was displaying correctly. Change-Id: I65cc6d6a061986568aded09555c5f75bcd59fe56 Signed-off-by: beccabroek <beccabroek@gmail.com>
* Form validation on login pagebeccabroek2019-02-023-22/+33
| | | | | | | | | | | | | | | | | | Using ngMessages, adds form validation to login page. Also creates a directive, hasError, to be used to validate form field by passing in a boolean. This is a proposed pattern to be used moving forward, as form validation is added to additional pages. Validation error messages are shown on $touched and on submit. Unreachable Server and Invalid username and password error messages remain until input is no longer $pristine after form submission. In addition, this removes unneeded and unused css styling Resolves openbmc/phosphor-webui#47 Change-Id: I7a067af67ac74d4cf2977d10f66445720ecae9eb Signed-off-by: beccabroek <beccabroek@gmail.com>
* Fix issue for responsive design: Login screenRyan Arnell2019-01-292-26/+14
| | | | | | | | | | This push fixes the issue of the logo and input alignment in login screen on tablets portrait and landscape mode. They are centrally aligned in these views. Gets rid of the unwanted horizontal scrollbar in tablets. Change-Id: I31fd9caa881e0ffb6b1cd58701d911ee916dd419 Signed-off-by: Ryan Arnell <iffy.ryan@ibm.com>
* phosphor-webui: Allow after login redirectsEd Tanous2018-11-191-4/+13
| | | | | | | | | | | | | | When redirecting a user to a login url, it is helpful to be able to point them to a url that after login, will forward to the requested page. This is accomplished by the use of a url param named "next" which specifies the URL that the user wants to be redirected to after login. If no next url is specified, the user is redirected to the overview page, like the vehavior before. Change-Id: Iff0da65632119a8f7ae3f35eb74147ca67563f30 Signed-off-by: Ed Tanous <ed.tanous@intel.com>
* login-controller.html: Fix indentsGunnar Mills2018-10-091-21/+21
| | | | | Change-Id: Ie6867b29eb7e785ad48c918d605ccfff955e3102 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Do not autocomplete username and passwordGunnar Mills2018-09-251-2/+2
| | | | | | | | | | | Security scanners list autocomplete on as a medium priority issue. The concern being someone could use it to compromise a bmc with a password saved on a compromised computer. Resolves openbmc/phosphor-webui#18 Change-Id: Ie6936d84a0b94a81781a077d1542a6ce1d413d6d Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Highlight correct fields on errorsGunnar Mills2018-09-122-4/+4
| | | | | | | | | | | | | | | | If the error is 'Invalid username or password', the 'Username' and 'Password' fields now becomes red. On any other error (e.g. Server unreachable) the 'BMC Host or BMC IP Address' field is red. Before the 'BMC Host or BMC IP Address' and 'Username' were red on all errors. Resolves openbmc/phosphor-webui#17 Tested: See correct fields highlighted. Change-Id: I55514cfb428170cd125ec01eb4c7184fbadd3894 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Add comment for keyCode 13Gunnar Mills2018-09-121-0/+2
| | | | | | | keyCode 13 is the 'Enter' button. Change-Id: I49d6fc00b8e009835b93ed1f62f7f22be083216e Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Login: Remove unused APIUtilsGunnar Mills2018-09-121-2/+2
| | | | | | | Tested: Able to login Change-Id: I50e459b5b3f35e731649377665449123d4934709 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Login: Remove unused routeParamsGunnar Mills2018-09-121-2/+2
| | | | | | Tested: Able to login Change-Id: Id87900c160781edf4cb473d32f7d7fa3112c6dd7 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Move to clang-format-6.0Gunnar Mills2018-09-042-2/+0
| | | | | | | The docker image moved from clang-format-5.0 to clang-format-6.0. Change-Id: I3c615d7df1f21569531b4dc2cb0bc4f425cb43f8 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Remove unused app/constants/ dirGunnar Mills2018-07-111-1/+1
| | | | | | | | | | | | | All the constants are defined here: https://github.com/openbmc/phosphor-webui/blob/master/app/common/services/constants.js Constants are injected as part of app.common.services. This environment-constants.js or environment-constants.json could be repurposed to configure features but going with something else, https://gerrit.openbmc-project.xyz/#/c/11311/. Tested: Quick manual regression test on the pages. Change-Id: I59ba4f47fe8a927cb5f68a2657dfea9c61cd5f28 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Format code using clang-format-5.0Andrew Geissler2018-05-242-57/+44
| | | | | | | | Once merged, this repository will have CI enforce the coding guidelines in the .clang-format file. Change-Id: I96a05972665f9c67625c6850c3da25edc540be06 Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
* Run js-beautify and fixjsstyle on codeAndrew Geissler2018-05-242-61/+62
| | | | | | | | | | | Found this pointer on stackoverflow: https://stackoverflow.com/a/31660434/5508494 End goal is to get the code formatted well enough that clang format will run correctly against it. Change-Id: I80053e78d253d8eee49233e42d55e5807ae8fdc8 Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
* Rename BMC Host/IP field on loginGunnar Mills2018-05-181-1/+1
| | | | | | | | | | | | | Renamed the BMC Host/BMC IP Address field: "BMC Host or BMC IP Address". Like Password and Username, this is displayed as all caps. We got feedback that "Host" could mean a lot of things and should specify this is the BMC. Closes openbmc/openbmc#3147 Change-Id: If8b4e7b8a8bf912631fb39cc271ee87ce38c470d Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Remove the version from each fileGunnar Mills2018-04-302-2/+0
| | | | | | | | Already have a Web UI version, no need to track the version of each file. These have not been getting updated. Change-Id: I1cd3a2c2d67b24ded5edcca9dbfd3f6806d93ed4 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Move login error to common error styleGunnar Mills2018-04-092-11/+2
| | | | | | | | Created a generic error class, have the login error inherit it. Tested: Verified the login error looks the same. Change-Id: Ief373fa37ea655cfcb544861a4e540abbe65f77e Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Show error message received from server sideAlexander Filippov2018-03-272-8/+6
| | | | | | | | | | | | When an error occurs during authorization, display the error message received from server side instead hardcoded message. Partially resolves openbmc/openbmc#2974 Resolves openbmc/openbmc#3024 Tested: Enter invalid username or password and verify error message Change-Id: I91ca29d5a69e12e12ce490ce3206173de7d41f09 Signed-off-by: Alexander Filippov <a.filippov@yadro.com>
* Removed bypass login scriptIftekharul Islam2018-03-072-11/+0
| | | | | | | | | We had a script that allowed users to bypass login to see the app interface. We did this for testing purpose. This commit removes that functionality and improves security. Change-Id: I17255f16082d5460015788130f2482f2849ce975 Signed-off-by: Iftekharul Islam <iffy.ryan@ibm.com>
* Remove trailing spaces from filesGunnar Mills2018-03-051-5/+5
| | | | | | Tested: Manually tested GUI for any regressions Change-Id: I8c0922b7bd67b03b07e8880bc4dba3b862220b33 Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
* Remove reference to IBM in phosphor-webuiEd Tanous2017-11-071-3/+3
| | | | | | | | | | | | | | | | As phosphor webui is supposed to be the reference implementation, it should not reference IBM, nor have IBM copywritten logos contained within it. If these are neccesary for IBM platforms, they should be done in a bbappend in the bitbake layer, or in a way that doesn't put copywritten materials on BMCs that may not have permission to use and release it. I'm hoping to generate ddiscussion on how the best way to handle this from a build perspective would be, but for now, references should be to the OpenBmc project, not IBM to avoid copyright issues. Change-Id: I73efda399e967ca4446b8df403e94e14ab24aff8 Signed-off-by: Ed Tanous <ed.tanous@intel.com>
* Modernize web GUI and make it installable on BMCEd Tanous2017-11-062-3/+3
| | | | | | | | | | | | | | | | | | | 1. Move from gulp server to webpack. This allows the proper compression to allow the webui to be embedded in the BMC. 2. Update js paths to use requires, not hardcoded paths. This was required to make the packaging work correctly. 3. Add babel config to do translation. 4. Update angularjs directive calls to use the angular 1.6 syntax for promises intead of success and fail. https://docs.angularjs.org/guide/migration#migrate1.5to1.6-ng-services-$http 5. As a consequence of using NPM/webpack, the versions of angular and associated modules that were checked in have been updated. Change-Id: Icb71e2eedb0d9a8943fc914f9dc4be11d0983c00 Signed-off-by: Ed Tanous <ed.tanous@intel.com> Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
* Updating login structureIftekharul Islam2017-11-022-14/+14
| | | | | | | Updated login structure with a field where user can manually add server hostname if it is not populated automatically Change-Id: I147c2c15869131540e327bda26c05b59d78e01d5 Signed-off-by: Iftekharul Islam <iffy.ryan@ibm.com>
* Updating images and stlesIftekharul Islam2017-11-021-3/+0
| | | | | | | Updating images and styles after code merge conflicts Change-Id: I96490926caa41d13e4d625ff67f6a463d7819d34 Signed-off-by: Iftekharul Islam <iffy.ryan@ibm.com>
* fix icon alignmentsMichael Davis2017-10-091-0/+3
| | | | | Change-Id: Id4a783d23e18be74048540310523079ec5613e8e Signed-off-by: Michael Davis <michael.s.davis@ibm.com>
* changed to Courier New font per visual designer requestMichael Davis2017-10-091-2/+2
| | | | | Change-Id: I54464dc078760402ed553b593c5859e1ca22c864 Signed-off-by: Michael Davis <michael.s.davis@ibm.com>
* Updating firmware update pages functionalityIftekharul Islam2017-10-091-1/+1
| | | | | Change-Id: Ie82640d47108e8367409d669a7ea72d38598443f Signed-off-by: Iftekharul Islam <iffy.ryan@ibm.com>
* Updating server health icon in header based on event log statusIftekharul Islam2017-10-091-3/+6
| | | | | Change-Id: Iae10d39428b6ce6a228e775aa68fb7805dd61ecb Signed-off-by: Iftekharul Islam <iffy.ryan@ibm.com>
* Changed from overview/system to overview/server to match site IAMichael Davis2017-10-091-2/+2
| | | | | Change-Id: Icf3e447a21d0f9232ba80ed1969101218552d439 Signed-off-by: Michael Davis <michael.s.davis@ibm.com>
* darkened label borders to match designMichael Davis2017-10-091-1/+1
| | | | | Change-Id: Ib6c5089644a4cf7b56cd5e09934e34f60c2532cc Signed-off-by: Michael Davis <michael.s.davis@ibm.com>
* Changed title and info labels copy. Based on design changes and user feedback.Michael Davis2017-10-091-4/+3
| | | | | Change-Id: Id546bf09b6790d5f12212493c215bf03e11cde15 Signed-off-by: Michael Davis <michael.s.davis@ibm.com>
* Added hardware sensors functionalityIftekharul Islam2017-09-202-7/+4
| | | | | Change-Id: I99435613bb77fc0ff72f046c2dc047b13962a7a3 Signed-off-by: Iftekharul Islam <iislam@us.ibm.com>
* Minor usability fixesIftekharul Islam2017-09-201-2/+2
| | | | | | | | - Set default focus to 'username' field on login. - Add default sorting of event logs. Change-Id: I677cc12a41313e14cd22c3128240d271dfc7796f Signed-off-by: Iftekharul Islam <iislam@us.ibm.com>
* Misc fixes for event log.Michael Davis2017-09-201-0/+6
| | | | | | | | | | | - Fixed single event log overflow. - Fixed incorrect class on log search filter button. - Fixed incorrect nested div. - Removed duplicate accordion trigger class in event log. - Fixed hover for checkboxes to be more prominent. - Fixed margin issue with action header for event log. Change-Id: I156f516316675afde98c233057a8247bc17a1459
* Misc CSS fixesMichael Davis2017-09-201-1/+1
| | | | | | | | | | | | | | | * set max content width to 960px * created mixin for bold font * move app-header content to global header * minor global changes * changed input alignment for network config inputs * added pop-out button class * changed lightgrey color * fixed accordion header actions responsiveness * fixed input box border colors Change-Id: Iffe26d526439d7f2bb6808528a975ab7374ff1b2 Signed-off-by: Michael Davis <michael.s.davis@ibm.com>
* Change navigation structureIftekharul Islam2017-09-202-6/+9
| | | | | Change-Id: I12c819293ce1eda188dc9f257ae9370f1b73cb18 Signed-off-by: Iftekharul Islam <iislam@us.ibm.com>
* Added fake login page for testing and demoIftekharul Islam2017-09-202-2/+14
| | | | | Change-Id: Ife37444dcede67b54d1f257ee99322b22ac6b78c Signed-off-by: Iftekharul Islam <iislam@us.ibm.com>
* Major update to code structureIftekharul Islam2017-09-204-0/+231
* Split files into independent files based on functionality. * Switch to bower/gulp for build. Change-Id: Ibc775dd9b7f6a0a49f63c22162b7582e781e2d9c Signed-off-by: Iftekharul Islam <iislam@us.ibm.com>
OpenPOWER on IntegriCloud