summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorNagaraju Goruganti <ngorugan@in.ibm.com>2018-11-08 03:07:25 -0600
committerBrad Bishop <bradleyb@fuzziesquirrel.com>2018-11-19 21:37:57 -0500
commitd514e5dc3de8dcd305328783ae11ee8e56b27d9a (patch)
tree5b19fa0d8f6a34ded5cfa5576b3f27dba84dd687
parent3e7a72eaaca9819f28e48fbf676bf67eb408287d (diff)
downloadphosphor-user-manager-d514e5dc3de8dcd305328783ae11ee8e56b27d9a.zip
phosphor-user-manager-d514e5dc3de8dcd305328783ae11ee8e56b27d9a.tar.gz
phosphor-ldap-conf: add unit tests
Added uinit tests to create and to restore config file. Change-Id: Idf5231d46542cda1ff84241aa67aadd91a4788d6 Signed-off-by: Nagaraju Goruganti <ngorugan@in.ibm.com> Signed-off-by: Deepak Kodihalli <dkodihal@in.ibm.com> Signed-off-by: Nagaraju Goruganti <ngorugan@in.ibm.com>
-rw-r--r--.gitignore8
-rw-r--r--Makefile.am2
-rw-r--r--configure.ac4
-rw-r--r--phosphor-ldap-config/ldap_configuration.cpp19
-rw-r--r--phosphor-ldap-config/ldap_configuration.hpp21
-rw-r--r--phosphor-ldap-config/main.cpp11
-rw-r--r--test/Makefile.am9
-rw-r--r--test/ldap_config_test.cpp335
-rw-r--r--test/utils_test.cpp67
9 files changed, 458 insertions, 18 deletions
diff --git a/.gitignore b/.gitignore
index 961e9b3..cc2c852 100644
--- a/.gitignore
+++ b/.gitignore
@@ -47,3 +47,11 @@ Makefile
/*-libtool
.project
/phosphor-ldap-mapper/phosphor-ldap-mapper
+/phosphor-ldap-config/phosphor-ldap-conf
+/test/ldap_config_test
+/test/utest
+/test/ldap_config_test.log
+/test/ldap_config_test.trs
+/test/test-suite.log
+/test/utest.log
+/test/utest.trs
diff --git a/Makefile.am b/Makefile.am
index 4413b84..9da26ef 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -23,5 +23,5 @@ phosphor_user_manager_CXXFLAGS = $(SYSTEMD_CFLAGS) \
-DBOOST_SYSTEM_NO_DEPRECATED \
-DBOOST_ERROR_CODE_HEADER_ONLY
-SUBDIRS = . test phosphor-ldap-mapper phosphor-ldap-config
+SUBDIRS = . phosphor-ldap-mapper phosphor-ldap-config test
diff --git a/configure.ac b/configure.ac
index 5d15fe8..afcc901 100644
--- a/configure.ac
+++ b/configure.ac
@@ -67,6 +67,10 @@ AC_ARG_VAR(LDAP_CONFIG_FILE, [Path of LDAP configuration file])
AS_IF([test "x$LDAP_CONFIG_FILE" == "x"], [LDAP_CONFIG_FILE="/etc/nslcd.conf"])
AC_DEFINE_UNQUOTED([LDAP_CONFIG_FILE], ["$LDAP_CONFIG_FILE"], [Path of LDAP configuration file])
+AC_ARG_VAR(TLS_CACERT_FILE, [Path of LDAP server's CA certificate])
+AS_IF([test "x$TLS_CACERT_FILE" == "x"], [TLS_CACERT_FILE="/etc/ssl/certs/Root-CA.pem"])
+AC_DEFINE_UNQUOTED([TLS_CACERT_FILE], ["$TLS_CACERT_FILE"], [Path of LDAP server's CA certificate])
+
AC_ARG_VAR(LDAP_CONFIG_ROOT, [LDAP configuration root])
AS_IF([test "x$LDAP_CONFIG_ROOT" == "x"], [LDAP_CONFIG_ROOT="/xyz/openbmc_project/user/ldap"])
AC_DEFINE_UNQUOTED([LDAP_CONFIG_ROOT], ["$LDAP_CONFIG_ROOT"], [LDAP configuration root])
diff --git a/phosphor-ldap-config/ldap_configuration.cpp b/phosphor-ldap-config/ldap_configuration.cpp
index 1369362..31e4e75 100644
--- a/phosphor-ldap-config/ldap_configuration.cpp
+++ b/phosphor-ldap-config/ldap_configuration.cpp
@@ -49,10 +49,12 @@ void Config::delete_()
parent.deleteObject();
try
{
- fs::copy_file(defaultNslcdFile, LDAP_CONFIG_FILE,
+ fs::path configDir = fs::path(configFilePath.c_str()).parent_path();
+
+ fs::copy_file(configDir / defaultNslcdFile, LDAP_CONFIG_FILE,
fs::copy_options::overwrite_existing);
- fs::copy_file(linuxNsSwitchFile, nsSwitchFile,
+ fs::copy_file(configDir / linuxNsSwitchFile, configDir / nsSwitchFile,
fs::copy_options::overwrite_existing);
}
catch (const std::exception& e)
@@ -236,6 +238,10 @@ std::string Config::lDAPBindDN(std::string value)
{
throw;
}
+ catch (const InvalidArgument& e)
+ {
+ throw;
+ }
catch (const std::exception& e)
{
log<level::ERR>(e.what());
@@ -270,6 +276,10 @@ std::string Config::lDAPBaseDN(std::string value)
{
throw;
}
+ catch (const InvalidArgument& e)
+ {
+ throw;
+ }
catch (const std::exception& e)
{
log<level::ERR>(e.what());
@@ -415,7 +425,8 @@ std::string
deleteObject();
try
{
- fs::copy_file(LDAPNsSwitchFile, nsSwitchFile,
+ fs::path configDir = fs::path(configFilePath.c_str()).parent_path();
+ fs::copy_file(configDir / LDAPNsSwitchFile, configDir / nsSwitchFile,
fs::copy_options::overwrite_existing);
}
catch (const std::exception& e)
@@ -442,7 +453,7 @@ void ConfigMgr::restore(const char* filePath)
if (!fs::exists(filePath))
{
log<level::ERR>("Config file doesn't exists",
- entry("LDAP_CONFIG_FILE=%s", LDAP_CONFIG_FILE));
+ entry("LDAP_CONFIG_FILE=%s", configFilePath.c_str()));
return;
}
diff --git a/phosphor-ldap-config/ldap_configuration.hpp b/phosphor-ldap-config/ldap_configuration.hpp
index 034aab8..0dfb56d 100644
--- a/phosphor-ldap-config/ldap_configuration.hpp
+++ b/phosphor-ldap-config/ldap_configuration.hpp
@@ -16,10 +16,10 @@ namespace phosphor
{
namespace ldap
{
-static constexpr auto defaultNslcdFile = "/etc/nslcd.conf.default";
-static constexpr auto nsSwitchFile = "/etc/nsswitch.conf";
-static constexpr auto LDAPNsSwitchFile = "/etc/nsswitch_ldap.conf";
-static constexpr auto linuxNsSwitchFile = "/etc/nsswitch_linux.conf";
+static constexpr auto defaultNslcdFile = "nslcd.conf.default";
+static constexpr auto nsSwitchFile = "nsswitch.conf";
+static constexpr auto LDAPNsSwitchFile = "nsswitch_ldap.conf";
+static constexpr auto linuxNsSwitchFile = "nsswitch_linux.conf";
using namespace phosphor::logging;
using namespace sdbusplus::xyz::openbmc_project::Common::Error;
@@ -144,13 +144,16 @@ class ConfigMgr : public CreateIface
* @param[in] bus - Bus to attach to.
* @param[in] path - Path to attach at.
* @param[in] filePath - LDAP configuration file.
+ * @param[in] caCertfile - LDAP's CA certificate file.
*/
- ConfigMgr(sdbusplus::bus::bus& bus, const char* path) :
- CreateIface(bus, path, true), bus(bus)
+ ConfigMgr(sdbusplus::bus::bus& bus, const char* path,
+ const char* filePath) :
+ CreateIface(bus, path, true),
+ configFilePath(filePath), bus(bus)
{
try
{
- restore(LDAP_CONFIG_FILE);
+ restore(configFilePath.c_str());
emit_object_added();
}
catch (const std::exception& e)
@@ -193,8 +196,10 @@ class ConfigMgr : public CreateIface
*/
void deleteObject();
- private:
+ protected:
std::string configFilePath{};
+ std::string tlsCacertfile{};
+
/** @brief Persistent sdbusplus D-Bus bus connection. */
sdbusplus::bus::bus& bus;
diff --git a/phosphor-ldap-config/main.cpp b/phosphor-ldap-config/main.cpp
index 6bba619..e285786 100644
--- a/phosphor-ldap-config/main.cpp
+++ b/phosphor-ldap-config/main.cpp
@@ -11,11 +11,12 @@ int main(int argc, char* argv[])
using namespace phosphor::logging;
using namespace sdbusplus::xyz::openbmc_project::Common::Error;
namespace fs = std::experimental::filesystem;
+ fs::path configDir = fs::path(LDAP_CONFIG_FILE).parent_path();
- if (!fs::exists(phosphor::ldap::defaultNslcdFile) ||
- !fs::exists(phosphor::ldap::nsSwitchFile) ||
- (!fs::exists(phosphor::ldap::LDAPNsSwitchFile) &&
- !fs::exists(phosphor::ldap::linuxNsSwitchFile)))
+ if (!fs::exists(configDir / phosphor::ldap::defaultNslcdFile) ||
+ !fs::exists(configDir / phosphor::ldap::nsSwitchFile) ||
+ (!fs::exists(configDir / phosphor::ldap::LDAPNsSwitchFile) &&
+ !fs::exists(configDir / phosphor::ldap::linuxNsSwitchFile)))
{
log<level::ERR>("Error starting LDAP Config App, configfile(s) are "
"missing, exiting!!!");
@@ -26,7 +27,7 @@ int main(int argc, char* argv[])
// Add sdbusplus ObjectManager for the 'root' path of the LDAP config.
sdbusplus::server::manager::manager objManager(bus, LDAP_CONFIG_ROOT);
- phosphor::ldap::ConfigMgr mgr(bus, LDAP_CONFIG_ROOT);
+ phosphor::ldap::ConfigMgr mgr(bus, LDAP_CONFIG_ROOT, LDAP_CONFIG_FILE);
bus.request_name(LDAP_CONFIG_BUSNAME);
diff --git a/test/Makefile.am b/test/Makefile.am
index 3acdaab..5026e30 100644
--- a/test/Makefile.am
+++ b/test/Makefile.am
@@ -25,3 +25,12 @@ utest_LDFLAGS = -lgtest_main \
utest_SOURCES = utest.cpp
utest_LDADD = $(top_builddir)/user.o
+
+check_PROGRAMS += ldap_config_test
+ldap_config_test_CPPFLAGS = $(utest_CPPFLAGS)
+ldap_config_test_CXXFLAGS = $(utest_CXXFLAGS)
+ldap_config_test_LDFLAGS = $(utest_LDFLAGS) \
+ -lldap \
+ -lgmock
+ldap_config_test_SOURCES = ldap_config_test.cpp utils_test.cpp
+ldap_config_test_LDADD = $(top_builddir)/phosphor-ldap-config/ldap_configuration.o $(top_builddir)/phosphor-ldap-config/utils.o
diff --git a/test/ldap_config_test.cpp b/test/ldap_config_test.cpp
new file mode 100644
index 0000000..8f9a07c
--- /dev/null
+++ b/test/ldap_config_test.cpp
@@ -0,0 +1,335 @@
+#include "config.h"
+#include "phosphor-ldap-config/ldap_configuration.hpp"
+
+#include <experimental/filesystem>
+#include <phosphor-logging/log.hpp>
+#include <phosphor-logging/elog-errors.hpp>
+#include <sdbusplus/bus.hpp>
+#include <xyz/openbmc_project/Common/error.hpp>
+#include <sdbusplus/bus.hpp>
+#include <gmock/gmock.h>
+#include <gtest/gtest.h>
+#include <fstream>
+#include <string>
+#include <sys/types.h>
+
+namespace phosphor
+{
+namespace ldap
+{
+namespace fs = std::experimental::filesystem;
+namespace ldap_base = sdbusplus::xyz::openbmc_project::User::Ldap::server;
+using Config = phosphor::ldap::Config;
+
+class TestLDAPConfig : public testing::Test
+{
+ public:
+ TestLDAPConfig() : bus(sdbusplus::bus::new_default())
+ {
+ }
+ void SetUp() override
+ {
+ using namespace phosphor::ldap;
+ char tmpldap[] = "/tmp/ldap_test.XXXXXX";
+ dir = fs::path(mkdtemp(tmpldap));
+ fs::path tslCacertFilePath{TLS_CACERT_FILE};
+ tslCacertFile = tslCacertFilePath.filename().c_str();
+ fs::path confFilePath{LDAP_CONFIG_FILE};
+ ldapconfFile = confFilePath.filename().c_str();
+ std::fstream fs;
+ fs.open(dir / defaultNslcdFile, std::fstream::out);
+ fs.close();
+ fs.open(dir / nsSwitchFile, std::fstream::out);
+ fs.close();
+ fs.open(dir / LDAPNsSwitchFile, std::fstream::out);
+ fs.close();
+ fs.open(dir / linuxNsSwitchFile, std::fstream::out);
+ fs.close();
+ fs.open(dir / tslCacertFile, std::fstream::out);
+ fs.close();
+ }
+
+ void TearDown() override
+ {
+ fs::remove_all(dir);
+ }
+
+ protected:
+ fs::path dir;
+ std::string tslCacertFile;
+ std::string ldapconfFile;
+ sdbusplus::bus::bus bus;
+};
+
+class MockConfigMgr : public phosphor::ldap::ConfigMgr
+{
+ public:
+ MockConfigMgr(sdbusplus::bus::bus& bus, const char* path,
+ const char* filePath) :
+ phosphor::ldap::ConfigMgr(bus, path, filePath)
+ {
+ }
+ MOCK_METHOD1(restartService, void(const std::string& service));
+ MOCK_METHOD1(stopService, void(const std::string& service));
+ std::unique_ptr<Config>& getConfigPtr()
+ {
+ return configPtr;
+ }
+
+ void restore(const char* filePath)
+ {
+ phosphor::ldap::ConfigMgr::restore(filePath);
+ return;
+ }
+
+ friend class TestLDAPConfig;
+};
+
+TEST_F(TestLDAPConfig, testCreate)
+{
+ auto configFilePath = std::string(dir.c_str()) + "/" + ldapconfFile;
+
+ if (fs::exists(configFilePath))
+ {
+ fs::remove(configFilePath);
+ }
+ EXPECT_FALSE(fs::exists(configFilePath));
+ MockConfigMgr manager(bus, LDAP_CONFIG_ROOT, configFilePath.c_str());
+ EXPECT_CALL(manager, restartService("nslcd.service")).Times(2);
+ EXPECT_CALL(manager, restartService("nscd.service")).Times(1);
+ manager.createConfig("ldap://9.194.251.136/", "cn=Users,dc=com",
+ "cn=Users,dc=corp", "MyLdap12",
+ ldap_base::Create::SearchScope::sub,
+ ldap_base::Create::Type::ActiveDirectory);
+
+ EXPECT_TRUE(fs::exists(configFilePath));
+ EXPECT_EQ(manager.getConfigPtr()->lDAPServerURI(), "ldap://9.194.251.136/");
+ EXPECT_EQ(manager.getConfigPtr()->lDAPBindDN(), "cn=Users,dc=com");
+ EXPECT_EQ(manager.getConfigPtr()->lDAPBaseDN(), "cn=Users,dc=corp");
+ EXPECT_EQ(manager.getConfigPtr()->lDAPSearchScope(),
+ ldap_base::Config::SearchScope::sub);
+ EXPECT_EQ(manager.getConfigPtr()->lDAPType(),
+ ldap_base::Config::Type::ActiveDirectory);
+}
+
+TEST_F(TestLDAPConfig, testRestores)
+{
+ auto configFilePath = std::string(dir.c_str()) + "/" + ldapconfFile;
+
+ if (fs::exists(configFilePath))
+ {
+ fs::remove(configFilePath);
+ }
+ EXPECT_FALSE(fs::exists(configFilePath));
+ MockConfigMgr* managerPtr =
+ new MockConfigMgr(bus, LDAP_CONFIG_ROOT, configFilePath.c_str());
+ EXPECT_CALL(*managerPtr, restartService("nslcd.service")).Times(4);
+ EXPECT_CALL(*managerPtr, restartService("nscd.service")).Times(2);
+ managerPtr->createConfig("ldap://9.194.251.138/", "cn=Users,dc=com",
+ "cn=Users,dc=corp", "MyLdap12",
+ ldap_base::Create::SearchScope::sub,
+ ldap_base::Create::Type::ActiveDirectory);
+ EXPECT_TRUE(fs::exists(configFilePath));
+ // Delete LDAP configuration
+ managerPtr->deleteObject();
+ EXPECT_TRUE(fs::exists(configFilePath));
+ // Restore from configFilePath
+ managerPtr->restore(configFilePath.c_str());
+ // validate restored properties
+ EXPECT_EQ(managerPtr->getConfigPtr()->lDAPServerURI(),
+ "ldap://9.194.251.138/");
+ EXPECT_EQ(managerPtr->getConfigPtr()->lDAPBindDN(), "cn=Users,dc=com");
+ EXPECT_EQ(managerPtr->getConfigPtr()->lDAPBaseDN(), "cn=Users,dc=corp");
+ EXPECT_EQ(managerPtr->getConfigPtr()->lDAPSearchScope(),
+ ldap_base::Config::SearchScope::sub);
+ EXPECT_EQ(managerPtr->getConfigPtr()->lDAPType(),
+ ldap_base::Config::Type::ActiveDirectory);
+ delete managerPtr;
+}
+
+TEST_F(TestLDAPConfig, testLDAPServerURI)
+{
+ auto configFilePath = std::string(dir.c_str()) + "/" + ldapconfFile;
+ if (fs::exists(configFilePath))
+ {
+ fs::remove(configFilePath);
+ }
+ EXPECT_FALSE(fs::exists(configFilePath));
+ MockConfigMgr* managerPtr =
+ new MockConfigMgr(bus, LDAP_CONFIG_ROOT, configFilePath.c_str());
+ EXPECT_CALL(*managerPtr, restartService("nslcd.service")).Times(6);
+ EXPECT_CALL(*managerPtr, restartService("nscd.service")).Times(2);
+
+ managerPtr->createConfig("ldap://9.194.251.138/", "cn=Users,dc=com",
+ "cn=Users,dc=corp", "MyLdap12",
+ ldap_base::Create::SearchScope::sub,
+ ldap_base::Create::Type::ActiveDirectory);
+ // Change LDAP Server URI
+ managerPtr->getConfigPtr()->lDAPServerURI("ldap://9.194.251.139");
+ EXPECT_EQ(managerPtr->getConfigPtr()->lDAPServerURI(),
+ "ldap://9.194.251.139");
+ // Change LDAP Server URI
+ managerPtr->getConfigPtr()->lDAPServerURI("ldaps://9.194.251.139");
+ EXPECT_EQ(managerPtr->getConfigPtr()->lDAPServerURI(),
+ "ldaps://9.194.251.139");
+ // Delete LDAP configuration
+ managerPtr->deleteObject();
+
+ managerPtr->restore(configFilePath.c_str());
+ // Check LDAP Server URI
+ EXPECT_EQ(managerPtr->getConfigPtr()->lDAPServerURI(),
+ "ldaps://9.194.251.139");
+ delete managerPtr;
+}
+
+TEST_F(TestLDAPConfig, testLDAPBindDN)
+{
+ auto configFilePath = std::string(dir.c_str()) + "/" + ldapconfFile;
+ if (fs::exists(configFilePath))
+ {
+ fs::remove(configFilePath);
+ }
+ EXPECT_FALSE(fs::exists(configFilePath));
+ MockConfigMgr* managerPtr =
+ new MockConfigMgr(bus, LDAP_CONFIG_ROOT, configFilePath.c_str());
+ EXPECT_CALL(*managerPtr, restartService("nslcd.service")).Times(5);
+ EXPECT_CALL(*managerPtr, restartService("nscd.service")).Times(2);
+
+ managerPtr->createConfig("ldap://9.194.251.138/", "cn=Users,dc=com",
+ "cn=Users,dc=corp", "MyLdap12",
+ ldap_base::Create::SearchScope::sub,
+ ldap_base::Create::Type::ActiveDirectory);
+ // Change LDAP BindDN
+ managerPtr->getConfigPtr()->lDAPBindDN(
+ "cn=Administrator,cn=Users,dc=corp,dc=ibm,dc=com");
+ EXPECT_EQ(managerPtr->getConfigPtr()->lDAPBindDN(),
+ "cn=Administrator,cn=Users,dc=corp,dc=ibm,dc=com");
+ // Change LDAP BindDN
+ EXPECT_THROW(
+ {
+ try
+ {
+ managerPtr->getConfigPtr()->lDAPBindDN("");
+ }
+ catch (const InvalidArgument& e)
+ {
+ throw;
+ }
+ },
+ InvalidArgument);
+ // Delete LDAP configuration
+ managerPtr->deleteObject();
+
+ managerPtr->restore(configFilePath.c_str());
+ // Check LDAP BindDN after restoring
+ EXPECT_EQ(managerPtr->getConfigPtr()->lDAPBindDN(),
+ "cn=Administrator,cn=Users,dc=corp,dc=ibm,dc=com");
+ delete managerPtr;
+}
+
+TEST_F(TestLDAPConfig, testLDAPBaseDN)
+{
+ auto configFilePath = std::string(dir.c_str()) + "/" + ldapconfFile;
+ if (fs::exists(configFilePath))
+ {
+ fs::remove(configFilePath);
+ }
+ EXPECT_FALSE(fs::exists(configFilePath));
+ MockConfigMgr* managerPtr =
+ new MockConfigMgr(bus, LDAP_CONFIG_ROOT, configFilePath.c_str());
+ EXPECT_CALL(*managerPtr, restartService("nslcd.service")).Times(5);
+ EXPECT_CALL(*managerPtr, restartService("nscd.service")).Times(2);
+ managerPtr->createConfig("ldap://9.194.251.138/", "cn=Users,dc=com",
+ "cn=Users,dc=corp", "MyLdap12",
+ ldap_base::Create::SearchScope::sub,
+ ldap_base::Create::Type::ActiveDirectory);
+ // Change LDAP BaseDN
+ managerPtr->getConfigPtr()->lDAPBaseDN(
+ "cn=Administrator,cn=Users,dc=corp,dc=ibm,dc=com");
+ EXPECT_EQ(managerPtr->getConfigPtr()->lDAPBaseDN(),
+ "cn=Administrator,cn=Users,dc=corp,dc=ibm,dc=com");
+ // Change LDAP BaseDN
+ EXPECT_THROW(
+ {
+ try
+ {
+ managerPtr->getConfigPtr()->lDAPBaseDN("");
+ }
+ catch (const InvalidArgument& e)
+ {
+ throw;
+ }
+ },
+ InvalidArgument);
+ // Delete LDAP configuration
+ managerPtr->deleteObject();
+
+ managerPtr->restore(configFilePath.c_str());
+ // Check LDAP BaseDN after restoring
+ EXPECT_EQ(managerPtr->getConfigPtr()->lDAPBaseDN(),
+ "cn=Administrator,cn=Users,dc=corp,dc=ibm,dc=com");
+ delete managerPtr;
+}
+
+TEST_F(TestLDAPConfig, testSearchScope)
+{
+ auto configFilePath = std::string(dir.c_str()) + "/" + ldapconfFile;
+ if (fs::exists(configFilePath))
+ {
+ fs::remove(configFilePath);
+ }
+ EXPECT_FALSE(fs::exists(configFilePath));
+ MockConfigMgr* managerPtr =
+ new MockConfigMgr(bus, LDAP_CONFIG_ROOT, configFilePath.c_str());
+ EXPECT_CALL(*managerPtr, restartService("nslcd.service")).Times(5);
+ EXPECT_CALL(*managerPtr, restartService("nscd.service")).Times(2);
+ managerPtr->createConfig("ldap://9.194.251.138/", "cn=Users,dc=com",
+ "cn=Users,dc=corp", "MyLdap12",
+ ldap_base::Create::SearchScope::sub,
+ ldap_base::Create::Type::ActiveDirectory);
+ // Change LDAP SearchScope
+ managerPtr->getConfigPtr()->lDAPSearchScope(
+ ldap_base::Config::SearchScope::one);
+ EXPECT_EQ(managerPtr->getConfigPtr()->lDAPSearchScope(),
+ ldap_base::Config::SearchScope::one);
+ // Delete LDAP configuration
+ managerPtr->deleteObject();
+
+ managerPtr->restore(configFilePath.c_str());
+ // Check LDAP SearchScope after restoring
+ EXPECT_EQ(managerPtr->getConfigPtr()->lDAPSearchScope(),
+ ldap_base::Config::SearchScope::one);
+ delete managerPtr;
+}
+
+TEST_F(TestLDAPConfig, testLDAPType)
+{
+ auto configFilePath = std::string(dir.c_str()) + "/" + ldapconfFile;
+ if (fs::exists(configFilePath))
+ {
+ fs::remove(configFilePath);
+ }
+ EXPECT_FALSE(fs::exists(configFilePath));
+ MockConfigMgr* managerPtr =
+ new MockConfigMgr(bus, LDAP_CONFIG_ROOT, configFilePath.c_str());
+ EXPECT_CALL(*managerPtr, restartService("nslcd.service")).Times(5);
+ EXPECT_CALL(*managerPtr, restartService("nscd.service")).Times(2);
+ managerPtr->createConfig("ldap://9.194.251.138/", "cn=Users,dc=com",
+ "cn=Users,dc=corp", "MyLdap12",
+ ldap_base::Create::SearchScope::sub,
+ ldap_base::Create::Type::ActiveDirectory);
+ // Change LDAP type
+ managerPtr->getConfigPtr()->lDAPType(ldap_base::Config::Type::OpenLdap);
+ EXPECT_EQ(managerPtr->getConfigPtr()->lDAPType(),
+ ldap_base::Config::Type::OpenLdap);
+ // Delete LDAP configuration
+ managerPtr->deleteObject();
+
+ managerPtr->restore(configFilePath.c_str());
+ // Check LDAP type after restoring
+ EXPECT_EQ(managerPtr->getConfigPtr()->lDAPType(),
+ ldap_base::Config::Type::OpenLdap);
+ delete managerPtr;
+}
+} // namespace ldap
+} // namespace phosphor
diff --git a/test/utils_test.cpp b/test/utils_test.cpp
new file mode 100644
index 0000000..cded321
--- /dev/null
+++ b/test/utils_test.cpp
@@ -0,0 +1,67 @@
+#include "phosphor-ldap-config/utils.hpp"
+#include <netinet/in.h>
+#include <gtest/gtest.h>
+#include <ldap.h>
+
+namespace phosphor
+{
+namespace ldap
+{
+constexpr auto LDAPscheme = "ldap";
+constexpr auto LDAPSscheme = "ldaps";
+
+class TestUtil : public testing::Test
+{
+ public:
+ TestUtil()
+ {
+ // Empty
+ }
+};
+
+TEST_F(TestUtil, URIValidation)
+{
+ std::string ipaddress = "ldap://0.0.0.0";
+ EXPECT_EQ(true, isValidLDAPURI(ipaddress.c_str(), LDAPscheme));
+
+ ipaddress = "ldap://9.3.185.83";
+ EXPECT_EQ(true, isValidLDAPURI(ipaddress.c_str(), LDAPscheme));
+
+ ipaddress = "ldaps://9.3.185.83";
+ EXPECT_EQ(false, isValidLDAPURI(ipaddress.c_str(), LDAPscheme));
+
+ ipaddress = "ldap://9.3.a.83";
+ EXPECT_EQ(false, isValidLDAPURI(ipaddress.c_str(), LDAPscheme));
+
+ ipaddress = "ldap://9.3.185.a";
+ EXPECT_EQ(false, isValidLDAPURI(ipaddress.c_str(), LDAPscheme));
+
+ ipaddress = "ldap://x.x.x.x";
+ EXPECT_EQ(false, isValidLDAPURI(ipaddress.c_str(), LDAPscheme));
+
+ ipaddress = "ldaps://0.0.0.0";
+ EXPECT_EQ(true, isValidLDAPURI(ipaddress.c_str(), LDAPSscheme));
+
+ ipaddress = "ldap://0.0.0.0";
+ EXPECT_EQ(false, isValidLDAPURI(ipaddress.c_str(), LDAPSscheme));
+
+ ipaddress = "ldaps://9.3.185.83";
+ EXPECT_EQ(true, isValidLDAPURI(ipaddress.c_str(), LDAPSscheme));
+
+ ipaddress = "ldap://9.3.185.83";
+ EXPECT_EQ(false, isValidLDAPURI(ipaddress.c_str(), LDAPSscheme));
+
+ ipaddress = "ldaps://9.3.185.83";
+ EXPECT_EQ(true, isValidLDAPURI(ipaddress.c_str(), LDAPSscheme));
+
+ ipaddress = "ldaps://9.3.185.a";
+ EXPECT_EQ(false, isValidLDAPURI(ipaddress.c_str(), LDAPSscheme));
+
+ ipaddress = "ldaps://9.3.a.83";
+ EXPECT_EQ(false, isValidLDAPURI(ipaddress.c_str(), LDAPSscheme));
+
+ ipaddress = "ldaps://x.x.x.x";
+ EXPECT_EQ(false, isValidLDAPURI(ipaddress.c_str(), LDAPSscheme));
+}
+} // namespace ldap
+} // namespace phosphor
OpenPOWER on IntegriCloud