diff options
| author | Vernon Mauery <vernon.mauery@linux.intel.com> | 2018-10-15 12:55:34 -0700 |
|---|---|---|
| committer | Vernon Mauery <vernon.mauery@linux.intel.com> | 2018-11-06 15:42:37 -0800 |
| commit | ae1fda44032a361874417c4006ddcbd951974399 (patch) | |
| tree | c179b19c47cdb3ef0114b89385370fc6a144614b /command/session_cmds.cpp | |
| parent | 9e801a2b5b36acd307606af5eafdb885dfe8daee (diff) | |
| download | phosphor-net-ipmid-ae1fda44032a361874417c4006ddcbd951974399.tar.gz phosphor-net-ipmid-ae1fda44032a361874417c4006ddcbd951974399.zip | |
netipmid: use std::shared_ptr instead of weak_ptr/lock
All of the instances of getSession and startSession were assigning the
result to a local shared_ptr via lock on the weak_ptr. It doesn't make
sense to demote the shared_ptr (from the sessionsMap) to a weak_ptr via
the return, only to promote to a shared_ptr again via lock.
Tested-by: running ipmitool -H a.b.c.d -P 0penBmc -I lanplus mc info
Sessions start and stop, same as before.
Change-Id: Ic10779285891d73ee51115f16ed0000b38d1c52a
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>
Diffstat (limited to 'command/session_cmds.cpp')
| -rw-r--r-- | command/session_cmds.cpp | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/command/session_cmds.cpp b/command/session_cmds.cpp index fb2d074..d363c1e 100644 --- a/command/session_cmds.cpp +++ b/command/session_cmds.cpp @@ -23,9 +23,8 @@ std::vector<uint8_t> response->completionCode = IPMI_CC_OK; uint8_t reqPrivilegeLevel = request->reqPrivLevel; - auto session = (std::get<session::Manager&>(singletonPool) - .getSession(handler.sessionID)) - .lock(); + auto session = std::get<session::Manager&>(singletonPool) + .getSession(handler.sessionID); if (reqPrivilegeLevel == 0) // Just return present privilege level { |
