From ae1fda44032a361874417c4006ddcbd951974399 Mon Sep 17 00:00:00 2001 From: Vernon Mauery Date: Mon, 15 Oct 2018 12:55:34 -0700 Subject: netipmid: use std::shared_ptr instead of weak_ptr/lock All of the instances of getSession and startSession were assigning the result to a local shared_ptr via lock on the weak_ptr. It doesn't make sense to demote the shared_ptr (from the sessionsMap) to a weak_ptr via the return, only to promote to a shared_ptr again via lock. Tested-by: running ipmitool -H a.b.c.d -P 0penBmc -I lanplus mc info Sessions start and stop, same as before. Change-Id: Ic10779285891d73ee51115f16ed0000b38d1c52a Signed-off-by: Vernon Mauery --- command/session_cmds.cpp | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) (limited to 'command/session_cmds.cpp') diff --git a/command/session_cmds.cpp b/command/session_cmds.cpp index fb2d074..d363c1e 100644 --- a/command/session_cmds.cpp +++ b/command/session_cmds.cpp @@ -23,9 +23,8 @@ std::vector response->completionCode = IPMI_CC_OK; uint8_t reqPrivilegeLevel = request->reqPrivLevel; - auto session = (std::get(singletonPool) - .getSession(handler.sessionID)) - .lock(); + auto session = std::get(singletonPool) + .getSession(handler.sessionID); if (reqPrivilegeLevel == 0) // Just return present privilege level { -- cgit v1.2.1