| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
|
|
| |
Installs into bin instead of sbin per guidelines.
Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: Ie7747c1a6581742b2256ba2ddaf985df303ec39f
|
| |
|
|
|
|
|
|
|
| |
We need to conform to the std::variant interface for sdbusplus to
eventually switch away from mapbox. The .get() interface is only
provided by mapbox and needs to be converted.
Change-Id: Ia41808d6bab73b097fc631fd9eff549be9a22415
Signed-off-by: William A. Kennington III <wak@google.com>
|
| |
|
|
|
|
|
| |
Add clang-format to repo.
Change-Id: Ib3f81524b66414df3e6c93d8a6df6e22c43841e0
Signed-off-by: Patrick Venture <venture@google.com>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The C++ implementation of the mapper will throw an exception
if the passed in interface was not found on any paths, which
is expected to happen when fru-fault-monitor checks for error
logs on startup and there aren't any. Catch that exception
and just continue on the path of there being no error logs.
Note this is made slightly more complicated by the fact that the
default constructor for sdbusplus::message is deleted, so one
cannot just do:
sdbusplus::message reply;
try
{
auto method = bus.new_method_call(...);
reply = bus.call(method);
}
...
reply.read(...);
Change-Id: Ic15c7112cbfe0f3df974748f90828f12255ec29a
Signed-off-by: Matt Spinler <spinler@us.ibm.com>
|
| |
|
|
|
|
|
|
|
| |
The upcoming C++ mapper implementation needs it this way.
Tested: With the new mapper and this fix, the call works.
Change-Id: I9b65cb8e12ff0369517ab82dca0be0fae5ae281c
Signed-off-by: Matt Spinler <spinler@us.ibm.com>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Handle exceptions from the sdbusplus method call_noreply API.
The phosphor-fru-fault-monitor app would fail with the following
message on Romulus with the latest sdbusplus changes:
sd_bus_call noreply: org.freedesktop.DBus.Error.UnknownObject:
Unknown object '/xyz/openbmc_project/led/groups/core1_fault'.
Add error handling.
Tested: The phosphor-fru-fault-monitor does not core dump on Romulus.
Change-Id: I2bec59c0e0f483e8bfc0cb20a343cb05670212b7
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>
|
| |
|
|
|
|
|
|
|
| |
Will cause symbol collisions when this repository's local
error yaml is copied out during building so phosphor-logging
includes it in its elog-errors.hpp.
Change-Id: Ic467418106d45b6b49b6cabec304c4ae64a3d76b
Signed-off-by: Matt Spinler <spinler@us.ibm.com>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
With the latest sdbusplus exception handling changes,
an exception was being thrown when trying to read a pair
out of the interfacesAdded signal message.
Change the code to read the path and map separately.
Also modified the name of the data structures to match
what the message actually returned.
Tested: The exception journal entries went away and LEDs
will turn on and off again.
Change-Id: I2c72000e0da365743715da966a0c9e571efd33d5
Signed-off-by: Matt Spinler <spinler@us.ibm.com>
|
| |
|
|
|
|
|
|
|
|
|
| |
Some of the messages we try and parse are not structured in the
format we expect when parsing. When error logging is enabled in
sdbusplus this causes the phosphor-fru-fault-manager to crash. Fix
this crashing by logging errors and ignoring the bad signals and
message responses.
Change-Id: Ie817beaae96961b33a343aabf1dbba9f31606d4b
Signed-off-by: William A. Kennington III <wak@google.com>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It's possible that multiple services can provide the
/xyz/openbmc_project/logging paths, which means the
interfaces added handler can get multiple callbacks
for a single error.
That being the case, move down the trace that shows
the new error log object path until after the code
checks that the association interface is present, as
that interface will only be present on one object.
Another option would have been to remove the trace
completely, but it is fairly useful for debug.
Change-Id: I98659562ef024455762110e20109bf3079b96cbe
Signed-off-by: Matt Spinler <spinler@us.ibm.com>
|
| |
|
|
|
|
|
|
|
|
|
| |
The mapper will no longer emit properties-changed signals
when the last endpoints property is removed from the fault
association object. It will only emit an interfaces-removed
signal in that case, so change the code to subscribe to the
interfaces-removed signal instead.
Change-Id: I225376e550d21b82473015324cd9a261e16fe6db
Signed-off-by: Matt Spinler <spinler@us.ibm.com>
|
| |
|
|
|
|
|
|
|
|
| |
An error was logged while starting the fru fault monitor
with no existing error logs, which is not correct.
Resolves openbmc/openbmc#2330
Change-Id: I6b222b45dd99b653443c58d9982d6576f8af0bfa
Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>
|
| |
|
|
|
|
|
| |
Resolves openbmc/openbmc#1631
Change-Id: I1639c84cbb180dfe7f6494b5e80ca45514a3e730
Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>
|
| |
|
|
|
|
|
|
|
|
|
| |
There was a race condition while calling mapper from led monitoring after
error logs started persisting, to avoid such errors the callout information is
now extracted from the message received as part of interface added signal.
Resolves openbmc/openbmc#1853
Change-Id: Ie913992bdcb3b1cb93677d64331db34202f8ae72
Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>
|
| |
|
|
|
| |
Change-Id: Id833073b9e45fae24d6bd0e7f9310ef0ba8658de
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
|
| |
|
|
|
| |
Change-Id: I28378b155da15282b1b5bf0403075b55bda5b70d
Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>
|
|
|
This application waits for new fault entries and resolution of
exiting faults to assert or deassert LED for the corresponding FRUs,
respectively.
Change-Id: I92ead0c8d3132dd7a6740b536231d6588ac42471
Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>
|
