summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPatrick Venture <venture@google.com>2019-02-13 15:14:00 -0800
committerPatrick Venture <venture@google.com>2019-02-13 15:14:00 -0800
commitfa180596fe2a3c6fe65e48055e02e0c3e4ef5977 (patch)
tree79403978aefbe6bacfe93d47f38cfea117d9a16d
parent6d7f753ba7ecc2dd062758a46ef77ce5c44b9bdb (diff)
downloadphosphor-debug-collector-master.zip
phosphor-debug-collector-master.tar.gz
build: pkg anti-pattern: use defaultsHEADmaster
Use the defaults in the pkg check where the default error message is sufficient to identify which package is missing. Change-Id: If14318cbb16f40cac4bd94b5b7d81cf9d3aacfdc Signed-off-by: Patrick Venture <venture@google.com>
-rw-r--r--configure.ac12
1 files changed, 4 insertions, 8 deletions
diff --git a/configure.ac b/configure.ac
index 114e722..c6dcb65 100644
--- a/configure.ac
+++ b/configure.ac
@@ -13,14 +13,10 @@ AC_PROG_MKDIR_P
AC_CHECK_PROG([DIRNAME], dirname, dirname)
# Check for libraries
-PKG_CHECK_MODULES([SYSTEMD], [libsystemd >= 221],,\
- AC_MSG_ERROR(["systemd required and not found."]))
-PKG_CHECK_MODULES([PHOSPHOR_DBUS_INTERFACES], [phosphor-dbus-interfaces],,\
- AC_MSG_ERROR(["Requires phosphor-dbus-interfaces package."]))
-PKG_CHECK_MODULES([SDBUSPLUS], [sdbusplus],,\
- AC_MSG_ERROR(["Requires sdbusplus package."]))
-PKG_CHECK_MODULES([PHOSPHOR_LOGGING], [phosphor-logging],,\
- AC_MSG_ERROR(["Requires phosphor-logging package."]))
+PKG_CHECK_MODULES([SYSTEMD], [libsystemd >= 221])
+PKG_CHECK_MODULES([PHOSPHOR_DBUS_INTERFACES], [phosphor-dbus-interfaces])
+PKG_CHECK_MODULES([SDBUSPLUS], [sdbusplus])
+PKG_CHECK_MODULES([PHOSPHOR_LOGGING], [phosphor-logging])
# Check for sdbus++
AC_PATH_PROG([SDBUSPLUSPLUS], [sdbus++])
OpenPOWER on IntegriCloud