From fa180596fe2a3c6fe65e48055e02e0c3e4ef5977 Mon Sep 17 00:00:00 2001 From: Patrick Venture Date: Wed, 13 Feb 2019 15:14:00 -0800 Subject: build: pkg anti-pattern: use defaults Use the defaults in the pkg check where the default error message is sufficient to identify which package is missing. Change-Id: If14318cbb16f40cac4bd94b5b7d81cf9d3aacfdc Signed-off-by: Patrick Venture --- configure.ac | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/configure.ac b/configure.ac index 114e722..c6dcb65 100644 --- a/configure.ac +++ b/configure.ac @@ -13,14 +13,10 @@ AC_PROG_MKDIR_P AC_CHECK_PROG([DIRNAME], dirname, dirname) # Check for libraries -PKG_CHECK_MODULES([SYSTEMD], [libsystemd >= 221],,\ - AC_MSG_ERROR(["systemd required and not found."])) -PKG_CHECK_MODULES([PHOSPHOR_DBUS_INTERFACES], [phosphor-dbus-interfaces],,\ - AC_MSG_ERROR(["Requires phosphor-dbus-interfaces package."])) -PKG_CHECK_MODULES([SDBUSPLUS], [sdbusplus],,\ - AC_MSG_ERROR(["Requires sdbusplus package."])) -PKG_CHECK_MODULES([PHOSPHOR_LOGGING], [phosphor-logging],,\ - AC_MSG_ERROR(["Requires phosphor-logging package."])) +PKG_CHECK_MODULES([SYSTEMD], [libsystemd >= 221]) +PKG_CHECK_MODULES([PHOSPHOR_DBUS_INTERFACES], [phosphor-dbus-interfaces]) +PKG_CHECK_MODULES([SDBUSPLUS], [sdbusplus]) +PKG_CHECK_MODULES([PHOSPHOR_LOGGING], [phosphor-logging]) # Check for sdbus++ AC_PATH_PROG([SDBUSPLUSPLUS], [sdbus++]) -- cgit v1.2.1