| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
| |
Installs into bin instead of sbin per guidelines.
Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: Ifbf3b709c08bbd892060291530a906e88430f5be
|
|
|
|
|
|
|
|
|
| |
Transition to use cli11 for argument parsing instead of a custom
argument parser.
Tested: Not tested on hardware.
Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: I9c516c8c2d76e35c6c31592f96e8f281e9d47ad6
|
|
|
|
|
|
|
|
| |
Add missing "autom4te.cache/" to .gitignore file.
Tested: Not tested on hardware.
Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: Ie06d1b22bb2a74e2f6e2901d213fffa0cacac2c4
|
|
|
|
|
|
|
|
|
| |
phosphor-host-ipmid now exposes a library along with headers for
interfacing with the ipmi daemon. Compile and link against the new
library.
Change-Id: Ib222df1605afe277457f34eb69a3d65c663325b7
Signed-off-by: William A. Kennington III <wak@google.com>
|
|
|
|
|
|
|
|
| |
Use the defaults in the pkg check where the default error message is
sufficient to identify which package is missing.
Change-Id: Iccc91bcdd4ad57980a4731184b448936c1968f85
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We incorrectly checked that FRU ID != 0, which is the default FRU ID.
Actually, the IPMI spec specifies FRU ID 0xff as reserved, so the check
was changed to prevent that ID from being used instead.
Split out fruid parsing code to its own function to cover various edge
and failure cases.
Tested:
Ran 'phosphor-read-eeprom --eeprom fru.bin --fruid=0' and checked that
values are reported to inventory as expected.
Ran with '--fruid=ff' ('invalid' FRU ID): rejected
Ran with '--fruid=xx' (non-HEX FRU ID): rejected
Ran with '--fruid=100' (out-of-range FRU ID): rejected
Ran with '--fruid="0 0"' (invalid number): rejected
Ran with '--fruid=10.0' (non-integer): rejected
Ran with '--fruid=0x12' (valid HEX FRU ID): accepted
Ran with '--fruid=fe' (valid HEX FRU ID): accepted
Change-Id: Ic1fb79cefc6931f21d0b5cb4363ad5fd44f47c92
Signed-off-by: Oskar Senft <osk@google.com>
|
|
|
|
|
|
|
|
|
| |
The contents of the internal use area are not defined beyond the first
byte, which means that we should not expect its last byte to be a CRC
for the area.
Change-Id: I15aba7f48e13f8a93c5a6b7e3262d9227da5dad7
Signed-off-by: Oskar Senft <osk@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix the following warning under gcc8:
| ../git/frup.cpp: In function 'void _append_to_dict(uint8_t, uint8_t*, IPMIFruInfo&)':
| ../git/frup.cpp:664:24: error: 'char* strncpy(char*, const char*, size_t)' output truncated before terminating nul copying 2 bytes from a string of the same length [-Werror=stringop-truncation]
| strncpy(bin_in_ascii, "0x", 2);
| ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~
Change-Id: Ia35d0ae733f0879f6c9d23126bab5fc899e89def
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
|
|
|
|
|
| |
Add doxygen comments for methods.
Change-Id: Ifc155279a21b258300dadd409abfb617652159dc
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
| |
Add doxygen to IPMIFruArea class.
Change-Id: Ie28dd84c25df939671771741d7e4faca931e613e
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
|
| |
Drop extra parentheses around parameters in call to parse_fru_area.
This involves changing a casting from c-style to a static_cast<>.
Change-Id: I281a950146fd296f8c9b15bd6dfc8562ad9b14bc
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
|
| |
Drop unused dbus debug code. There were no calls to set the values and
the debug printing them would therefore always print empty strings.
Change-Id: I767baf9f3450c9944396930069089a6bbb6e5c6a
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
| |
Use default destructor now that there isn't a raw pointer.
Change-Id: I3b28a99ca27a9e5dd15de9809e882cab02eedf75
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
| |
Use vector of bytes instead of raw byte pointer.
Change-Id: I20a2beec3cbbc44c8cc3a48cefd73f3f27bdcc8f
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
| |
OpenBMC style dictates conditional statements needs curly braces.
Change-Id: Iff7066dec2e7a376f2a97e67591ba95b7aa8549d
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
|
| |
OpenBMC style dictates member variables be lower camel and not snake
case.
Change-Id: I3e217b51f910612c3e5ecf1480340a27ef29d774
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
| |
Set the language in the build to C++.
Change-Id: Iaf56356269617c0546d2b42a225bf8732fe6356c
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
| |
Change-Id: I56b9100c0d7ee8bee84c00eba4fd0d0899aa50e8
Signed-off-by: Emily Shaffer <emilyshaffer@google.com>
|
|
|
|
|
|
|
| |
Drop unused sd-bus.h header.
Change-Id: I0a55cd3aa5a551d7fa04706d7e0c5b6b275efcf5
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
| |
Function names should be lower camel and not snake case.
Change-Id: I6f8683850ce017e63641415846e8a0f031fccba7
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
| |
OpenBMC style declares variables be lower camel and not snake case.
Change-Id: I4a448b84ae3d930049d4cb761216459799a698fa
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
| |
OpenBMC style declares variables be lower camel and not snake case.
Change-Id: Iec348bf9825caecc976f654a37ac149a5981c94b
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
| |
Fixup function naming to lowerCamelCase for OpenBMC style guide.
Change-Id: I8c8eda9f4aad29aadd092329248c97a556f22b9a
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
| |
Update code to use sdbusplus instead of raw sd_bus pointers.
Change-Id: I80cd4492480824827c27fbf19eb54487e28d3b75
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
| |
Set iterator to const reference where possible.
Change-Id: I2d5d766990d49df3e6a6fef743698053413152fc
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
| |
Default constructor marked private, but should be deleted.
Change-Id: I324516c51bd5f59b68284d9adcbf117cd74115af
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
|
| |
Cleanup extra parentheses from calling accessors against object pointer,
which is actually a reference to a unique_ptr.
Change-Id: Icf47bf376947d1afb0753c18be66417e2bac4507
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
| |
Apply naming convention to member functions.
Change-Id: I3b0516592dd4225f7be43c3d9cdcc9c8853d20b7
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
|
| |
For standard readability a class is typically written with public
preceding private.
Change-Id: Icdce1ee8426d651293d16f9a1ba16176a3f767c3
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
|
|
| |
Drop iv_ prefix from class members.
Renamed class members where necessary and updated some method
parameters to avoid name conflicts.
Change-Id: Id888dab9fcc020c4dff68d689a38f869c0de3525
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
| |
Drop unused member methods.
Change-Id: I1bf78f8a896173deacc0f55e3e3b8f1f0c64302a
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
| |
Move member assignment to constructor list.
Change-Id: I140aabc92533c07f6c50eb19a323e6c52dbf43a4
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
| |
Move the implementation of the class into its own source file.
Change-Id: I02d941dd8173f0cede8cdfe8af1fdc5f5418abb4
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
|
| |
Cleanup headers, dropping sd-bus header and c-headers. Add in cstdint
for uint8_t.
Change-Id: I751478a83ac807b688bb9b7d9efff2efc7578a4a
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
|
| |
Rename fru_area_vec_t to FruAreaVector and declare with using instead of
typedef.
Change-Id: I482c8ce7cedef1c67efb49b2e066ba9867547e93
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
| |
Rename fru-area.hpp header file per the openbmc file naming convention.
Change-Id: I751c8d5650bb5e71238923c4728a9cdedccc7c7f
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
| |
Drop the sdbusplus/server.hpp for sdbusplus/bus.hpp header.
Change-Id: I8ea1ae95812ceb911ac6f70f259b5884e0c4ab3b
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
|
|
|
| |
Rename ipmi_fru to IPMIFruArea
FRU is an acronym for Field Replaceable Unit, but is consistently Fru in
this codebase.
Change-Id: I53f82b51bbf01416c8a666082612cd70945cc9a5
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
| |
Drop unused sd_bus pointer from fru_info class.
Change-Id: Id93412c17d15118e8e6f66736c9dc74289392fa4
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
| |
Drop unused member functions from fru_info class.
Change-Id: Iedf108979892cf12639652bd649efb5c2d7a74ef
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
| |
Drop unused lib mapper header.
Change-Id: Ia7d2aad793d49d0c0cd5c5636e1e240147c25188
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
| |
Drop unused header: dlfcn.h
Change-Id: I1ea305913572003fabf0c2b76e75f04640bb55cb
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
| |
Add header writefrudata.hpp to corresponding file.
Change-Id: I2bec36d3c0744e7c496e7b7c161dfc6cf14bdf72
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
| |
Add missing header map to add to standard namespace.
Change-Id: I719fd0d194cb6fd8fa2e67f8acb784b498cf122a
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
|
| |
[writefrudata.cpp:176] -> [writefrudata.cpp:242]: (style) Local
variable path shadows outer symbol
Change-Id: I9fc35d6d67f51a0b9a2b9174c314e560d8531119
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
|
| |
Move ipmi_update_inventory into an anonymous namespace and rename per
the openbmc style naming conventions.
Change-Id: I931bd9a50ca695d667eb5703089f1ca020ca6995
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
| |
Move getService into an anonymous namespace.
Change-Id: I75df449858bdc8347fafe3c0ab839ff18b5a2496
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
|
|
| |
Move getFRUValue into anonymous namespace. A later step may move this
into a global scope to enable testing, or it may be replaced by an
interface.
Change-Id: Ie4299ab713a455dd8c18b91c842ded5dfc26e85b
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
|
| |
Move cleanup_error into an anonymous namespace and rename per the
openbmc style naming conventions.
Change-Id: Ib307ce2e89ecaff241c7b2d2403b75dbce794dbb
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
|
| |
Apply openbmc style naming convention to ipmi_validate_fru_area as part
of a multi-step cleanup process.
Change-Id: I082189030441e57579d072501279ff698fe1b7e3
Signed-off-by: Patrick Venture <venture@google.com>
|