| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|
|
|
|
| |
Change-Id: Ibfe32351e04ace02cb830399a56cf1860a74df87
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
|
|
| |
Cleanup header from unnecessary guarding. The guards may have been
required in earlier compilations if the source was in a mixed
environment.
Change-Id: Id03a524ad8bd1375f1aefc0bec8661e4d929543a
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
| |
Add missing header "utility" provides std::pair<>.
Change-Id: I5d303c5f41f7af16ef3dc75fdd9818ed17978a5a
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
|
| |
Fixup types.hpp to include the message header that provides the types
used.
Change-Id: If75a3288aa9a1ecd8313d50caf8d93f76e1ce06d
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
|
| |
Use log<level::ERR>() instead of fprintf(stderr,...) on failure to
connect to sdbus.
Change-Id: Ie32d4f02c83a2d204ab71f0ab178d60c136dff97
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
|
| |
[writefrudata.cpp:570]: (warning) Assignment of function parameter has
no effect outside the function. Did you forget dereferencing it?
Change-Id: Ie4162c28c10aa5964ebabb5f0db5f3f477ffa831
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
|
| |
Transition debug and error output to use log<> mechanism.
Transition c-library or compiler choice calls to cpp libraries.
Change-Id: I1b5c6327897c30be1be2f34212138b8cacb0bc84
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
|
| |
Transition debug and error output to use log<> mechanism.
Transition c-library or compiler choice calls to cpp libraries.
Change-Id: Iafdf71122e93e68f8da950f3b632460590dc3433
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
| |
[strgfnhandler.cpp:29]: (style) C-style pointer casting
Change-Id: I12082f872362c913ecf0ad5abdcee0d1dfbc86e9
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
|
|
|
| |
[frup.cpp:628] -> [frup.cpp:694]: (style) The expression 'sdr < 0'
is always false.
This is true because the value is set to 0 and never re-assigned.
Change-Id: I668f5cc5a13a0c87afa3af978c341fb60f51b70d
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
| |
Include cpp libraries for c-library calls.
Change-Id: Id082853977b2d0e3dde2bafa5a9eafe5252d9e0f
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
| |
Catch sdbusplus call exceptions.
Change-Id: Iff0b2a4265061c90ebac78f90e4183f5e36037ef
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
|
| |
Add phosphor-logging flags throughout to enable dropping in logging
calls.
Change-Id: I6fdde8aebb6cdbacc8a779195bebdc112fb54d35
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
| |
Add clang-format file.
Change-Id: Ib99bbeb0ec59b5befb742dec38286c24a7f842ea
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
| |
Add additional files and folders to gitignore.
Change-Id: I3dc3939a894718fb2c44bf8d2c59459378d94a61
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
| |
[writefrudata.cpp:441]: (style) The scope of the variable 'area_offset' can be reduced.
Change-Id: Idc8f7639347e5f4ad06fd15beedbe13a6181b4f1
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
| |
[writefrudata.cpp:580]: (style) Unused variable: defined_fru_area
Change-Id: Ic39b668db44e0111c078c214ed5d1ca11cb7b4bb
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
| |
Update configure.ac to choose the c++17 standard
Change-Id: Ieba6326b77732498d53a9ce751f5672372c1e8a4
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The boot progress sensor has moved from the
/org/openbmc/sensors path to /xyz/openbmc_project/state/host0.
(Reference: the phosphor-ipmi-sensor-inventory%/config.yaml files
under the openbmc/openbmc repository).
Update gen_pimrules with the correct sensor path and value.
Tested: Verified Witherspoon powered on to the Host OS.
Change-Id: I76df4e84176d05804e98e98703796af57d8f9b05
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>
|
|
|
|
|
|
|
|
|
| |
Spelling errors found using github.com/lucasdemarchi/codespell
A tool to fix common misspellings.
This tool is licensed under GNU General Public License, version 2.
Change-Id: Ifbc540985ddef6ee0ac6e5510c9bf79f24f89f96
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
|
|
|
| |
Change-Id: Ife70429d13a77396c0ed1d3baca0e19a8ddb339f
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
|
|
|
|
|
|
|
|
|
|
| |
This change lies in the Write Fru Data command processing.
As fru yaml would be having extra properties like
entityID,entityInstance,So changes were needed to make the change
in the corresponding c++ structure.
Change-Id: If23bb12563cdef34438746e2d6a8be7f54b7486d
Signed-off-by: Ratan Gupta <ratagupt@in.ibm.com>
|
|
|
|
|
|
|
|
|
| |
Allow generating code for empty interfaces in the FRU map.
Empty interfaces are used to determine the type of the
inventory object.
Change-Id: I945998627b88bc68374b631d1b14328cd611cb39
Signed-off-by: Marri Devender Rao <devenrao@in.ibm.com>
|
|
|
|
|
|
|
| |
Resolves openbmc/openbmc#1533
Change-Id: I9269cd24ec11a4a43657541c529e28a756f76c48
Signed-off-by: Tom Joseph <tomjoseph@in.ibm.com>
|
|
|
|
|
|
|
|
|
| |
fruid_str argument value is not empty checked.
Instead, the eeprom_file value is checked twice.
This patch fixes the fruid_str empty check.
Change-Id: Iee54a882926eeec4460ff8d46689a23fe94b7651
Signed-off-by: Dmitry Bazhenov <bazhenov.dn@gmail.com>
|
|
|
|
|
|
|
|
|
| |
The output from these printfs clog up the journal. If
needed then we should move them to phosphor logging and
make debug.
Change-Id: I26600a0d13f834da1c35d914285b13a3bc2eea4a
Signed-off-by: Andrew Geissler <andrewg@us.ibm.com>
|
|
|
|
|
|
|
|
|
|
| |
The configure check for the mapper repository did not have an error
condition in it. Therefore, the configure run passed and then the
failure surfaced as a missing header file on compile. Add an explicit
error condition to the AC_CHECK_LIB call.
Change-Id: Ie7d2941963977ba157d65970db21044e7eec9b6f
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The type of the generated fru data contained a map of a map
of a map of a map, but for all except the outermost map, all
elements were iterated over when using the map. Therefore,
change them to a vector<pair<...>> instead.
Vector should generate smaller code and allow faster iteration.
Vector insert and iteration are both linear where as map
is O(n lg n).
Change-Id: I475e5a40b4051e4ce9478a565c889c1751241987
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Eliminate one level of the generated "frus" map by creating
a structure for the lowest-level member.
This should reduce the impact of a gcc bug that consumes
excessive memory when compiling the generated map. Also
removed the runtime calculation of the 'delimiter' character
and instead generated it in the fru_gen python script.
Resolves openbmc/openbmc#1441.
Resolves openbmc/openbmc#1166.
Change-Id: Iafe049d034354d58b68d357b4f49fd5e21b2c8c7
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
|
|
|
|
|
|
|
|
|
|
| |
The iter{keys,items} functions have become just 'keys' and 'items'
in python3. Python2 also has keys and items, which is slightly
less efficient for iteration but none of these maps are large enough
to be of concern.
Change-Id: If6e8f36ad39074e0a6c022fb09e3a43b0928af19
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
|
|
|
|
|
|
|
|
| |
sdbusplus's bus object has a change in semantics that no longer
require a 'sd_bus_ref' call. See changes for openbmc/openbmc#1432.
Change-Id: I853b9d88aa5711d29be3edce5d4ad67bfd27b3d1
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
|
|
|
|
|
|
|
|
|
|
|
| |
There were references to the skeleton because it was still updating
items in the old namespace. This trims those out, however, doesn't
clean up all the extra bits. That will be a subsequent commit.
Fixes openbmc/openbmc#1425.
Change-Id: Ibe9af614458bced70f478f70ffb5b5195034bc7e
Signed-off-by: Patrick Venture <venture@google.com>
|
|
|
|
|
|
|
| |
Partially fixes openbmc/openbmc#875.
Change-Id: Ieaaa65fa8432ffa873dcf2f4f96f9c1e09de3008
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
|
|
|
|
|
|
|
| |
Partial fix for openbmc/openbmc#1112.
Change-Id: I467a9ffa68d9539c5c1f71e2dfa3281a347d5951
Signed-off-by: Leonel Gonzalez <lgonzalez@us.ibm.com>
|
|
|
|
|
|
|
| |
Add a script for generating PIM rules.
Change-Id: I9de54785938fcbf8de3a1ac8f42fa37a52f99d2c
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
|
|
|
|
|
|
| |
/xyz/openbmc_project/Inventory becomes
/xyz/openbmc_project/inventory
Change-Id: I95c1174b3cdbcd73a88c6bc004016e089c12f3e4
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|
|
|
|
|
| |
Change-Id: I8b403f07855cccb001eb63d6c5f11c5e1f58c874
Signed-off-by: Deepak Kodihalli <dkodihal@in.ibm.com>
|
|
|
|
|
|
|
|
|
|
| |
Make it possible for the openpower-vpd-parser recipe to be able to
supply the extra properties YAML as configurable input.
Use extra-properties-example.yaml as input.
Change-Id: I3cfffa6bb9709b4dbf5c487ab198960cc52e3863
Signed-off-by: Deepak Kodihalli <dkodihal@in.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
While the IPMI FRU parser, in order to update inventory, receives
most properties from the host IPMI, there could be some properties
whose values could be provided by other sources, such as the Machine
Readable Workbook.
Provide a mechanism to enable the above by having the extra property
information and values supplied via a YAML file, via which code is
generated, which in turn can be used by the parser to update inventory.
Change-Id: I30a2a9129d97485a0c31c3dec0155d5e1a008101
Signed-off-by: Deepak Kodihalli <dkodihal@in.ibm.com>
|
|
|
|
|
| |
Change-Id: I51f0decd8c71c4442556ce4d5fcfc10bd82efa48
Signed-off-by: Deepak Kodihalli <dkodihal@in.ibm.com>
|
|
|
|
|
| |
Change-Id: Idc83199d584ffe6d1b66debcb36244dd393495d0
Signed-off-by: Ratan Gupta <ratagupt@in.ibm.com>
|
|
|
|
|
| |
Change-Id: I9286045c3c10cd8bed840f03cfcc92a5b236d9ca
Signed-off-by: Ratan Gupta <ratagupt@in.ibm.com>
|
|
|
|
|
| |
Change-Id: I11784dd3faf3d4c6d76b8484b224e71a2817a95c
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>
|
|
|
|
|
| |
Change-Id: Id29024e34ac0c930fd4ff51c9886736324ea68e1
Signed-off-by: Deepak Kodihalli <dkodihal@in.ibm.com>
|
|
|
|
|
|
|
|
| |
The logic assumed IPMI FRU data is encoded in ascii always, but the data
could be ascii or binary. Handle both encodings.
Change-Id: Ie89bb077fd32a23bb96bd4cda78b66d2ccdd9774
Signed-off-by: Deepak Kodihalli <dkodihal@in.ibm.com>
|
|
|
|
|
|
|
|
| |
One of the IPMI FRU area checks deals with the old openbmc skeleton
interfaces, which is no longer valid. Fixed that.
Change-Id: Id406d4967d130136d4ac2a8efff94dac65d7ee0e
Signed-off-by: Deepak Kodihalli <dkodihal@in.ibm.com>
|
|
|
|
|
|
|
|
| |
The class ipmi_fru has a disabled default ctor, and the custom one
doesn't initialise all class members. Fix this issue.
Change-Id: I9a0364743ba5afe41a319f9091fd8b0bd85f1777
Signed-off-by: Deepak Kodihalli <dkodihal@in.ibm.com>
|
|
|
|
|
| |
Change-Id: I83efc8ad799aaa879525d84b97779d5b98f168c4
Signed-off-by: Ratan Gupta <ratagupt@in.ibm.com>
|
|
|
|
|
| |
Change-Id: Id83220e5e2876f4112ba76d698b2062e2a08dd3d
Signed-off-by: Ratan Gupta <ratagupt@in.ibm.com>
|
|
|
|
|
|
|
| |
This header contains c++ code.
Change-Id: I4bc6cf0ddfbdc6ac4d93580a5203bb59537bbb04
Signed-off-by: Ratan Gupta <ratagupt@in.ibm.com>
|