summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPatrick Venture <venture@google.com>2018-10-17 13:16:27 -0700
committerPatrick Venture <venture@google.com>2018-10-18 18:49:07 +0000
commit6b094f8b9d0908504358f5bb4b17c87a4511e3bc (patch)
tree8361f1e68e6b0b9d3b7fa85c62b114be3cc2251b
parent52f1f1892e9097aaebb4c1b3ca7fc76cf5126bb6 (diff)
downloadipmi-fru-parser-6b094f8b9d0908504358f5bb4b17c87a4511e3bc.zip
ipmi-fru-parser-6b094f8b9d0908504358f5bb4b17c87a4511e3bc.tar.gz
frup.cpp: drop unused variable
[frup.cpp:628] -> [frup.cpp:694]: (style) The expression 'sdr < 0' is always false. This is true because the value is set to 0 and never re-assigned. Change-Id: I668f5cc5a13a0c87afa3af978c341fb60f51b70d Signed-off-by: Patrick Venture <venture@google.com>
-rw-r--r--frup.cpp10
1 files changed, 0 insertions, 10 deletions
diff --git a/frup.cpp b/frup.cpp
index b3b2942..299c7cc 100644
--- a/frup.cpp
+++ b/frup.cpp
@@ -625,7 +625,6 @@ void _append_to_dict(uint8_t vpd_key_id, uint8_t* vpd_key_val,
IPMI_FRU_TYPE_LENGTH_TYPE_CODE_SHIFT;
int vpd_val_len =
type_length & IPMI_FRU_TYPE_LENGTH_NUMBER_OF_DATA_BYTES_MASK;
- int sdr = 0;
/* Needed to convert each uint8_t byte to a ascii */
char bin_byte[3] = {0};
@@ -690,15 +689,6 @@ void _append_to_dict(uint8_t vpd_key_id, uint8_t* vpd_key_val,
free(bin_in_ascii);
bin_in_ascii = NULL;
}
-
- if (sdr < 0)
- {
-#if IPMI_FRU_PARSER_DEBUG
- printf(
- "_append_to_dict : sd_bus_message_append Failed [ %d ] for [%s]\n",
- sdr, vpd_key_names[vpd_key_id]);
-#endif
- }
}
int parse_fru_area(const uint8_t area, const void* msgbuf, const size_t len,
OpenPOWER on IntegriCloud