summaryrefslogtreecommitdiffstats
path: root/drivers/clk/sunxi-ng/ccu-sun50i-a64.c
diff options
context:
space:
mode:
authorIcenowy Zheng <icenowy@aosc.io>2018-10-18 15:07:29 +0800
committerMaxime Ripard <maxime.ripard@bootlin.com>2018-11-05 09:20:52 +0100
commit859783d1390035e29ba850963bded2b4ffdf43b5 (patch)
treee76b9a6b312e085c1d891ab635675113746a6406 /drivers/clk/sunxi-ng/ccu-sun50i-a64.c
parent651022382c7f8da46cb4872a545ee1da6d097d2a (diff)
downloadblackbird-obmc-linux-859783d1390035e29ba850963bded2b4ffdf43b5.tar.gz
blackbird-obmc-linux-859783d1390035e29ba850963bded2b4ffdf43b5.zip
clk: sunxi-ng: enable so-said LDOs for A64 SoC's pll-mipi clock
In the user manual of A64 SoC, the bit 22 and 23 of pll-mipi control register is called "LDO{1,2}_EN", and according to the BSP source code from Allwinner , the LDOs are enabled during the clock's enabling process. The clock failed to generate output if the two LDOs are not enabled. Add the two bits to the clock's gate bits, so that the LDOs are enabled when the PLL is enabled. Fixes: c6a0637460c2 ("clk: sunxi-ng: Add A64 clocks") Signed-off-by: Icenowy Zheng <icenowy@aosc.io> Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
Diffstat (limited to 'drivers/clk/sunxi-ng/ccu-sun50i-a64.c')
-rw-r--r--drivers/clk/sunxi-ng/ccu-sun50i-a64.c7
1 files changed, 6 insertions, 1 deletions
diff --git a/drivers/clk/sunxi-ng/ccu-sun50i-a64.c b/drivers/clk/sunxi-ng/ccu-sun50i-a64.c
index 5f80eb018014..884d8f7863c4 100644
--- a/drivers/clk/sunxi-ng/ccu-sun50i-a64.c
+++ b/drivers/clk/sunxi-ng/ccu-sun50i-a64.c
@@ -162,7 +162,12 @@ static SUNXI_CCU_NM_WITH_FRAC_GATE_LOCK(pll_gpu_clk, "pll-gpu",
#define SUN50I_A64_PLL_MIPI_REG 0x040
static struct ccu_nkm pll_mipi_clk = {
- .enable = BIT(31),
+ /*
+ * The bit 23 and 22 are called "LDO{1,2}_EN" on the SoC's
+ * user manual, and by experiments the PLL doesn't work without
+ * these bits toggled.
+ */
+ .enable = BIT(31) | BIT(23) | BIT(22),
.lock = BIT(28),
.n = _SUNXI_CCU_MULT(8, 4),
.k = _SUNXI_CCU_MULT_MIN(4, 2, 2),
OpenPOWER on IntegriCloud