diff options
| author | Prem Shanker Jha <premjha2@in.ibm.com> | 2013-06-13 02:03:30 -0500 |
|---|---|---|
| committer | A. Patrick Williams III <iawillia@us.ibm.com> | 2013-07-30 16:44:18 -0500 |
| commit | e7987fefde72402ab4f6b3f76259535db650d7c5 (patch) | |
| tree | 27ef3b80580bbf7b08894d279f8cffbbe947f0c4 /src/usr/diag/prdf/common/framework/register/prdfRegisterCache.H | |
| parent | d00f7d882184b284ec108dbf109887bd022c8efb (diff) | |
| download | blackbird-hostboot-e7987fefde72402ab4f6b3f76259535db650d7c5.tar.gz blackbird-hostboot-e7987fefde72402ab4f6b3f76259535db650d7c5.zip | |
PRDF:Added access attribute in model of register in rule file.
Adding access attribute in register model helps to determine at run time
if register expects any read and write operation. Since data is no longer part
of register model, this additional attribute helps us to prevent unintentional
reading of a write-only register while accessing its current content ( during
cache miss ).
RTC: 51455
Change-Id: Ia2aeded8b63d675a1d4b5182171bce4c8b14d17b
Reviewed-on: http://gfw160.austin.ibm.com:8080/gerrit/5080
Tested-by: Jenkins Server
Reviewed-by: Christopher T. Phan <cphan@us.ibm.com>
Reviewed-by: A. Patrick Williams III <iawillia@us.ibm.com>
Reviewed-by: Zane Shelley <zshelle@us.ibm.com>
Reviewed-on: http://gfw160.austin.ibm.com:8080/gerrit/5590
Diffstat (limited to 'src/usr/diag/prdf/common/framework/register/prdfRegisterCache.H')
| -rw-r--r-- | src/usr/diag/prdf/common/framework/register/prdfRegisterCache.H | 14 |
1 files changed, 4 insertions, 10 deletions
diff --git a/src/usr/diag/prdf/common/framework/register/prdfRegisterCache.H b/src/usr/diag/prdf/common/framework/register/prdfRegisterCache.H index 411937af6..648faee63 100644 --- a/src/usr/diag/prdf/common/framework/register/prdfRegisterCache.H +++ b/src/usr/diag/prdf/common/framework/register/prdfRegisterCache.H @@ -72,18 +72,12 @@ class RegDataCache /** * @brief Returns the data buffer for the given target and address. - * @param i_pChip The target associated with the register. - * @param i_pRegister pointer to register to be read. - * @param o_readStat Returns true if the register does not exist in - * cache. In this case, the function will create and - * add an empty BIT_STRING_CLASS to the cache.It is - * the responsibilty of the user to update the data - * buffer by reading from hardware. + * @param i_chip The target associated with the register. + * @param i_reg Pointer to register to be read. * @return A reference to the data buffer associated with the register. */ - BIT_STRING_CLASS & read( ExtensibleChip* i_pChip, - const SCAN_COMM_REGISTER_CLASS * i_pRegister, - bool & o_readStat ); + BIT_STRING_CLASS & read( ExtensibleChip * i_chip, + const SCAN_COMM_REGISTER_CLASS * i_reg ); /** * @brief Flushes entire contents from cache. |

