summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorNick Bofferding <bofferdn@us.ibm.com>2014-09-23 15:28:18 -0500
committerA. Patrick Williams III <iawillia@us.ibm.com>2014-09-29 14:09:25 -0500
commitbe9cd0c114ca51fa30c1b92646a79c0f265fde54 (patch)
tree87f1018b1230f106b193d3cc102255c89c56b71e
parent2bb31a768a5825ab5befb40f89c91afb4bf0660e (diff)
downloadblackbird-hostboot-be9cd0c114ca51fa30c1b92646a79c0f265fde54.tar.gz
blackbird-hostboot-be9cd0c114ca51fa30c1b92646a79c0f265fde54.zip
Update story + comment for making PCI target generation data driven
- Updated MRW parser story/comment wrt making PCI target generation data driven Change-Id: I17348a621515e8da961fcc6899ce39c061e2f59b RTC: 94803 Reviewed-on: http://gfw160.aus.stglabs.ibm.com:8080/gerrit/13548 Tested-by: Jenkins Server Reviewed-by: A. Patrick Williams III <iawillia@us.ibm.com>
-rwxr-xr-xsrc/usr/targeting/common/genHwsvMrwXml.pl15
1 files changed, 14 insertions, 1 deletions
diff --git a/src/usr/targeting/common/genHwsvMrwXml.pl b/src/usr/targeting/common/genHwsvMrwXml.pl
index d42e3ea41..d668d1c7e 100755
--- a/src/usr/targeting/common/genHwsvMrwXml.pl
+++ b/src/usr/targeting/common/genHwsvMrwXml.pl
@@ -2655,7 +2655,20 @@ sub generate_pcies
my $proc_name = "n${node}:p${proc}";
print "\n<!-- $SYSNAME n${node}p${proc} PCI units -->\n";
my $max_index = 2;
- # TODO RTC: 94803
+
+ # TODO RTC: 116091
+ # Note: Originally the MRW parser created 3 PCI targets for every processor
+ # using a hard coded max_index value of 2. Defect SW238553 added logic to
+ # differentiate the number of targets based on processor type (3 for Murano,
+ # 4 for Brazos). This was erroneous, but by the time the problem was
+ # caught, it was too late in the release process to fix because the change
+ # would end up renumbering the HUID space. Since the extra target is
+ # benign, it was decided to leave the bad code in for the remainder of P8.
+ # This issue should be fixed in the first release of P9. If the number of
+ # PCI targets will be fixed across all P9 processors, simply remove the
+ # dynamic selection code in favor of a hard coded value. Otherwise, make
+ # the computation data driven by reading the # of PCI targets from
+ # appropriate MRW processor part.
if ($CHIPNAME eq "venice")
{
$max_index = 3;
OpenPOWER on IntegriCloud