diff options
| author | Sanjay Patel <spatel@rotateright.com> | 2018-09-04 21:17:14 +0000 |
|---|---|---|
| committer | Sanjay Patel <spatel@rotateright.com> | 2018-09-04 21:17:14 +0000 |
| commit | 0f70f86ce08f2535cb1cd9bffe159c55171f531d (patch) | |
| tree | fb425ff77974844b993728289683799e99207bd1 /llvm | |
| parent | f4ad2cb24f87ab4774d0df86d446a1735304f08e (diff) | |
| download | bcm5719-llvm-0f70f86ce08f2535cb1cd9bffe159c55171f531d.tar.gz bcm5719-llvm-0f70f86ce08f2535cb1cd9bffe159c55171f531d.zip | |
[InstCombine] make ((X & C) ^ C) form consistent for vectors
It would be better to create a 'not' here, but that's not possible yet.
llvm-svn: 341410
Diffstat (limited to 'llvm')
| -rw-r--r-- | llvm/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp | 6 | ||||
| -rw-r--r-- | llvm/test/Transforms/InstCombine/zext.ll | 4 |
2 files changed, 4 insertions, 6 deletions
diff --git a/llvm/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp b/llvm/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp index 19322dd6f5b..202ec074e58 100644 --- a/llvm/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp +++ b/llvm/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp @@ -2784,12 +2784,10 @@ Instruction *InstCombiner::visitXor(BinaryOperator &I) { return BinaryOperator::CreateAnd(Op0, Builder.CreateNot(X)); // (X & Y) ^ Y --> ~X & Y // (Y & X) ^ Y --> ~X & Y - // Canonical form with a non-splat constant is (X & C) ^ C; don't touch that. - // TODO: Why do we treat arbitrary vector constants differently? + // Canonical form is (X & C) ^ C; don't touch that. // TODO: A 'not' op is better for analysis and codegen, but demanded bits must // be fixed to prefer that (otherwise we get infinite looping). - const APInt *Unused; - if (!match(Op1, m_APInt(Unused)) && + if (!match(Op1, m_Constant()) && match(Op0, m_OneUse(m_c_And(m_Value(X), m_Specific(Op1))))) return BinaryOperator::CreateAnd(Op1, Builder.CreateNot(X)); diff --git a/llvm/test/Transforms/InstCombine/zext.ll b/llvm/test/Transforms/InstCombine/zext.ll index 887d839cb8c..a53bf6cc028 100644 --- a/llvm/test/Transforms/InstCombine/zext.ll +++ b/llvm/test/Transforms/InstCombine/zext.ll @@ -35,8 +35,8 @@ define <2 x i64> @test3(<2 x i64> %A) { define <2 x i64> @test4(<2 x i64> %A) { ; CHECK-LABEL: @test4( -; CHECK-NEXT: [[TMP1:%.*]] = xor <2 x i64> %A, <i64 63, i64 63> -; CHECK-NEXT: [[XOR:%.*]] = and <2 x i64> [[TMP1]], <i64 23, i64 42> +; CHECK-NEXT: [[AND:%.*]] = and <2 x i64> [[A:%.*]], <i64 23, i64 42> +; CHECK-NEXT: [[XOR:%.*]] = xor <2 x i64> [[AND]], <i64 23, i64 42> ; CHECK-NEXT: ret <2 x i64> [[XOR]] ; %trunc = trunc <2 x i64> %A to <2 x i32> |
