diff options
author | Dominic Chen <d.c.ddcc@gmail.com> | 2019-12-16 19:01:26 -0500 |
---|---|---|
committer | Dominic Chen <d.c.ddcc@gmail.com> | 2019-12-17 14:21:48 -0500 |
commit | 79b4c897b8ea5d28af1a2455c7409fc0df803079 (patch) | |
tree | f846c29b6dfef725a3ef5eb59095d7bbf44cd53f /llvm/tools/llvm-diff/DifferenceEngine.cpp | |
parent | a4e1819c16836dba928e646024a2406bb2eb3f94 (diff) | |
download | bcm5719-llvm-79b4c897b8ea5d28af1a2455c7409fc0df803079.tar.gz bcm5719-llvm-79b4c897b8ea5d28af1a2455c7409fc0df803079.zip |
llvm-diff: Perform structural comparison on GlobalVariables, if possible
Summary: Names of GlobalVariables may not be preserved depending on compilation options, so prefer a structural diff
Subscribers: llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D71582
Diffstat (limited to 'llvm/tools/llvm-diff/DifferenceEngine.cpp')
-rw-r--r-- | llvm/tools/llvm-diff/DifferenceEngine.cpp | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/llvm/tools/llvm-diff/DifferenceEngine.cpp b/llvm/tools/llvm-diff/DifferenceEngine.cpp index bc93ece8649..564ce787059 100644 --- a/llvm/tools/llvm-diff/DifferenceEngine.cpp +++ b/llvm/tools/llvm-diff/DifferenceEngine.cpp @@ -732,5 +732,14 @@ void DifferenceEngine::diff(Module *L, Module *R) { bool DifferenceEngine::equivalentAsOperands(GlobalValue *L, GlobalValue *R) { if (globalValueOracle) return (*globalValueOracle)(L, R); + + if (isa<GlobalVariable>(L) && isa<GlobalVariable>(R)) { + GlobalVariable *GVL = cast<GlobalVariable>(L); + GlobalVariable *GVR = cast<GlobalVariable>(R); + if (GVL->hasLocalLinkage() && GVL->hasUniqueInitializer() && + GVR->hasLocalLinkage() && GVR->hasUniqueInitializer()) + return GVL->getInitializer() == GVR->getInitializer(); + } + return L->getName() == R->getName(); } |