From 79b4c897b8ea5d28af1a2455c7409fc0df803079 Mon Sep 17 00:00:00 2001 From: Dominic Chen Date: Mon, 16 Dec 2019 19:01:26 -0500 Subject: llvm-diff: Perform structural comparison on GlobalVariables, if possible Summary: Names of GlobalVariables may not be preserved depending on compilation options, so prefer a structural diff Subscribers: llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D71582 --- llvm/tools/llvm-diff/DifferenceEngine.cpp | 9 +++++++++ 1 file changed, 9 insertions(+) (limited to 'llvm/tools/llvm-diff/DifferenceEngine.cpp') diff --git a/llvm/tools/llvm-diff/DifferenceEngine.cpp b/llvm/tools/llvm-diff/DifferenceEngine.cpp index bc93ece8649..564ce787059 100644 --- a/llvm/tools/llvm-diff/DifferenceEngine.cpp +++ b/llvm/tools/llvm-diff/DifferenceEngine.cpp @@ -732,5 +732,14 @@ void DifferenceEngine::diff(Module *L, Module *R) { bool DifferenceEngine::equivalentAsOperands(GlobalValue *L, GlobalValue *R) { if (globalValueOracle) return (*globalValueOracle)(L, R); + + if (isa(L) && isa(R)) { + GlobalVariable *GVL = cast(L); + GlobalVariable *GVR = cast(R); + if (GVL->hasLocalLinkage() && GVL->hasUniqueInitializer() && + GVR->hasLocalLinkage() && GVR->hasUniqueInitializer()) + return GVL->getInitializer() == GVR->getInitializer(); + } + return L->getName() == R->getName(); } -- cgit v1.2.3