diff options
| author | Adam Nemet <anemet@apple.com> | 2016-12-21 04:07:40 +0000 |
|---|---|---|
| committer | Adam Nemet <anemet@apple.com> | 2016-12-21 04:07:40 +0000 |
| commit | 32e6a34c02e625184f0a108a5d5c23a6cd90234c (patch) | |
| tree | 889f62a67831f0b9bcd6eea3bff50c9705045e3b /llvm/test/Transforms/LoopDistribute/diagnostics-with-hotness.ll | |
| parent | 1857800cb56caea13cee1e7e664d123274624322 (diff) | |
| download | bcm5719-llvm-32e6a34c02e625184f0a108a5d5c23a6cd90234c.tar.gz bcm5719-llvm-32e6a34c02e625184f0a108a5d5c23a6cd90234c.zip | |
[LDist] Match behavior between invoking via optimization pipeline or opt -loop-distribute
In r267672, where the loop distribution pragma was introduced, I tried
it hard to keep the old behavior for opt: when opt is invoked
with -loop-distribute, it should distribute the loop (it's off by
default when ran via the optimization pipeline).
As MichaelZ has discovered this has the unintended consequence of
breaking a very common developer work-flow to reproduce compilations
using opt: First you print the pass pipeline of clang
with -debug-pass=Arguments and then invoking opt with the returned
arguments.
clang -debug-pass will include -loop-distribute but the pass is invoked
with default=off so nothing happens unless the loop carries the pragma.
While through opt (default=on) we will try to distribute all loops.
This changes opt's default to off as well to match clang. The tests are
modified to explicitly enable the transformation.
llvm-svn: 290235
Diffstat (limited to 'llvm/test/Transforms/LoopDistribute/diagnostics-with-hotness.ll')
| -rw-r--r-- | llvm/test/Transforms/LoopDistribute/diagnostics-with-hotness.ll | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/llvm/test/Transforms/LoopDistribute/diagnostics-with-hotness.ll b/llvm/test/Transforms/LoopDistribute/diagnostics-with-hotness.ll index 63f63997e76..339467890dd 100644 --- a/llvm/test/Transforms/LoopDistribute/diagnostics-with-hotness.ll +++ b/llvm/test/Transforms/LoopDistribute/diagnostics-with-hotness.ll @@ -1,7 +1,7 @@ -; RUN: opt -loop-simplify -loop-distribute -S -pass-remarks-missed=loop-distribute \ +; RUN: opt -loop-simplify -loop-distribute -enable-loop-distribute -S -pass-remarks-missed=loop-distribute \ ; RUN: -pass-remarks-analysis=loop-distribute \ ; RUN: -pass-remarks-with-hotness < %s 2>&1 | FileCheck %s --check-prefix=HOTNESS -; RUN: opt -loop-simplify -loop-distribute -S -pass-remarks-missed=loop-distribute \ +; RUN: opt -loop-simplify -loop-distribute -enable-loop-distribute -S -pass-remarks-missed=loop-distribute \ ; RUN: -pass-remarks-analysis=loop-distribute \ ; RUN: < %s 2>&1 | FileCheck %s --check-prefix=NO_HOTNESS |
