From 32e6a34c02e625184f0a108a5d5c23a6cd90234c Mon Sep 17 00:00:00 2001 From: Adam Nemet Date: Wed, 21 Dec 2016 04:07:40 +0000 Subject: [LDist] Match behavior between invoking via optimization pipeline or opt -loop-distribute In r267672, where the loop distribution pragma was introduced, I tried it hard to keep the old behavior for opt: when opt is invoked with -loop-distribute, it should distribute the loop (it's off by default when ran via the optimization pipeline). As MichaelZ has discovered this has the unintended consequence of breaking a very common developer work-flow to reproduce compilations using opt: First you print the pass pipeline of clang with -debug-pass=Arguments and then invoking opt with the returned arguments. clang -debug-pass will include -loop-distribute but the pass is invoked with default=off so nothing happens unless the loop carries the pragma. While through opt (default=on) we will try to distribute all loops. This changes opt's default to off as well to match clang. The tests are modified to explicitly enable the transformation. llvm-svn: 290235 --- llvm/test/Transforms/LoopDistribute/diagnostics-with-hotness.ll | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'llvm/test/Transforms/LoopDistribute/diagnostics-with-hotness.ll') diff --git a/llvm/test/Transforms/LoopDistribute/diagnostics-with-hotness.ll b/llvm/test/Transforms/LoopDistribute/diagnostics-with-hotness.ll index 63f63997e76..339467890dd 100644 --- a/llvm/test/Transforms/LoopDistribute/diagnostics-with-hotness.ll +++ b/llvm/test/Transforms/LoopDistribute/diagnostics-with-hotness.ll @@ -1,7 +1,7 @@ -; RUN: opt -loop-simplify -loop-distribute -S -pass-remarks-missed=loop-distribute \ +; RUN: opt -loop-simplify -loop-distribute -enable-loop-distribute -S -pass-remarks-missed=loop-distribute \ ; RUN: -pass-remarks-analysis=loop-distribute \ ; RUN: -pass-remarks-with-hotness < %s 2>&1 | FileCheck %s --check-prefix=HOTNESS -; RUN: opt -loop-simplify -loop-distribute -S -pass-remarks-missed=loop-distribute \ +; RUN: opt -loop-simplify -loop-distribute -enable-loop-distribute -S -pass-remarks-missed=loop-distribute \ ; RUN: -pass-remarks-analysis=loop-distribute \ ; RUN: < %s 2>&1 | FileCheck %s --check-prefix=NO_HOTNESS -- cgit v1.2.3