diff options
| author | David L. Jones <dlj@google.com> | 2019-10-15 04:32:07 +0000 |
|---|---|---|
| committer | David L. Jones <dlj@google.com> | 2019-10-15 04:32:07 +0000 |
| commit | 6bfdebb412d87890c9c727a5975aed9cda66bf33 (patch) | |
| tree | 0a444c7ca0d9564ccdb3b6126ead7f9717156946 /llvm/lib/Transforms | |
| parent | 078bec6c48dd9d17ab9720897d2bb7ccbb886763 (diff) | |
| download | bcm5719-llvm-6bfdebb412d87890c9c727a5975aed9cda66bf33.tar.gz bcm5719-llvm-6bfdebb412d87890c9c727a5975aed9cda66bf33.zip | |
Revert [SROA] Reuse existing lifetime markers if possible
This reverts r374692 (git commit 92694eba933ef4ea0b1b6377809ff266df37d61b)
Reproducer sent to commit thread on llvm-commits.
llvm-svn: 374859
Diffstat (limited to 'llvm/lib/Transforms')
| -rw-r--r-- | llvm/lib/Transforms/Scalar/SROA.cpp | 10 |
1 files changed, 2 insertions, 8 deletions
diff --git a/llvm/lib/Transforms/Scalar/SROA.cpp b/llvm/lib/Transforms/Scalar/SROA.cpp index a36b3c50ea3..4b816832c31 100644 --- a/llvm/lib/Transforms/Scalar/SROA.cpp +++ b/llvm/lib/Transforms/Scalar/SROA.cpp @@ -3072,13 +3072,6 @@ private: LLVM_DEBUG(dbgs() << " original: " << II << "\n"); assert(II.getArgOperand(1) == OldPtr); - bool EntireRange = (NewBeginOffset == NewAllocaBeginOffset && - NewEndOffset == NewAllocaEndOffset); - - // If the new lifetime marker would not differ from the old, just keep it. - if (&OldAI == &NewAI && EntireRange) - return true; - // Record this instruction for deletion. Pass.DeadInsts.insert(&II); @@ -3089,7 +3082,8 @@ private: // promoted, but PromoteMemToReg doesn't handle that case.) // FIXME: Check whether the alloca is promotable before dropping the // lifetime intrinsics? - if (!EntireRange) + if (NewBeginOffset != NewAllocaBeginOffset || + NewEndOffset != NewAllocaEndOffset) return true; ConstantInt *Size = |
